[Fix] Recieving whispers while being /dnd

[Auntie Mangos]

Thanks to Klark20 we now have proof of official dnd response: http://img6.imageshack.us/img6/1463/wowscrnshot092411130440.jpg

Patch is complete and tested and please not forget about followup patch: http://getmangos.eu/community/topic/16890/merge-dnd-and-afk-auto-reply-message-variables/

PS: Keep in mind that with the arrival of Battle.net accounts they changed AFK to Away and DND to Busy (which was in 3.3.5) which results in a few other afk/dnd strings being incorrect on master but not on One or Zero. Nonetheless this does not have any impact on this patch

[stfx]

What bug does the patch fix? What features does the patch add?

Whispers should be displayed to the player even if he is /dnd

/dnd is usually used so that people get an auto answer like "stfx does not wish to be disturbed: no I wont help you". But not something where the person wont even get incomming messages (thats why we have /ignore someone).

This bug has been in the core like forever which simply is not like the retail behaviour. The only thing which might not be 100% retail after the patch is the changed mangos_string pattern.

For which repository revision was the patch created?

10541

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

no

Who has been writing this patch? Please include either forum user names or email addresses.

me, stfx

http://gist.github.com/597972

[VladimirMangos]

In GM case we cleary have setting when GM not like receive really whisper and see it.

[stfx]

Yes but players should still see the whispers of other players (GMs were working) while being /dnd

[Forusim]

There are some moments, where you wish to get no whisps at all, so i think it´s a good feature.

[Pfhaota]

It is not blizzlike however. You can use 3rd party addons (LUA) for that feature.

[VladimirMangos]

Changes can be acceptable as official way work but

1) need preserve current GM option work way

2) possible add config setting for control current custom way work and default official way.

In both cases possible instead modify string need add new short version.

/ignore for permanent ignore some characters, current way work /dnd is temporary ignore anyone.

[stfx]

Updated gist to [10720] with your requests included

[stfx]

Update gist to [11799] and removed server config which was added in last version of the patch after having spoken to Schmoozerd.

We now only need to know the retail /dnd response: Could somebody please make a screenshot on offi showing how you whisper somebody who is /dnd. Thanks

[Schmoozerd]

In [11813] Thank you.

[Cupcake]

Since this got backported to One aswell, is there anyone who played TBC on retail who can confirm this?

WoWWiki:

/dnd [message]

Toggles Do Not Disturb status. When DND is set, you cannot receive /whisper messages. A player attempting to send a /whisper will be notified that you have Do Not Disturb set. If you specify a message, they will also be sent that message.

[stfx]

WoWWiki is wrong, maybe it was like that in vanilla but I am 100% sure that this patch is correct for TBC or higher

[Cupcake]

OK,thanks for clarifying this, i asked just because i got mixed inputs from different persons.

[faramir118]

If in doubt, wiki's keep all edit history... you can go back in time.