[10709][patch] Transport GUIDs in SpellCastTargets

[zergtmn]

What bug does the patch fix? What features does the patch add?

Prevent sending wrong GUID in place of transport GUID.

For which repository revision was the patch created?

10577

Who has been writing this patch? Please include either forum user names or email addresses.

Me

Sniff (Angry Sara on top of Yogg-Saron):

S->C: SMSG_SPELL_GO (0x132) Size: 61
-----------------------------------------------------------------------------
Caster GUID: { 0xF13000816E008419, Type: Creature, Entry: 33134, Counter: 33817 }
Spell Id: 63795 (Psychosis)
Cast Flags: Unknown (0x4004108)
Timer: 1246913537
Hit target: { 0x7000000020A47D1, Type: Player }
Target Flags: Unit | SourceLocation (0x22)
Transport GUID: { 0xF15000820800846D, Type: Vehicle, Entry: 33288, Counter: 33901 }
Source Location: x=0, y=0, z=23.4861

Patch: http://gist.github.com/635096

Note: This patch does not implement proper filling of transport GUIDs!

[kbz]

does this fix arcane missile display?

[zergtmn]

I don't know what spells it does fix particularly maybe spells with target flags: Unit | SourceLocation like in first post.

[VladimirMangos]

Thank you In [10709].

Maybe we not need any this new and existed diff guids fields. I not remember cases when spell targets mask have more one case....

[zergtmn]

I have an example in sniffs

S->C: SMSG_SPELL_GO (0x132) Size: 77
-----------------------------------------------------------------------------
Caster GUID: { 0xF530006A8447E584, Type: Creature, Entry: 27268, Counter: 4711812 }
Spell Id: 48551 (Vengeful Stormhammer)
Cast Flags: Pending (0x410D)
Hit target: { 0xF130006AEF0029DD, Type: Creature, Entry: 27375, Counter: 10717 }
Target Flags: Unit | SourceLocation | DestLocation (0x62)
Transport GUID: { 0xF150006A690029D0, Type: Vehicle, Entry: 27241, Counter: 10704 }
Source Location: x = 0.2248, y = 0, z = 1.5676
Dest Location: x = 3801.67, y = -916.757, z = 159.681

Src guid is { 0xF150006A690029D0, Type: Vehicle, Entry: 27241, Counter: 10704 }

Dest guid is empty.

[VladimirMangos]

i see for location make sense when both at transport/vehicle