[10640] Instance high guid part

[Wojta]

What bug does the patch fix? What features does the patch add?

Instance id is guid, and as it is, it also has high guid part - 0x1F42.

For which repository revision was the patch created?

10637

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

no

Who has been writing this patch? Please include either forum user names or email addresses.

Me

This just add high guid value to enum and allows generation of instance low guid by ObjectMgr, instance system wont use this, I dont want to do anything with that part of mangos right now. Also, this changes nothing in client, i just find it interesting

This value is from Skullcrusher(EU).

http://gist.github.com/642687

[VladimirMangos]

Hmm, intresting... we use internal server instance ids generation so can easy switch to guid way work BUT

if this client guid then must be exist opcodes where it send to client in some way...

Do you know info about like opcodes?

[Wojta]

In most (if not all) packets where instance id is sent, uint64 is used (guess why), I know for sure it is in SMSG_CALENDAR_SEND_CALENDAR, SMSG_CALENDAR_RAID_LOCKOUT_ADDED and SMSG_RAID_INSTANCE_INFO.

[VladimirMangos]

Hmm, i not sure that this guid not have entry middle part. All cases that i see have: 1F 4? 08 00 02 ?? ?? ?? format

Also what nick you prefer: forum or git as commit author?

[Wojta]

well, i dont really know how can I recognize if guid has entry or not, but I think in one of my sniffs its different: http://valhalla-team.com/id.png

As for nick, use that from git, but it does not matter anyway...

[VladimirMangos]

In [10640] with added real usage. Thank you