[Fix] SpellBonus computation for % add spells

[ciphercom]

Computation of SpellBonus with %-value was not correct. When two Spells both add %-Heal (or anything else) they computed the interest of interest (hope that is the right term). So two 10% heal add actually improved heal by 21% not 20%. With high stacking spells from some bosses this really added up.

Repository version was [s0368]

Author: me (github[at]ciphercom.de)

http://paste2.org/p/1061293

[michalpolko]

This is interesting topic. Since I remember, overall dps on MaNGOS servers was much too high comparing to official servers.

Some tests from players found on wow community forums prove, that many (maybe all) % modifiers should be added, not multiplied by themselves.

This (probably) bug leads (example from my server) prot warriors to 1st place in arenas or battlegrounds (because this spec has A LOT of % modifiers and when they are multipied then they gain pretty big boost in damage).

[qsa]

This is interesting topic. Since I remember, overall dps on MaNGOS servers was much too high comparing to official servers.

Some tests from players found on wow community forums prove, that many (maybe all) % modifiers should be added, not multiplied by themselves.

This (probably) bug leads (example from my server) prot warriors to 1st place in arenas or battlegrounds (because this spec has A LOT of % modifiers and when they are multipied then they gain pretty big boost in damage).

The main reason for much bigger values are the stacking auras.

While this can also affect the final values, its effect is less that 1% overall.

Still nice thing to have tho.

Thanks.

[darkstalker]

i think dps is mangos is lower, cause of bugged spells/talents and wrong crit dmg calcualtion (will post patch later)

[michalpolko]

@qsa, yes, this is also a major problem

P.S. Has anyone a good fix for stacking buffs from passive areaauras? Unleashed Rage - Abomination's Might, Windfury Totem and Imp. Icy Talons etc.? ;P

[VladimirMangos]

most percent mods expected to be multiplier instead sum.

I sure in this because in past research this by many client creators and users comments.

From other side I not ready say that _all_ percent mods work as multipliers

For example: http://www.wowwiki.com/Percent