Proc aura cooldown for non-player type unit (Judgements etc.)

[michalpolko]

Mangos Rev. 10865

Proc auras can't use cooldown when aura is applied to unit of other type than player.

Example, Judgements:

Patch notes from 3.0.2:

http://www.wowwiki.com/Patch_3.0.2

Judgement of Light now heals based on the Paladin's attack power and spell power, the effect can not trigger more than once ever 4 seconds.

Judgement of Wisdom now restores mana based on the Paladin's attack power and spell power, the effect can not trigger more than once every 4 seconds.

I didn't find any more info in later patch notes so this probably wasn't changed. Right now Judgements proc always so 25ppl raid gets so much healing and mana from judgements...

Back to the topic... So when I try to fix the 4 sec. cooldown, the aura that proc's the judgement effects when applied to creatures simply proc every time, with no cooldown (cooldown is set to 0 by default).

Simple patch for allowing cooldown for non-players: http://pastebin.com/KAiQS5yE

Patch for Judgements cooldown: http://pastebin.com/Aue2zWPs

And SQL for this: http://pastebin.com/WdVHduuN

I tested this and looks like it works correctly, only 1 raid member gets heal/mana from judgement every 4 seconds (as described in patch notes).

[emsy]

hm, r u sure the cooldown is overall proc and not per player?

[michalpolko]

" the effect can not trigger more than once every 4 seconds." If it was to be 1 per person, then there would be something like " the effect can not trigger more than once every 4 seconds per attacker." I think

[michalpolko]

Hm, now that I look at this patch, maybe cooldown should always be processed for proc aura's caster, not the target?

[VladimirMangos]

" the effect can not trigger more than once every 4 seconds." If it was to be 1 per person, then there would be something like " the effect can not trigger more than once every 4 seconds per attacker." I think

Not very strong point: description often not discribe all details in work.

[darkstalker]

yea, never understood why cooldowns are strictly on Player class, they should be on Unit class who inherits to Player

[michalpolko]

Not very strong point: description often not discribe all details in work.

Yeah, I know, if I will gather info about it i will post judgements cooldown patch separately. Right now please review the main patch, as in title - allow processing cooldown for auras applied on all units. It's like closed door for further research.

[faramir118]

In a combat log, you can look at the diff between each proc's timestamp

Should be able to tell if it is per-player if the diff is less than 4 seconds

[VladimirMangos]

Not very strong point: description often not discribe all details in work.

Yeah, I know, if I will gather info about it i will post judgements cooldown patch separately. Right now please review the main patch, as in title - allow processing cooldown for auras applied on all units. It's like closed door for further research.

I not see how adding this help in research... also it anyway skipped in proc handlers.

[michalpolko]

Just this part

the effect can not trigger more than once ever 4 seconds.

says, that cooldown should be processed in Judgements case, so probably there are more auras which currently also work in a wrong way - can't have proc cooldown, but should as we can see.

If this is not added, then in Judgement proc handling we have cooldown = 0 always (default), in other similiar auras case - the same, so we can't fix some proc events cooldowns.

[Vassago]

Still bugged on MaNGOS 11100.

As an example: with Judgement of Light, you heal yourself with each attack. Either if the cooldown is by player or by group, it heals everytime.