[Mangos-0.12] Backporting

[mns]

Base commits : [10781] [10782]

I research several commits for full backporting but some commits refers to before mangos switch to Git and SVN researching is very hard

[10782]->[10781]->[8818]->[8813]-> Git over !

->[7269]->[9910]->[10363]

After backporting [8818] must reapply this for some enums .

http://www.speedyshare.com/files/25855953/download/10781-10782%20TBC%204.patch

Note : I not stability test for this yet .

[VladimirMangos]

for svn you can use https://github.com/VladimirMangos/mangos-svn/tree/head

[mns]

thx

very good

[VladimirMangos]

About bg commits for backport. Some commits dependent for clean apply from applied in end of 2009 year and current top in backporting near to this time so maybe batter wait with until its backporting in normal order. [8818] in other side cleary applied so i backport it in [s0566]. Thank you for pointing to it.

I will return to this thread as will backported 2009 end bg changes (mostly in port to bg code)

[mns]

ok

I backporting this again for [s0566]

base commits :

[8474]

[8813]

[8815]

[10781]

[10782]

http://www.yourfilelink.com/get.php?fid=597722

I will test stability test at tomorrow

Note : I do not correcting SQL and commit revision and makefile.am . commiter will be .....

[mns]

Not stable

Crash server when join Eye of the Storm .

[VladimirMangos]

I find typo that generate this crash:

            BattleGroundBracketId bracket_id = BattleGroundBracketId(scheduled[i] & 255);

In old code it 256 and in result generate out of range bracket ids

I do backport [8474][8813][8815] in [s0645]

[added]I do diff testes and look like not crash in described cases. Anyway please report if any stability problems start...

[VladimirMangos]

Mns, I backport listed by you last commits + some additional related to warninп fixes in [s0646].

Thank you for help research problem with this part backports

[mns]

Thank you .

I will testing last revision tomorrow and feed back to you

[mns]

Not stable .

Exception code: C0000005 ACCESS_VIOLATION
Fault address:  0000000078656B2E 01:0000000000035B2E C:\\WINDOWS\\WinSxS\\amd64_Microsoft.VC90.CRT_1fc8b3b9a1e18e3b_9.0.21022.8_x-ww_0296E955\\MSVCR90.dll

Registers:
RAX:000000007FFFFFFE
RBX:0000000000000002
RCX:0000000000000002
RDX:0000000000000007
RSI:0000000000000025
RDI:000000000A596A73
R8: 0000000078620000
R9: 0000000000000000
R10:0000000000000200
R11:0000000000000000
R12:000000000A598F58
R13:00000000FFFFFFFF
R14:00000000FFFFFFFF
R15:000000000A5960A0
CS:RIP:0033:0000000078656B2E
SS:RSP:002B:000000000A596640  RBP:024BA967
DS:002B  ES:002B  FS:0053  GS:002B
Flags:00010202

Call stack:
Address   Frame     Function      SourceFile
0000000078656B2E  000000000A596940  _vcwprintf_s+2A06
0000000078635564  000000000A5969B0  _vsnprintf_l+80
00000000786355AD  000000000A5969F0  _vsnprintf+11
00000001402EC3E7  000000000A598470  MaNGOS::WorldWorldTextBuilder::operator()+97  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\world.cpp line 1518
00000001402EC2D3  000000000A598D50  MaNGOS::LocalizedPacketListDo<MaNGOS::WorldWorldTextBuilder>::operator()+1B3  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\gridnotifiersimpl.h line 512
00000001402E01AA  000000000A598F30  World::SendWorldText+1DA  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\world.cpp line 1570
000000014035EA01  000000000A599370  BattleGroundQueue::AddGroup+291  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\battlegroundmgr.cpp line 184
0000000140520014  000000000A59F7D0  WorldSession::HandleBattlemasterJoinArena+934  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\battlegroundhandler.cpp line 697
00000001402D65AD  000000000A59F870  WorldSession::ExecuteOpcode+5D  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\worldsession.cpp line 571
00000001402D46D5  000000000A59FAC0  WorldSession::Update+135  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\worldsession.cpp line 186
00000001402E150C  000000000A59FC00  World::UpdateSessions+14C  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\world.cpp line 1853
00000001402DF5B7  000000000A59FDC0  World::Update+2E7  d:\\compail-folder\\39-[s0651]_1934\\src\\game\\world.cpp line 1386
000000014006F116  000000000A59FE80  WorldRunnable::run+A6  d:\\compail-folder\\39-[s0651]_1934\\src\\mangosd\\worldrunnable.cpp line 61

2011-01-09 10:07:13 WORLD: CMSG_BATTLEMASTER_JOIN_ARENA
2011-01-09 10:07:13 Battleground: arena join as group start
2011-01-09 10:07:13 Battleground: arena team id 5675, leader Djali queued with rating 1500 for type 2
2011-01-09 10:07:13 Adding Group to BattleGroundQueue bgTypeId : 6, bracket_id : 6, index : 1

Apparently queue announcer crashing .

[VladimirMangos]

ok, i will compare DB strings for it, maybe need sync with master

[VladimirMangos]

I found missing sql update that i lost at backporting because mangos.sql already include this strings.

Fixed in [s0656].