[fixed] Strange values in MSG_PVP_LOG_DATA

[yad02]

MaNGOS : 10920

SD2 : no

Custom patches : AHBot MMaps

MSG_PVP_LOG_DATA packet sent strange value 3999 for all arena players and winner color is false.

In fact when you win an arena (for exemple you are gold) it say "gold team win" but gold lines are players from green team.

[michalpolko]

Confirmed.

Also rating changes are wrong, like if both teams started with 4k rating.

[ankso]

Both problems confirmed. Long time with this bug.

[Lightguard]

Please try this:

diff --git a/src/game/BattleGroundMgr.cpp b/src/game/BattleGroundMgr.cpp
index 69bb705..4936a95 100644
--- a/src/game/BattleGroundMgr.cpp
+++ b/src/game/BattleGroundMgr.cpp
@@ -1274,9 +1274,12 @@ void BattleGroundMgr::BuildPvpLogDataPacket(WorldPacket *data, BattleGround *bg)
        // it seems this must be according to BG_WINNER_A/H and _NOT_ BG_TEAM_A/H
        for(int i = 1; i >= 0; --i)
        {
-            *data << uint32(bg->m_ArenaTeamRatingChanges[i]);
-            *data << uint32(3999);                          // huge thanks for TOM_RUS for this!
-            *data << uint32(0);                             // added again in 3.1
+            uint32 pointsLost = bg->m_ArenaTeamRatingChanges[i] < 0 ? abs(bg->m_ArenaTeamRatingChanges[i]) : 0;
+            uint32 pointsGained = bg->m_ArenaTeamRatingChanges[i] > 0 ? bg->m_ArenaTeamRatingChanges[i] : 0;
+
+            *data << uint32(pointsLost);                        // Rating Lost
+            *data << uint32(pointsGained);                      // Rating gained
+            *data << uint32(0);                                 // Matchmaking Value
            DEBUG_LOG("rating change: %d", bg->m_ArenaTeamRatingChanges[i]);
        }
        for(int i = 1; i >= 0; --i)

(original patch by thenecromancer)

[VladimirMangos]

In [10955]. Thank you. But maybe you can next time commit by self if patch tested