[11145] Miss and Resist should have same combat-reactive as any other

[Feanordev]

Not sure if It was made already but couldn't find on forum so...

(Used same way to set reaction as normal-hit handling does)

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index 0a15b32..8a1e69e 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -1137,6 +1137,20 @@ void Spell::DoAllEffectOnTarget(TargetInfo *target)
            DoSpellHitOnUnit(m_caster, mask);
    }

+    if(missInfo == SPELL_MISS_MISS || missInfo == SPELL_MISS_RESIST)
+    {
+        Unit* realCaster = GetAffectiveCaster();
+        if(realCaster && realCaster != unit)
+        {
+            if (!unit->isInCombat() && unit->GetTypeId() != TYPEID_PLAYER && ((Creature*)unit)->AI())
+                ((Creature*)unit)->AI()->AttackedBy(realCaster);
+
+            unit->AddThreat(realCaster);
+            unit->SetInCombatWith(realCaster);
+            realCaster->SetInCombatWith(unit);
+        }
+    }
+
    // All calculated do it!
    // Do healing and triggers
    if (m_healing)

[michalpolko]

Confirmed, creatures should get in combat when our spell/attack is missed or resisted. And the patch looks ok

[Ambal]

In [11145]. Cheers

[VladimirMangos]

What about SPELL_ATTR_EX3_NO_INITIAL_AGGRO...

[VladimirMangos]

In [11153] added same checked for not set aggro mode that used for normal spell hit case.

In original added version code look strange, it can aggro target at miss in cases when normal hit will not triggering aggro.