[mangos-one] Fix liquid extraction

[stfx]

What bug does the patch fix? What features does the patch add?

Fix lava/slime liquid extraction from WMO data (indoors and in dungeons).

Fixes environmental damage in Molten Core, Ragefire, Blackrock Mountain, Blackrock Spire, Blackrock Depths and Naxxramas.

For which repository revision was the patch created?

s0920 (mangos-one)

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No.

Who has been writing this patch? Please include either forum user names or email addresses.

Me, stfx

This problem is as old as mangos itself but due to the vmap3 backport we can adress the issue now. Though there a few differences from master because we cant get the liquid type in the same way. Also as far as I know there is no 100% correct way because their simply is not enough data provided in the .wmo.

Now to describe the problem a little bit more in detail:

issue #1: The data from liquid_type.dbc is totally useless and different from master

issue #2: The liquid flags from the WMOs are only partially usable because for example the flag for the lava in ragefire is the same as on the lake in a cave in nagrand (and possible other places as well)

Here is the logged data from the WMOs: http://pastebin.com/BzbsSFaT

Now after my first approach which is less hacky, there is atleast one location being extracted with a wrong liquid type, which looked like that: http://code.google.com/p/oregoncore/source/detail?r=5a4f38973dbbf2d1aca519b617c64c02eccbc3f2

Here is the reason why (logged data in form of an Excel sheet - see line #99): https://spreadsheets.google.com/ccc?key=0AtP7KyCg177NdFFOQUhJb1BzbmJyLWNzR2diVzdvMXc&hl=en&authkey=CN3n5toM

So finally here is the patch which allows us to remove one hack from player.cpp but adds a hack as it checks for wmo name in the vmap extractor:

http://pastebin.com/UfP0y7ww

After that vmaps finally work as they were intended to be and fixed bugs which have been in the core for a far too long time.

[lillecarl]

It must be better to do the "hacks" as early as possible so it does not need to run more then once (just like you did)

[stfx]

Added to one here: https://github.com/mangos-one/server/commit/ac072cee5282151fb5aa5c19ae24854d39e641b5

and was also added to zero here: https://github.com/mangos-zero/server/commit/e1d6fd75dce9a9881fb8eff942c9733f2db48242

Can now be moved to approved section I guess