[11352] Send SMSG_NEW_WORLD after teleport destination set

[BThallid]

What does this patch do?

Moves the SMSG_NEW_WORLD packet so it is sent after player m_teleport_dest is set and after TeleportFar is set.

It seems that the server should do some of the work while the client state is in pending mode instead of just sending SMSG_TRANSFER_PENDING and then SMSG_NEW_WORLD directly afterwards. Rearranging the code like this will also allow the core to do other actions in the future during this intermission.

Flow process:

1. Client is teleported to another map

2. Server informs client of pending status (SMSG_PENDING_TRANSFER sent)

3. Client shows load screen for pending map

4. Server removes client from old map, set m_teleport_dest, set teleport far to true

5. Server informs client of new world status (SMSG_NEW_WORLD is sent)

6. Client begins to load new map and loading progress bar moves (MSG_MOVE_WORLDPORT_ACK is sent)

What revision/commit is patch for?

11260 - 9359c427

Who has been writing patch?

me (BThallid)

http://paste2.org/p/1323483

Updated 2011-03-24: Adjusted SMSG_NEW_WORLD for if on transport.

[BThallid]

Just thought I would note on here that apparently this was placed into TrinityCore https://github.com/TrinityCore/TrinityCore/commit/e864b0a61176f30ca27961a564c77d5e5c3335b1 with the mention that it "Fixed naked bug for players" which I have not tested.

[shauren]

it does fix certain cases of naked bug, but not all of them

also i would like to point out that your patch is not fully correct (when using final_* coords)

when player is on transport you must send transport offsets instead (confirmed in sniffs)

[VladimirMangos]

not see any cases naked bug with far teleports, but mostly show up at just login near another player.

Cleary this change NOT fix naked bug and not related to it.

[BThallid]

not see any cases naked bug with far teleports, but mostly show up at just login near another player.

Cleary this change NOT fix naked bug and not related to it.

I never claimed that it would fix anything. I just saw it as an intermission section for map loading and possibly other processes.

[VladimirMangos]

In [11352]. Thank you