[Mangos-One][Exploit][Patch] Arena rating calculates

[mns]

Exploit : player can join to arena with wrong rating calculating .

For example :

player create group with two hero and converting to raid . then logoff one hero and join arena with online hero .

now core not see rating of offline hero and ....

then offline player will be login again and wait for enter arena .

fix :

diff --git a/src/game/BattleGroundHandler.cpp b/src/game/BattleGroundHandler.cpp
index b80410a..d3b3d6a 100644
--- a/src/game/BattleGroundHandler.cpp
+++ b/src/game/BattleGroundHandler.cpp
@@ -672,16 +672,22 @@ void WorldSession::HandleBattlemasterJoinArena( WorldPacket & recv_data )
        // the arena team id must match for everyone in the group
        // get the personal ratings for queue
        uint32 avg_pers_rating = 0;
+        uint8 members_count = 0;
        for(GroupReference *itr = grp->GetFirstMember(); itr != NULL; itr = itr->next())
        {
            Player *member = itr->getSource();

            // calc avg personal rating
            avg_pers_rating += member->GetArenaPersonalRating(arenaslot);
+            members_count++;
        }

        if (arenatype)
+        {
+            if (arenatype != members_count)
+                return;
            avg_pers_rating /= arenatype;
+        }

        // if avg personal rating is more than 150 points below the teams rating, the team will be queued against an opponent matching or similar to the average personal rating
        if (avg_pers_rating + 150 < arenaRating)

Maybe same problem in master branch but i not test this .

[VladimirMangos]

Ok, problem clear, BUT is it correct prevent join to arena with offline members?

[mns]

i now tell too my friend and ask this to he .

he say in blizz player can join in this case .

Thus my patch not blizzlike .

maybe core must can calculate offline hero rating

[VladimirMangos]

Yes, possible for offline player need ask DB for data. Maybe with adding wrapper and use new DB prepared statements way.

ok, its not backported to One yet.

[VladimirMangos]

Problem, can be solved lot easy in fact. All data already loaded and stored in ArenaTeam structure

Implemented in [11349].

Hmm, my change look like wrong. I will fix in next commit. With current version for arena team different from exactly arena type size it will wrongly calculated..., mostly need revert and implement mixed way, loop by group guids but look data in team. Aslo let check: in group must be only team members.

If patch will prepared i can commot it. I need finish arenaTeam enum use patch.

[VladimirMangos]

Must be fixed in [11351]. Maybe now i do it in right way ^^