Raptor Captor - Questcredit

[DaC]

What bug does the patch fix? What features does the patch add?

Questcredit was not given

For which repository revision was the patch created?

MaNGOS One - latest revision

Who has been writing this patch? Please include either forum user names or email addresses.

me

QuestCredit has to be given to affected caster.

From 7bcce2eb72f6d0e02db3b68aa9ecf71fd7bc488f Mon Sep 17 00:00:00 2001
From: DaC <[email protected]>
Date: Sat, 11 Jun 2011 19:13:01 +0200
Subject: [PATCH] Fix spell for quest: Raptor Captor

---
src/game/SpellEffects.cpp |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 5915a0a..f134b6c 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -1229,7 +1229,7 @@ void Spell::EffectDummy(SpellEffectIndex eff_idx)
                    creatureTarget->ForcedDespawn();

                    //cast spell Raptor Capture Credit
-                    m_caster->CastSpell(m_caster, 42337, true, NULL);
+                    m_caster->CastSpell(GetAffectiveCaster(), 42337, true, NULL);
                    return;
                }
                case 44997:                                 // Converting Sentry
-- 
1.7.0.2.msysgit.0

regards, DaC

[Schmoozerd]

Can GetAffectiveCaster() be NULL? (in general or in this case)

[VladimirMangos]

// real source of cast affects, explicit caster, or DoT/HoT applier, or GO owner, or wild GO itself. Can be NULL

WorldObject* GetAffectiveCasterObject() const;

[DaC]

Thanks for the hint:

                    //cast spell Raptor Capture Credit
-                    m_caster->CastSpell(m_caster, 42337, true, NULL);
+                    if (GetAffectiveCaster())
+                        m_caster->CastSpell(GetAffectiveCaster(), 42337, true, NULL);
                    return;
                }
                case 44997:                                 // Converting Sentry

[VladimirMangos]

Hmm, I test related code and I don't understand why this changes need: for my testes always m-caster pointed to proper player object.

[added]I test in master. So will retest in One, but not expect differences.

[added2]At One also work fine... (not work for me while i not leave raid group as expected, but need for me some time find this ^^ )