[Patch] [8076] Walking again...

[yad02]

All credits/thanks to TOM_RUS, he has fixed all movement in 3.1.X.

I just follow his work.

[Taur]

I don't know if it was your patch yad02, but with:

data << uint32(GetTypeId() == TYPEID_PLAYER ? MONSTER_MOVE_WALK : MovementFlags);

works. Maybe it's not related though, don't know.

[VladimirMangos]

Hmm, but in suggested form it switch to run if start flight with walk mode...

[added]nos4r2zod, With big chance I will appply your patch, but before need resolve really BIG probelm

with use Unit::m_unit_movement_flags for store 2 totally different things: MovementFlags and MonsterMovmenetFlags, and restore fill this or new field by player movement flags received from packets.

I reseatch ways of this problem fix currently. Not easy and affect DB/scripts...

[VladimirMangos]

I test your patch and re-found why stop move added in this code. It prevent cheating with stay at griffon when at client path finished but server not stop taxi movment at own side. If this call not present then taxi user can fly to any point and stop taxi in this point instead expected point.

As you already note, main problem with moster move call in StopMoving(), but it infact not have any real meaning in functionality. It just "nice" return player to point.

[VladimirMangos]

Rewrited patch in [8076]. Base at most similarity to original thenecromancer's patch i make he main author of commit.

But thanks all who take part in problem resolving

[Arthus28]

Please let me ask a stupid question: What is the difference between MOVEMENTFLAG_* and MONSTER_MOVE_*. I already noticed that they are different but when the first one is used and when the second?

[VladimirMangos]

I currerntly prepare pach to resolve it mixied use. (added: in [8077])

In short (thanks for tom for clarify this):

MOVEMENTFLAG_ use in many packets, most visible in player move packets. Mostly player related.

MONSTER_MOVE_* use _only_ in SMSG_MONSTER_MOVE packet, this is (moster moved flags) expected to be in all DB move_flag fields. Mostly creature related (and playes in case when player controled as creature in some cases)

[alexluana]

does this fix the situation after death?

It happend to me that sometimes after I die, my ghost form walks instead of running and I have to press / ...

With respect,

Axel