[11652][Fix]Diminishings for Turn Evil and Judgement of Justice in PvP

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Judgement of Justice: Unlike the rest of the judgements, JoJ should have its PvP duration of 10s

Turn Evil: It should have the same diminishing returns than fear.

For which repository revision was the patch created?

r11620

Is there a thread in the bug report section or at lighthouse?

http://getmangos.eu/community/topic/13859/spellbug-judgement-of-justice/

Who has been writing this patch? Please include either forum user names or email addresses.

Me

Spells affected:

Judgement of Justice:

Id: 20184

SpellFamilyName: 10

SpellFamilyFlags1: 0x100000 (only JoJ have this flags)

SpellFamilyFlags2: 0

SpellFamilyFlags3: 0

Turn Evil (there are many paladin spells with same SpellFamilyFlags, so check for the icon is also required):

Id: 10326

SpellFamilyName: 10

SpellIconID: 309

SpellFamilyFlags1: 0

SpellFamilyFlags2: 0x804000

SpellFamilyFlags3: 0

Id: 57546

SpellFamilyName: 10

SpellIconID: 309

SpellFamilyFlags1: 0

SpellFamilyFlags2: 0x804000

SpellFamilyFlags3: 0

Fix:

https://gist.github.com/1033602

[VladimirMangos]

Hmm, i not see _many_ spells fit to mask 0x80000000000000, in any case for second case spells have mechanic MECHANIC_TURN and other cases with this mechanic excluded already. So better in generic way include MECHANIC_TURN in checks for DIMINISHING_FEAR_CHARM_BLIND.

In [11652] with this change. Thank you