[11772] Addition in Aura::HandleAuraModIncreaseEnergyPercent

[breakwater]

What bug does the patch fix? What features does the patch add?

Set Health to max for some Spell's with increase HealthPercent

For which repository revision was the patch created?

my revision is 11708, but this fix is also for newer and older revisions

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

I don't know

Who has been writing this patch? Please include either forum user names or email addresses.

me

Maybe we find other spells.

Examples: 56257, 59911, 60430

But i don't use this spells

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 5e01875..7e5905c 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -6582,7 +6582,21 @@ void Aura::HandleAuraModIncreaseEnergyPercent(bool apply, bool /*Real*/)

void Aura::HandleAuraModIncreaseHealthPercent(bool apply, bool /*Real*/)
{
-    GetTarget()->HandleStatModifier(UNIT_MOD_HEALTH, TOTAL_PCT, float(m_modifier.m_amount), apply);
+    Unit *target = GetTarget();
+
+    if (!target)
+        return;
+
+    target->HandleStatModifier(UNIT_MOD_HEALTH, TOTAL_PCT, float(m_modifier.m_amount), apply);
+    switch (GetId())
+    {
+        case 64193:                                 // Heartbreak (Ulduar - XT-002)
+        case 65737:
+            target->SetHealth(target->GetMaxHealth());
+            break;
+        default:
+            break;
+    }
}

void Aura::HandleAuraIncreaseBaseHealthPercent(bool apply, bool /*Real*/)

EDIT: I have add this Spell 64582

[VladimirMangos]

hmm, but if current health < max case? instant full health heal, is this expected?

[Xfurry]

hmm, but if current health < max case? instant full health heal, is this expected?

Yes, this is expected, but is should be noted that both of the spells (64193 and 65737) have script "Script Effect

Value: 100". Maybe the healing effect is set through this effect.

[michalpolko]

more of these: http://www.wowhead.com/spell=60430 this currently does not set health to any other value, only max is changed.

[VladimirMangos]

Note: target can be NULL by way how it setup in Aura.

With drop this check and add on more spell in [11772]. Thank you

p.s. affter adding code i start think maybe max health part will better fix in some scripting (i meaning DLL scripts side), but added then added.

[michalpolko]

Handling this by scripts didn't always work for me, often creatures had max health increased but current health wasn't always maxed. I hope fixing in core solves this