[One] ReCalculateHealAtPeriodicTick

[rowman]

* What bug does the patch fix? What features does the patch add?

periodicheal ignored changing addheal (caster)

* For which repository revision was the patch created?

ONE

* Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

dont know

* Who has been writing this patch? Please include either forum user names or email addresses.

me

diff --git a/src/game/SpellAuras.cpp 
b/src/game/SpellAuras.cpp index b36131d..6299286 100644 
--- a/src/game/SpellAuras.cpp 
+++ b/src/game/SpellAuras.cpp 
@@ -5853,6 +5934,7 @@ 
void Aura::PeriodicTick()              
else
              pdamage = amount;
+            pdamage = pCaster->SpellHealingBonusDone(target,spellProto,pdamage,DOT,GetStackAmount());
             pdamage = target->SpellHealingBonusTaken(pCaster, spellProto, pdamage, DOT, GetStackAmount());
             DETAIL_FILTER_LOG(LOG_FILTER_PERIODIC_AFFECTS, "PeriodicTick: %s heal of %s for %u health inflicted by %u",

[laise]

what spell is bugged and why healing-done should be updated on tick?

[rowman]

little example:

activate trinkets and other addheal buffs

use booming life (now high tick caused by high addheal)

trinkets etc expire

blooming life tick is still high as long as you renew bl

[laise]

Yeah but is there any source of information to confirm that this is how it used to worked on retail? (because 3.3.5 and later should work this way)

[rowman]

im quite sure thats the way it worked @ 2.4.3, but not yet found any source ...

[betagan]

No It is NOT the way it worked on 2.4.3.

example: relic macros (druid/pala). you have your macros to switch the correct relict (lets say +healing on rejuvenation), then cast that spell. same for your other healing spells. I'm really sure this worked on retail. The ticks of rejuv would stay the same.

I'm not sure however about the lifebloom issue. refreshing the lifebloom stacks MIGHT cause recalculation. But NOT the periodic tick.

[VladimirMangos]

I also think that this confirmed in past that caster done bonuses part calculated at apply and not dependent from later caster gear/buffs/talents changes.

Except paladin group auras like things but this special "area aura around caster" case

[rowman]

hmm ok wrong memories... its been a long time

but a renewal shouldnt assume the old calculation ?!