Jump to content

fix: BattleGround teleport issue


Auntie Mangos
 Share

Recommended Posts

What bug does the patch fix? What features does the patch add?

Bug: while I'm in BG, if my client crash while I'm dead and if the bg is already closed when I log in back in game I'm dead where I joined bg. It should ress me when teleport, instead to teleport me dead.

For which repository revision was the patch created?

my revision is 11774

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/topic/16773/dead-if-crash-in-bg/

Who has been writing this patch? Please include either forum user names or email addresses.

me

Patch: http://paste.ubuntu.com/661954/

@@ -1021,10 +1021,12 @@ void BattleGround::RemovePlayerAtLeave(ObjectGuid guid, bool Transport, bool Sen
        {
            plr->ResurrectPlayer(1.0f);
            plr->SpawnCorpseBones();
        }
    }
+    else
+        sObjectAccessor.ConvertCorpseForPlayer(guid);

    RemovePlayer(plr, guid);                                // BG subclass specific code

    if(participant) // if the player was a match participant, remove auras, calc rating, update queue
    {

Link to comment
Share on other sites

  • 42 years later...
  • 3 weeks later...

I cannot see why this patch actually works ..

The whole Player loading related to alive state is a bit unclear to me atm..

Also I think this very rare case should be handled by Player::LoadFromDB as well

(the plr == NULL check is kind of ugly to check for this case, there could be some complicated other cases)

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
 Share

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use