[Fixed in 11857][Bug] Druid trainers

[Jethrogibbs]

Post to my players

Hello it has a problem with the Druids to learn the techniques to the master of the Druids

After verification, it turns out that this bug exists. ( npc_trainer_template entry 111)

It seems that this bug only affects druids trainers

Bug also posted UDB

[angeleyes]

Druid trainers learn all spells to lvl 1 at the moment.

Even cat form, bear form and flight form!

This is absolutely incorrect.

[Schmoozerd]

There is probably some core problem related, the problem is that I only know that druids can be used for mounts or other hairy desires.

So:

Can you please give spell-ids of spells that are taught on wrong level, and which requirements they should have, and how they should be obtained (for proper testing)

[angeleyes]

I'll ask around about that, will come back on it.

[Schmoozerd]

diff --git a/src/game/NPCHandler.cpp b/src/game/NPCHandler.cpp
index db7b035..d2b9a0c 100644
--- a/src/game/NPCHandler.cpp
+++ b/src/game/NPCHandler.cpp
@@ -131,7 +131,7 @@ static void SendTrainerSpellHelper(WorldPacket& data, TrainerSpell const* tSpell
    data << uint32(primary_prof_first_rank && can_learn_primary_prof ? 1 : 0);
    // primary prof. learn confirmation dialog
    data << uint32(primary_prof_first_rank ? 1 : 0);    // must be equal prev. field to have learn button in enabled state
-    data << uint8(skillReqLevel ? skillReqLevel : tSpell->reqLevel);
+    data << uint8(std::max(skillReqLevel, tSpell->reqLevel));
    data << uint32(tSpell->reqSkill);
    data << uint32(tSpell->reqSkillValue);
    data << uint32(!tSpell->IsCastable() && chain_node ? (chain_node->prev ? chain_node->prev : chain_node->req) : 0);

Seems to be an improvement for druid trainers. Not yet checked for other cases.

[dufernst]

Seems to work fine with this, but only checked it for druid trainers.

[angeleyes]

does it mean that

Can you please give spell-ids of spells that are taught on wrong level, and which requirements they should have, and how they should be obtained (for proper testing)

is not needed anymore?

[VladimirMangos]

diff --git a/src/game/NPCHandler.cpp b/src/game/NPCHandler.cpp
index db7b035..d2b9a0c 100644
--- a/src/game/NPCHandler.cpp
+++ b/src/game/NPCHandler.cpp
@@ -131,7 +131,7 @@ static void SendTrainerSpellHelper(WorldPacket& data, TrainerSpell const* tSpell
    data << uint32(primary_prof_first_rank && can_learn_primary_prof ? 1 : 0);
    // primary prof. learn confirmation dialog
    data << uint32(primary_prof_first_rank ? 1 : 0);    // must be equal prev. field to have learn button in enabled state
-    data << uint8(skillReqLevel ? skillReqLevel : tSpell->reqLevel);
+    data << uint8(std::max(skillReqLevel, tSpell->reqLevel));
    data << uint32(tSpell->reqSkill);
    data << uint32(tSpell->reqSkillValue);
    data << uint32(!tSpell->IsCastable() && chain_node ? (chain_node->prev ? chain_node->prev : chain_node->req) : 0);

Seems to be an improvement for druid trainers. Not yet checked for other cases.

What you will do if need overwrite wrong high level req in dbc?

[Cupcake]

Just wanted to mention that this bug is not present in One, maybe it will be easier to pinpoint the problem.

[Jethrogibbs]

the fix is not good druids walk but now the priests who can not learn anything

[dufernst]

With the current implementation

-    data << uint8(skillReqLevel ? skillReqLevel : tSpell->reqLevel); 
+   data << uint8(tSpell->reqLevel);

would work best.

Because even when a skillReqLevel is provided, learning the spell would fail on

   // check level requirement 
   if (!prof || GetSession()->GetSecurity() < AccountTypes(sWorld.getConfig(CONFIG_UINT32_TRADE_SKILL_GMIGNORE_LEVEL))) 
       if (getLevel() < trainer_spell->reqLevel) 
           return TRAINER_SPELL_RED;

That's why the druid spells only show up green when another spell is learned (client side list update based on the required level?).

And it's the reason that it's not possible to learn those druid spells regardless of having those spells set to a lower required level in the packet.

[Schmoozerd]

I just tested my recent patch version:

http://paste2.org/p/1811385

and I didn't notice problems on priests, warlocks, druids

[Jethrogibbs]

Sorry I was wrong master class I retest immediately after the fix of schmoorzed.

[Jethrogibbs]

I'll wait for the commit schmoozerd for testing (11857) Big Thanks Schmoozerd

[Schmoozerd]

Must be fixed in [11857].

If further problems remain, I would suggest to refer to database providers