[FIXED] Player Owned Pets Attack Owner/Player

[Auntie Mangos]

Mangos Version: 11927

Custom Patches: https://github.com/antiroot/mangos/commit/bffe7293eb44ca9471f04a80442561f9c0aea13e

SD2 Version: 2447

Database Name and Version : UDB 403

How it SHOULD work:

Player owned pets shouldn't attack owner/player

How it DOES work:

Player owned pets DO attack owner/player after owner has taken environment/self damage, however they seem to only do a single attack at most

I did a quick search and didn't see a similar bug, but sorry if i'm double posting this

I do not know when this started happening, but whenever Warlock player takes environment or self inflicted damage (ie falling or fire) the warlocks pet will attempt to attack for a brief second. So far I've only tested this with warlock and imp, but I assume it affects any pet.

How to repeat: go to Ironforge, summon imp (enable imp's fireball autocast), run near a brazier/fire close enough that it does the expected fire trap damage.

Imp will target the player, Imp will cast fireball at player, after the fireball hits/misses the player the Imp leaves combat and continues following as expected

With the option for displaying combat text on screen is enabled, as soon as the fireball hits/misses the player the text "Entering Combat" and "Leaving Combat" flash on screen with almost no delay between the two messages.

There was a bug reported for mangos one http://getmangos.eu/community/post/140851/#p140851, i have not tested Health Funnel yet, but i assume it's the same/similar bug with the master branch.

The main difference I see between my bug and the one I linked to seems to be in my case the pet does stop attacking after it realizes it just attacked it's owner

[Schmoozerd]

probably caused by https://github.com/mangos/mangos/commit/de5521c24b000f4546aae6939f0babd0a6c50035

I think this should be good idea to just add a check of "enemy != owner" for such cases.

[fr1nge]

DaC's patch works fine on One, don't know if it's the same code on master, should give it a try, solves any issue related to pets attacking owner.

https://gist.github.com/1694390

[faramir118]

What about this at beginning of Unit::AttackedBy:

if (attacker == this) return;

[antiroot]

That makes sense for the Health Funnel bug since the player is the caster doing the "damage" but what about from things like fall damage or fire traps, I haven't checked but I assume the player is not the "caster" in those cases, but please correct me if i'm wrong

[fr1nge]

I noticed the bug related to "fall damage" and pets is not present on One, so i guess there's something different on master related to how pets AI is handled. Just started digging the code on mangos so i'm not familiar with the differences, maybe someone knows better and enlighten us.

[antiroot]

thanks fr1nge,

I only noticed the fall damage bug once, may have been a fluke and I might have actually fallen near a campfire (fire trap).. i'll test the fall damage a bit more tonight to see if it happens every time

But this bug does occur 100% of the time when you walk near a fire/environment trap

[Schmoozerd]

Fixed in 11930.

Sorry for not giving further credit, I didn't look for suggested patches