[FIX/PATCH][7664] Overkill

[Wowka321]

Ok, this is implementation SQl-DBC from QAston http://paste2.org/p/786697

And sql part for fixing overkill http://paste2.org/p/786706

[KAPATEJIb]

talent still bugged

i think SQL-DBC is best way to fix non-existed spells...

[tehmarto]

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index e71b630..b0d9908 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -4022,11 +4080,11 @@ void Aura::HandleModStealth(bool apply, bool Real)
                        m_target->CastCustomSpell(m_target,31665,&bp,NULL,NULL,true);
                    }
                    // Overkill
                    else if ((*i)->GetId() == 58426 && GetSpellProto()->SpellFamilyFlags & UI64LIT(0x0000000000400000))
                    {
-                        m_target->RemoveAurasDueToSpell(58428);
+                        (*i)->m_isPeriodic = false;
                        m_target->CastSpell(m_target, 58427, true);
                    }
                }
            }
        }
@@ -4061,11 +4119,14 @@ void Aura::HandleModStealth(bool apply, bool Real)
                // Master of Subtlety
                if ((*i)->GetSpellProto()->SpellIconID == 2114)
                    m_target->CastSpell(m_target, 31666, true);
                // Overkill
                else if ((*i)->GetId() == 58426 && GetSpellProto()->SpellFamilyFlags & UI64LIT(0x0000000000400000))
-                    m_target->CastSpell(m_target, 58428, true);
+                {
+                    (*i)->m_periodicTimer = 20000;
+                    (*i)->m_isPeriodic = true;
+                }
            }
        }
    }
}

@@ -7848,10 +8013,14 @@ void Aura::PeriodicDummyTick()
                        case 0: m_target->CastSpell(m_target, 55731, true); break;
                        case 1: m_target->CastSpell(m_target, 55738, true); break;
                        case 2: m_target->CastSpell(m_target, 55739, true); break;
                    }
                    return;
+                    case 58426:
+                        m_target->RemoveAurasDueToSpell(58427);
+                        m_isPeriodic = false;
+                        return;
// Exist more after, need add later
                default:
                    break;
            }
            // Prey on the Weak

Best way I can think of, but still i think it's hacky. Btw it not proc from vanish I think due to GetSpellProto()->SpellFamilyFlags & UI64LIT(0x0000000000400000) , Is this needed and should it proc from vanish?

[VladimirMangos]

I close thread: accepted section not for discussion spell _working_ but broken after next client switch. Threads in accepted open only for discussion _patch_ problem after it adding.