tehavatar

Hi XTZGZoReX, this looks quite impressive. I dont have time to test this patch, so do you mind answering some questions?:

Does this patch have any performance advantage over the current MapMgr ?

How much of advantage will it be to be able to completely cache map data ?

Does your system compliment the MMAPS project?

Thanks again, I will make time to test your developments soon!

Sorry, looks like its my code screw ups

Characters dont save in 9635.

Sorry for the link, I was not aware of that rule. I do not spend my time trolling forums and I'll be honest, I never read the rules.

Thanks for clearing that up Hunuza.

Forusim this freeze does not conclusively ALWAYS happen, but on a high pop server this happens every ~2 secs, and when it does happen, the whole set gets the freeze.... (usually like 20 players at a time)

This problem is still confirmed in the latest build.

I have been using the fix released on this thread and it has helped a great deal!

wtf is that pascal/delphi ??

Oh yes, please dont tell me this patch does not follow mangos coding guidelines. I used exactly the same method types, naming schemes and usage as ive found in the code.

Aparently Mangos devs dont like my implementation of character_talent. I dont understand why this is an issue. talents != spells and because seperate DBC values are used for storing talents, i see no reason why an addition to character_spell must be made.

Hi there,

Me and Skilly created a duel specialization patch for our server.

The code made its way to the forum - why was no author info included?

If you are using my script, atleast include the author info before using it.

Regards,

Yup, got a few reports of people with instances that didnt reset even 4 days after reset.

PS. Why dont any of you devs use try/catch blocks in the code? Ive got some crashes that I dont know how to fix, simply added a try/catch block with RETURN 0 as the catch and ive got 1week+ uptime with 200 online. I know this is bad practice, but i mean... while you are debugging, uptime is a big issue.

Instances arent resetting at all, you have to restart server for them to reset.

Should maybe just add check to see if GetPlayer()->isTaxi

naab.... =|

Sigh, a quick google search reveals not only a SVN repo but also a community site with lots of information, including a link to that SVN repo. Ill throw you a bone

http://starcrack.googlecode.com/svn/trunk

?? Why dont you check out one of (many) BNET2 projects. One of them is open source and they have the login sequence working perfectly =|

Hi guys, this was output from our core. It lagged during the stack trace, but not error occured.

Player::UpdateAllStats() d:\\development\\server_source\\mangos\\src\\game\\statsystem
.cpp: 116 + 0x0
Player::UpdateResistances() d:\\development\\server_source\\mangos\\src\\game\\statsys
tem.cpp: 148 + 0x0
Player::UpdateArmor() d:\\development\\server_source\\mangos\\src\\game\\statsystem.cp
p: 163 + 0x0
Player::UpdateMaxHealth() d:\\development\\server_source\\mangos\\src\\game\\statsyste
m.cpp: 213 + 0x0
Player::UpdateMaxPower() d:\\development\\server_source\\mangos\\src\\game\\statsystem
.cpp: 225 + 0x0
Player::UpdateAttackPowerAndDamage() d:\\development\\server_source\\mangos\\src\\gam
e\\statsystem.cpp: 248 + 0x0
Player::UpdateDamagePhysical() d:\\development\\server_source\\mangos\\src\\game\\stat
system.cpp: 450 + 0x0
Player::IsVisibleInGridForPlayer() d:\\development\\server_source\\mangos\\src\\game\\
player.cpp: 18742 + 0x0
Unit::IsImmunedToSpell() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp:
9750 + 0x0
Player::IsImmunedToSpellEffect() d:\\development\\server_source\\mangos\\src\\game\\pl
ayer.cpp: 21790 + 0x0
Unit::GetMeleeDamageSchoolMask() d:\\development\\server_source\\mangos\\src\\game\\un
it.cpp: 12520 + 0x0
[0x3fc00000]
[0x8bfc4d89]
d:\\development\\server_source\\mangos\\src\\game\\Object.h:466: Error: Assertion in W
orldObject::GetMap failed: m_currMap
Stack Trace:
[0xe84cc100]
[0xf1040019]
Player::AddToWorld() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 19
10 + 0x0
Player::RemoveFromWorld() d:\\development\\server_source\\mangos\\src\\game\\player.cp
p: 1924 + 0x0
Player::BuildCreateUpdateBlockForPlayer() d:\\development\\server_source\\mangos\\sr
c\\game\\player.cpp: 3839 + 0x0
WorldObject::AddToClientUpdateList() d:\\development\\server_source\\mangos\\src\\gam
e\\object.cpp: 1920 + 0x0
WorldObject::RemoveFromClientUpdateList() d:\\development\\server_source\\mangos\\sr
c\\game\\object.cpp: 1925 + 0x0
WorldObject::BuildUpdateData() d:\\development\\server_source\\mangos\\src\\game\\obje
ct.cpp: 1945 + 0x0
Player::DestroyForPlayer() d:\\development\\server_source\\mangos\\src\\game\\player.c
pp: 3870 + 0x0
Object::hasQuest() d:\\development\\server_source\\mangos\\src\\game\\object.h: 277 +
0x0
Object::hasInvolvedQuest() d:\\development\\server_source\\mangos\\src\\game\\object.h
: 278 + 0x0
Player::_SetUpdateBits() d:\\development\\server_source\\mangos\\src\\game\\player.cpp
: 3737 + 0x0
Player::_SetCreateBits() d:\\development\\server_source\\mangos\\src\\game\\player.cpp
: 3721 + 0x0
Player::Update() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 1093 +
0x0
Unit::SetPhaseMask() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 1338
0 + 0x0
WorldObject::GetNameForLocaleIdx() d:\\development\\server_source\\mangos\\src\\game\\
object.h: 388 + 0x0
Player::CleanupsBeforeDelete() d:\\development\\server_source\\mangos\\src\\game\\play
er.cpp: 544 + 0x0
Player::SendMessageToSet() d:\\development\\server_source\\mangos\\src\\game\\player.c
pp: 5825 + 0x0
Player::SendMessageToSetInRange() d:\\development\\server_source\\mangos\\src\\game\\p
layer.cpp: 5840 + 0x0
Unit::IsHostileTo() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 8073
+ 0x0
Unit::IsFriendlyTo() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 8185
+ 0x0
WorldObject::SaveRespawnTime() d:\\development\\server_source\\mangos\\src\\game\\obje
ct.h: 454 + 0x0
Unit::isVisibleForInState() d:\\development\\server_source\\mangos\\src\\game\\unit.cp
p: 11443 + 0x0
Unit::getLevelForTarget() d:\\development\\server_source\\mangos\\src\\game\\unit.h: 1
155 + 0x0
Player::SetSheath() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 828
2 + 0x0
Player::GetShieldBlockValue() d:\\development\\server_source\\mangos\\src\\game\\playe
r.cpp: 4803 + 0x0
Player::HasSpell() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 3901
+ 0x0
Player::IsInWater() d:\\development\\server_source\\mangos\\src\\game\\player.h: 1043
+ 0x0
Player::IsUnderWater() d:\\development\\server_source\\mangos\\src\\game\\player.cpp:
2218 + 0x0
Unit::MoveOutOfRange() d:\\development\\server_source\\mangos\\src\\game\\unit.h: 1390
+ 0x0
Player::setDeathState() d:\\development\\server_source\\mangos\\src\\game\\player.cpp:
1391 + 0x0
Player::ProhibitSpellSchool() d:\\development\\server_source\\mangos\\src\\game\\playe
r.cpp: 17937 + 0x0
Player::UpdateStats() d:\\development\\server_source\\mangos\\src\\game\\statsystem.cp
p: 33 + 0x0
Player::UpdateAllStats() d:\\development\\server_source\\mangos\\src\\game\\statsystem
.cpp: 116 + 0x0
Player::UpdateResistances() d:\\development\\server_source\\mangos\\src\\game\\statsys
tem.cpp: 148 + 0x0
Player::UpdateArmor() d:\\development\\server_source\\mangos\\src\\game\\statsystem.cp
p: 163 + 0x0
Player::UpdateMaxHealth() d:\\development\\server_source\\mangos\\src\\game\\statsyste
m.cpp: 213 + 0x0
Player::UpdateMaxPower() d:\\development\\server_source\\mangos\\src\\game\\statsystem
.cpp: 225 + 0x0
Player::UpdateAttackPowerAndDamage() d:\\development\\server_source\\mangos\\src\\gam
e\\statsystem.cpp: 248 + 0x0
Player::UpdateDamagePhysical() d:\\development\\server_source\\mangos\\src\\game\\stat
system.cpp: 450 + 0x0
Player::IsVisibleInGridForPlayer() d:\\development\\server_source\\mangos\\src\\game\\
player.cpp: 18742 + 0x0
Unit::IsImmunedToSpell() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp:
9750 + 0x0
Player::IsImmunedToSpellEffect() d:\\development\\server_source\\mangos\\src\\game\\pl
ayer.cpp: 21790 + 0x0
Unit::GetMeleeDamageSchoolMask() d:\\development\\server_source\\mangos\\src\\game\\un
it.cpp: 12520 + 0x0
[0x3fc00000]
[0x8bfc4d89]
d:\\development\\server_source\\mangos\\src\\game\\Object.h:466: Error: Assertion in W
orldObject::GetMap failed: m_currMap
Stack Trace:
[0xe84cc100]
[0xf1040019]
Player::AddToWorld() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 19
10 + 0x0
Player::RemoveFromWorld() d:\\development\\server_source\\mangos\\src\\game\\player.cp
p: 1924 + 0x0
Player::BuildCreateUpdateBlockForPlayer() d:\\development\\server_source\\mangos\\sr
c\\game\\player.cpp: 3839 + 0x0
WorldObject::AddToClientUpdateList() d:\\development\\server_source\\mangos\\src\\gam
e\\object.cpp: 1920 + 0x0
WorldObject::RemoveFromClientUpdateList() d:\\development\\server_source\\mangos\\sr
c\\game\\object.cpp: 1925 + 0x0
WorldObject::BuildUpdateData() d:\\development\\server_source\\mangos\\src\\game\\obje
ct.cpp: 1945 + 0x0
Player::DestroyForPlayer() d:\\development\\server_source\\mangos\\src\\game\\player.c
pp: 3870 + 0x0
Object::hasQuest() d:\\development\\server_source\\mangos\\src\\game\\object.h: 277 +
0x0
Object::hasInvolvedQuest() d:\\development\\server_source\\mangos\\src\\game\\object.h
: 278 + 0x0
Player::_SetUpdateBits() d:\\development\\server_source\\mangos\\src\\game\\player.cpp
: 3737 + 0x0
Player::_SetCreateBits() d:\\development\\server_source\\mangos\\src\\game\\player.cpp
: 3721 + 0x0
Player::Update() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 1093 +
0x0
Unit::SetPhaseMask() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 1338
0 + 0x0
WorldObject::GetNameForLocaleIdx() d:\\development\\server_source\\mangos\\src\\game\\
object.h: 388 + 0x0
Player::CleanupsBeforeDelete() d:\\development\\server_source\\mangos\\src\\game\\play
er.cpp: 544 + 0x0
Player::SendMessageToSet() d:\\development\\server_source\\mangos\\src\\game\\player.c
pp: 5825 + 0x0
Player::SendMessageToSetInRange() d:\\development\\server_source\\mangos\\src\\game\\p
layer.cpp: 5840 + 0x0
Unit::IsHostileTo() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 8073
+ 0x0
Unit::IsFriendlyTo() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 8185
+ 0x0
WorldObject::SaveRespawnTime() d:\\development\\server_source\\mangos\\src\\game\\obje
ct.h: 454 + 0x0
Unit::isVisibleForInState() d:\\development\\server_source\\mangos\\src\\game\\unit.cp
p: 11443 + 0x0
Unit::getLevelForTarget() d:\\development\\server_source\\mangos\\src\\game\\unit.h: 1
155 + 0x0
Player::SetSheath() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 828
2 + 0x0
Player::GetShieldBlockValue() d:\\development\\server_source\\mangos\\src\\game\\playe
r.cpp: 4803 + 0x0
Player::HasSpell() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 3901
+ 0x0
Player::IsInWater() d:\\development\\server_source\\mangos\\src\\game\\player.h: 1043
+ 0x0
Player::IsUnderWater() d:\\development\\server_source\\mangos\\src\\game\\player.cpp:
2218 + 0x0
Unit::MoveOutOfRange() d:\\development\\server_source\\mangos\\src\\game\\unit.h: 1390
+ 0x0
Player::setDeathState() d:\\development\\server_source\\mangos\\src\\game\\player.cpp:
1391 + 0x0
Player::ProhibitSpellSchool() d:\\development\\server_source\\mangos\\src\\game\\playe
r.cpp: 17937 + 0x0
Player::UpdateStats() d:\\development\\server_source\\mangos\\src\\game\\statsystem.cp
p: 33 + 0x0
Player::UpdateAllStats() d:\\development\\server_source\\mangos\\src\\game\\statsystem
.cpp: 116 + 0x0
Player::UpdateResistances() d:\\development\\server_source\\mangos\\src\\game\\statsys
tem.cpp: 148 + 0x0
Player::UpdateArmor() d:\\development\\server_source\\mangos\\src\\game\\statsystem.cp
p: 163 + 0x0
Player::UpdateMaxHealth() d:\\development\\server_source\\mangos\\src\\game\\statsyste
m.cpp: 213 + 0x0
Player::UpdateMaxPower() d:\\development\\server_source\\mangos\\src\\game\\statsystem
.cpp: 225 + 0x0
Player::UpdateAttackPowerAndDamage() d:\\development\\server_source\\mangos\\src\\gam
e\\statsystem.cpp: 248 + 0x0
Player::UpdateDamagePhysical() d:\\development\\server_source\\mangos\\src\\game\\stat
system.cpp: 450 + 0x0
Player::IsVisibleInGridForPlayer() d:\\development\\server_source\\mangos\\src\\game\\
player.cpp: 18742 + 0x0
Unit::IsImmunedToSpell() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp:
9750 + 0x0
Player::IsImmunedToSpellEffect() d:\\development\\server_source\\mangos\\src\\game\\pl
ayer.cpp: 21790 + 0x0
Unit::GetMeleeDamageSchoolMask() d:\\development\\server_source\\mangos\\src\\game\\un
it.cpp: 12520 + 0x0
[0x3fc00000]
[0x8bfc4d89]
d:\\development\\server_source\\mangos\\src\\game\\Object.h:466: Error: Assertion in W
orldObject::GetMap failed: m_currMap
Stack Trace:
[0xe84cc100]
[0xf1040019]
Player::AddToWorld() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 19
10 + 0x0
Player::RemoveFromWorld() d:\\development\\server_source\\mangos\\src\\game\\player.cp
p: 1924 + 0x0
Player::BuildCreateUpdateBlockForPlayer() d:\\development\\server_source\\mangos\\sr
c\\game\\player.cpp: 3839 + 0x0
WorldObject::AddToClientUpdateList() d:\\development\\server_source\\mangos\\src\\gam
e\\object.cpp: 1920 + 0x0
WorldObject::RemoveFromClientUpdateList() d:\\development\\server_source\\mangos\\sr
c\\game\\object.cpp: 1925 + 0x0
WorldObject::BuildUpdateData() d:\\development\\server_source\\mangos\\src\\game\\obje
ct.cpp: 1945 + 0x0
Player::DestroyForPlayer() d:\\development\\server_source\\mangos\\src\\game\\player.c
pp: 3870 + 0x0
Object::hasQuest() d:\\development\\server_source\\mangos\\src\\game\\object.h: 277 +
0x0
Object::hasInvolvedQuest() d:\\development\\server_source\\mangos\\src\\game\\object.h
: 278 + 0x0
Player::_SetUpdateBits() d:\\development\\server_source\\mangos\\src\\game\\player.cpp
: 3737 + 0x0
Player::_SetCreateBits() d:\\development\\server_source\\mangos\\src\\game\\player.cpp
: 3721 + 0x0
Player::Update() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 1093 +
0x0
Unit::SetPhaseMask() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 1338
0 + 0x0
WorldObject::GetNameForLocaleIdx() d:\\development\\server_source\\mangos\\src\\game\\
object.h: 388 + 0x0
Player::CleanupsBeforeDelete() d:\\development\\server_source\\mangos\\src\\game\\play
er.cpp: 544 + 0x0
Player::SendMessageToSet() d:\\development\\server_source\\mangos\\src\\game\\player.c
pp: 5825 + 0x0
Player::SendMessageToSetInRange() d:\\development\\server_source\\mangos\\src\\game\\p
layer.cpp: 5840 + 0x0
Unit::IsHostileTo() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 8073
+ 0x0
Unit::IsFriendlyTo() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp: 8185
+ 0x0
WorldObject::SaveRespawnTime() d:\\development\\server_source\\mangos\\src\\game\\obje
ct.h: 454 + 0x0
Unit::isVisibleForInState() d:\\development\\server_source\\mangos\\src\\game\\unit.cp
p: 11443 + 0x0
Unit::getLevelForTarget() d:\\development\\server_source\\mangos\\src\\game\\unit.h: 1
155 + 0x0
Player::SetSheath() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 828
2 + 0x0
Player::GetShieldBlockValue() d:\\development\\server_source\\mangos\\src\\game\\playe
r.cpp: 4803 + 0x0
Player::HasSpell() d:\\development\\server_source\\mangos\\src\\game\\player.cpp: 3901
+ 0x0
Player::IsInWater() d:\\development\\server_source\\mangos\\src\\game\\player.h: 1043
+ 0x0
Player::IsUnderWater() d:\\development\\server_source\\mangos\\src\\game\\player.cpp:
2218 + 0x0
Unit::MoveOutOfRange() d:\\development\\server_source\\mangos\\src\\game\\unit.h: 1390
+ 0x0
Player::setDeathState() d:\\development\\server_source\\mangos\\src\\game\\player.cpp:
1391 + 0x0
Player::ProhibitSpellSchool() d:\\development\\server_source\\mangos\\src\\game\\playe
r.cpp: 17937 + 0x0
Player::UpdateStats() d:\\development\\server_source\\mangos\\src\\game\\statsystem.cp
p: 33 + 0x0
Player::UpdateAllStats() d:\\development\\server_source\\mangos\\src\\game\\statsystem
.cpp: 116 + 0x0
Player::UpdateResistances() d:\\development\\server_source\\mangos\\src\\game\\statsys
tem.cpp: 148 + 0x0
Player::UpdateArmor() d:\\development\\server_source\\mangos\\src\\game\\statsystem.cp
p: 163 + 0x0
Player::UpdateMaxHealth() d:\\development\\server_source\\mangos\\src\\game\\statsyste
m.cpp: 213 + 0x0
Player::UpdateMaxPower() d:\\development\\server_source\\mangos\\src\\game\\statsystem
.cpp: 225 + 0x0
Player::UpdateAttackPowerAndDamage() d:\\development\\server_source\\mangos\\src\\gam
e\\statsystem.cpp: 248 + 0x0
Player::UpdateDamagePhysical() d:\\development\\server_source\\mangos\\src\\game\\stat
system.cpp: 450 + 0x0
Player::IsVisibleInGridForPlayer() d:\\development\\server_source\\mangos\\src\\game\\
player.cpp: 18742 + 0x0
Unit::IsImmunedToSpell() d:\\development\\server_source\\mangos\\src\\game\\unit.cpp:
9750 + 0x0
Player::IsImmunedToSpellEffect() d:\\development\\server_source\\mangos\\src\\game\\pl
ayer.cpp: 21790 + 0x0
Unit::GetMeleeDamageSchoolMask() d:\\development\\server_source\\mangos\\src\\game\\un
it.cpp: 12520 + 0x0
[0x3fc00000]
[0x8bfc4d89]
SESSION: received not allowed opcode CMSG_LFD_PLAYER_LOCK_INFO_REQUEST (0x036E)
SESSION: received not allowed opcode CMSG_LFD_PLAYER_LOCK_INFO_REQUEST (0x036E)

Cant figure that out either... hmmm... it seems that the two patches XTZGZoReX listed seems to lower raiding/creep killing related freezes to a minimum BUT in pvp it seems just the same.. or slightly reduced. Who zone froze with the patches listed while pvp was going on. Sometimes there is also a freeze when character is killed, or just before character is killed that was not there before, when this happens.. long freeze for the character being killed but the killer seems fine.

Just check the mangos+vmaps git repo, there should be some source examples you can look at.

Compiled** -> After two hours, ive had a single report about this freeze. Means that the patches either fixed or dramatically reduced the freezes.

Copiled with above patches.. now i monitor tickets

Yup, this is a confirmed problem =] ~400 testers