tibbi

depends what rbg he has maybe he has it done some other way. But ye, ofc i meant this version too

rbg still isnt supported by official mangos, so i cant give a link to that. But go to BattlegroundMgr.cpp, and search for "battleground_sa", guess you will figure.

tested it, works fine at the recast demo. Also connected the opposite sides of BeM arena ropes, then start and end were connected correctly. I still dont see, how can i fix it ingame tho

Im still having problems with the BeM arena ropes Pets wont go through it. What exactly i have to do? Create a new folder meshes, offmesh.txt with the text you wrote, and just run that command ? (changed to MoveMapGen.exe, but it doesnt matter now). Some new files have been generated, what should i do with them ?

try compiling detour first, in win32_debug mode

I dont think it has side-effects, since npcs really shouldnt crit.

as i see, official mangos is missing a check at https://github.com/mangos/mangos/blob/master/src/game/Unit.cpp#L6683 It should have if (GetObjectGuid().IsCreature()) return;

.unlearn works well, just tested. Its handled at https://github.com/mangos/mangos/blob/master/src/game/Level3.cpp#L1565 , but i dont see anything special there

Im also not good at making proper solutions But Ive tested it, and works fine. Maybe the version of SeTM is better? https://gist.github.com/1644595

What bug does the patch fix? What features does the patch add? There is a very old problem with talent reseting, pretty major one. Ill explain it on Blood Gorged, deep blood DK talent, spell id 61158 (not on wowhead). It has 2 spells filled in dbc, EffectTriggeredSpell0 and 2, which are also passive auras, increasing the DKs damage by 10% when he is above 75% hp. Now the problem comes, if the DK resets his talents, or its enough to switch a spec. Even tho 61158 is removed from him, those 2 triggered auras stay on him, and he still has that 10% dmg bonus. So this bug affects talents with something at EffectTriggeredSpell. Adding the part of code that should be stick to normal talent reseting, spec switch, and also for reseting pets talents, even tho I honestly havent been searching for pet talents, that might be broke the same way. But Im pretty sure there are some. For which repository revision was the patch created? It was most likely always broken, and theres nothing special involved in the patch, so proly any revision. Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. I dont know about any thread about this. Who has been writing this patch? Please include either forum user names or email addresses. by me diff --git a/src/game/Player.cpp b/src/game/Player.cpp index d3ab26a..2c16667 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -23661,8 +23661,15 @@ void Player::ActivateSpec(uint8 specNum) for(int r = 0; r < MAX_TALENT_RANK; ++r) if (talentInfo->RankID[r]) + { removeSpell(talentInfo->RankID[r],!IsPassiveSpell(talentInfo->RankID[r]),false); + SpellEntry const *spellInfo = sSpellStore.LookupEntry(talentInfo->RankID[r]); + for (int k = 0; k < MAX_EFFECT_INDEX; ++k) + if (spellInfo->EffectTriggerSpell[k]) + removeSpell(spellInfo->EffectTriggerSpell[k]); + } + specIter = m_talents[m_activeSpec].begin(); } else diff --git a/src/game/Player.cpp b/src/game/Player.cpp index 5fe16fd..d3ab26a 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -3853,8 +3853,15 @@ bool Player::resetTalents(bool no_cost, bool all_specs) for (int j = 0; j < MAX_TALENT_RANK; ++j) if (talentInfo->RankID[j]) + { removeSpell(talentInfo->RankID[j],!IsPassiveSpell(talentInfo->RankID[j]),false); + SpellEntry const *spellInfo = sSpellStore.LookupEntry(talentInfo->RankID[j]); + for (int k = 0; k < MAX_EFFECT_INDEX; ++k) + if (spellInfo->EffectTriggerSpell[k]) + removeSpell(spellInfo->EffectTriggerSpell[k]); + } + iter = m_talents[m_activeSpec].begin(); } diff --git a/src/game/Pet.cpp b/src/game/Pet.cpp index 0470378..0307cf6 100644 --- a/src/game/Pet.cpp +++ b/src/game/Pet.cpp @@ -1831,7 +1831,14 @@ bool Pet::resetTalents() for (int j = 0; j < MAX_TALENT_RANK; j++) if (talentInfo->RankID[j]) + { removeSpell(talentInfo->RankID[j],!IsPassiveSpell(talentInfo->RankID[j]),false); + + SpellEntry const *spellInfo = sSpellStore.LookupEntry(talentInfo->RankID[j]); + for (int k = 0; k < MAX_EFFECT_INDEX; ++k) + if (spellInfo->EffectTriggerSpell[k]) + removeSpell(spellInfo->EffectTriggerSpell[k], false); + } } UpdateFreeTalentPoints(false);

make sure you have ScriptDev2 in src/bindings

you can test https://github.com/gc/mangos/commit/d13a4dbb237383563d98156055dceb663d46ba5b , that part with implementing GetRandomContactPoint, and using it instead of GetContactPoint. With frand(-0.7f, 0.7f) you can modify the arc in which npcs are in front of the tank. its not really perfect, since combat reach and the actual amount of attacking npcs should be included in the formula too. Better than nothing tho That bounding_radius and combat_reach change is about sth else, and needs db support too.

well ye, whatever. What I wanted to say is, that that branch isnt being updated for some time now.

here is the link to icc_project started by Schmoozerd, thats supposed to teach it https://github.com/scriptdev2/scriptdev2/commits/icc_project . Its just the very first parts tho, guess he stopped with it cause lack of people following it.

right that I want to slow down putting stuff... I already have it set to 1 item per 20 secs, and its damn much.