TOM_RUS

You can't be 100% sure about field types. That's why predefined types is a best approach. The DBC file format designed that way and you can't do anything about that...

Actually, packet structure should be like this: SMSG_LIST_INVENTORY uint64 guid; uint8 count; if(count) { for(i = 0; i < count; ++i) { uint32 slot; uint32 entry; uint32 displayId; uint32 itemsCount; uint32 price; uint32 maxDurability; uint32 buyCount; uint32 extendedCostId; } } else { uint8 error; // errors: // 0 - "Vendor has no inventory" // 1 - "I don't think he likes you very much" // 2 - "You are too far away" // 3 - "Vendor is dead" // 4 - "You can't shop while dead." } That explains why you need additional byte if vendor has no items.

Yeah, with masks code will be a lot shorter and cleaner.

If it doesn't work, it not necessary doesn't work because of this patch. Other patches may be not compatible, incorrect, etc...

No one cares about your fork here. As for a change, it looks correct. May be there's even more places where MovementInfo::Write can be used...

Learn it, it's not that hard really.

No. You don't get my point.

You have to preserve mpq loading order. In this particular case file must be skipped as it no longer used (file size=0 in last patch file patch-3.mpq).

Learn to use google. x86 http://www.microsoft.com/downloads/details.aspx?FamilyID=a7b7a05e-6de6-4d3a-a423-37bf0912db84&displaylang=en x64 http://www.microsoft.com/downloads/details.aspx?familyid=BD512D9E-43C8-4655-81BF-9350143D5867&displaylang=en

May be that file isn't used anymore? They do such things for unused files... Does it 0 size in patch*.mpq only or in all other mpq's as well?

WPE pro can be easily detected with warden (since it uses dll injection), but warden isn't supported because of some reasons...

That file can be bugged or have different version, because it's not finished zone for patch 3.3.5.

It's DB bug. Values can't be 0.

Is it so hard to set proper min/max players per team in database?

Read patch notes.

There's most of opcodes used in voice chat, excluding voice chat server opcodes ofc...

It's my code copy/paste. How can it be useful?

Change second line. data.put( sizeof(uint32), clientcount ); // insert right count

I fixed this in 330 branch.

You can do that easily by changing: data.put( 4, clientcount ); // insert right count to data.put( 4, m.size() ); // insert right count in MiscHandler.cpp

Client expects additional byte at the end.

Why you removed uint8 at the end of packet?

Why do you duplicate fields like: + uint64 m_transportGUID; + float m_transportPosition[4]; it's already exists. class MovementInfo { ... // transport uint64 t_guid; Position t_pos; uint32 t_time; int8 t_seat; uint32 t_time2; ... }

Have you tried with latest rev?

Should be fixed.