Wowka321

small bag. When u drive far from spawnplace (or may be long time on vehicle) to another zone - all around u got crash client

Thx, rastikzzz!

patch work good. Thx!

Whithout patch i got crashs every half hour whith HandleBuyItemInSlotOpcode on my fun-realm (a lot of vendors). Now more-more stable. Thx.

Cuz .ru again down posting here:

with last changes (unload grid) work fine =)

For Ambal

damn. In your last solutions for quest with teleport work fine. I's was my mistake. But now next problem ...

http://ftp.filekeeper.org/download/shared/5.ZIP

Rastikzzz! We are trust in you! You can do it. Thx for your work!

P.S. Any examples player's mounts ?

and what about the server uptime from the worldd? did it hold the load? (i mean memory leaks and that damn stuff )

Uptime on lasts revisions 18-36 hours. No memory leaks. (3-4 Gb used, vmaps enabe in raids, arenas) But sometime spelllags (0.1-0.5 sec) when more than 1k online =\\

That's bad. The load should balance evenly on all cores. How many threads did you set for mtmaps?

MapUpdate.Threads = 4

compile whith -fopenmp

gcc 4.3.2

May be i do something wrong?

The point of it is to use more CPU Thanks for testing, but could you give me some numbers? CPU load without and with this patch - or maybe if you have it in mangos, update time diff.

on 8 CPU (Xeon5410) 80% main and about 10%% other cores, 1k online

Yes. can u provide full patch whit your patch + derex. If it possible and can work together.

i tryed, but it's crash.Any of this patch working fine if standalone =/

added: ah, it's alternative...

Sorry

I've written a small patch for TC that provides similiar features as mtmaps by Derex. It works by splitting workload of MapManager::Update() loop across several threads. It's been tested on TC with good results (60ms update time with 600 players at peak) and id like to share (and test ) this patch with MaNGOS community. Differences are so few that it will be easy to merge. For it to compile you need:

linux

gcc 4.X (for openmp support)

add -fomp to compile flags

link mangos-worldd with gomp library

since TC uses cmakes i cannot provide automake patch to allow it to build, but i know youll be able to do it with no problem - if you will have trouble with it though, i can do it too. Diff is at:

http://bitbucket.org/raczman/trinitycore-patches/src/tip/mtmaps2

Thx u in anyway.

This patch addon for mtmaps by derex, or standalone?

Someone tested it on mangos?

When i testing whith my GM-char this aura is not applied. But if u normal character aura applied.But it was in 2.4.3

May be it is some problem.

Crashes in last revisions

Program terminated with signal 11, Segmentation fault.
[New process 23673]
[New process 23675]
[New process 23658]
[New process 23659]
[New process 23676]
[New process 23674]
[New process 23677]
[New process 23660]
[New process 23656]
#0  0x0000000000906032 in Aura::HandleModStealth (this=0x7fa5a70c6180, apply=true, Real=true) at ../../../src/game/SpellAuras.cpp:3507
3507                   switch((*i)->GetSpellProto()->SpellIconID)
#0  0x0000000000906032 in Aura::HandleModStealth (this=0x7fa5a70c6180, apply=true, Real=true) at ../../../src/game/SpellAuras.cpp:3507
   i = {_M_node = 0x2044d0395bfbbbe}
   mDummyAuras = (const std::list<Aura*, std::allocator<Aura*> > &) @0x7fa56442b708: {<std::_List_base<Aura*, std::allocator<Aura*> >> = {
   _M_impl = {<std::allocator<std::_List_node<Aura*> >> = {<__gnu_cxx::new_allocator<std::_List_node<Aura*> >> = {<No data fields>}, <No data fields>}, _M_node = {
       _M_next = 0x7fa56442df40, _M_prev = 0x7fa56442df40}}}, <No data fields>}
#1  0x00000000008ff0b2 in Aura::ApplyModifier (this=0x7fa5a70c6180, apply=true, Real=true) at ../../../src/game/SpellAuras.cpp:879
   aura = SPELL_AURA_MOD_STEALTH
#2  0x000000000098917e in Unit::AddAura (this=0x7fa56442b3f0, Aur=0x7fa5a70c6180) at ../../../src/game/Unit.cpp:3474
   aurSpellInfo = (const SpellEntry *) 0x7fa5ec261180
   spair = {first = 1787, second = 1 '\\001'}
   i = {_M_node = 0x7fa56442b660}
#3  0x00000000009429aa in Spell::EffectApplyAura (this=0x7fa5bf218f10, i=1) at ../../../src/game/SpellEffects.cpp:2238
   caster = (class Unit *) 0x7fa56442b3f0
   Aur = (class Aura *) 0x7fa5a70c6180
   duration = -1
   added = true
#4  0x000000000091cacd in Spell::HandleEffects (this=0x7fa5bf218f10, pUnitTarget=0x7fa56442b3f0, pItemTarget=0x0, pGOTarget=0x0, i=1, DamageMultiplier=1)
   at ../../../src/game/Spell.cpp:3735
   eff = 6 '\\006'
#5  0x000000000091f444 in Spell::DoSpellHitOnUnit (this=0x7fa5bf218f10, unit=0x7fa56442b3f0, effectMask=7) at ../../../src/game/Spell.cpp:1144
   effectNumber = 1
#6  0x000000000091f6a4 in Spell::DoAllEffectOnTarget (this=0x7fa5bf218f10, target=0x7fa56faf5bc0) at ../../../src/game/Spell.cpp:955
   mask = 7
   unit = (class Unit *) 0x7fa56442b3f0
   caster = (class Unit *) 0x7fa56442b3f0
   missInfo = SPELL_MISS_NONE
   procAttacker = 16384
   procVictim = 32768
   procEx = 0
#7  0x0000000000929ed8 in Spell::handle_immediate (this=0x7fa5bf218f10) at ../../../src/game/Spell.cpp:2515
   ihit = {_M_node = 0x7fa56faf5bb0}
#8  0x0000000000929014 in Spell::cast (this=0x7fa5bf218f10, skipCheck=false) at ../../../src/game/Spell.cpp:2489
   castResult = 0 '\\0'
#9  0x000000000092b9e3 in Spell::update (this=0x7fa5bf218f10, difftime=697) at ../../../src/game/Spell.cpp:2771
No locals.
#10 0x000000000092bdbd in SpellEvent::Execute (this=0x7fa5c5cc6680, e_time=2498502, p_time=697) at ../../../src/game/Spell.cpp:5691
No locals.
#11 0x0000000000ab1a4c in EventProcessor::Update (this=0x7fa56442b520, p_time=697) at ../../../src/framework/Utilities/EventProcessor.cpp:47
   Event = (BasicEvent *) 0x7fa5c5cc6680
   i = {_M_node = 0x7fa5a3cd1ae0}
#12 0x000000000099b2d0 in Unit::Update (this=0x7fa56442b3f0, p_time=697) at ../../../src/game/Unit.cpp:189
No locals.
#13 0x00000000008d936a in Player::Update (this=0x7fa56442b3f0, p_time=697) at ../../../src/game/Player.cpp:1048
   now = 8086634
   pet = (class Pet *) 0x0
#14 0x000000000082124b in ObjectAccessor::UpdatePlayers (this=0x7fa5e5a1f080, diff=697) at ../../../src/game/ObjectAccessor.cpp:502
   iter = {<std::tr1::__detail::_Hashtable_iterator_base<std::Pair<const long unsigned int, Player*>, false>> = {_M_cur_node = 0x7fa5642446c0, 
   _M_cur_bucket = 0x1e854fd8}, <No data fields>}
   playerMap = (
   std::tr1::unordered_map<long unsigned int, Player*, std::tr1::hash<long unsigned int>, std::equal_to<long unsigned int>, std::allocator<std::Pair<const long unsigned int, Player*> > > &) @0xebc9a0: {<std::tr1::__unordered_map<long unsigned int, Player*, std::tr1::hash<long unsigned int>, std::equal_to<long unsigned int>, std::allocator<std::Pair<const long unsigned int, Player*> >, false>> = {<std::tr1::_Hashtable<long unsigned int, std::Pair<const long unsigned int, Player*>, std::allocator<std::Pair<const long unsigned int, Player*> >, std::_Select1st<std::Pair<const long unsigned int, Player*> >, std::equal_to<long unsigned int>, std::tr1::hash<long unsigned int>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true>> = {<std::tr1::__detail::_Rehash_base<std::tr1::__detail::_Prime_rehash_policy, std::tr1::_Hashtable<long unsigned int, std::Pair<const long unsigned int, Player*>, std::allocator<std::Pair<const long unsigned int, Player*> >, std::_Select1st<std::Pair<const long unsigned int, Player*> >, std::equal_to<long unsigned int>, std::tr1::hash<long unsigned int>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true> >> = {<No data fields>}, <std::tr1::__detail::_Hash_code_base<long unsigned int, std::Pair<const long unsigned int, Player*>, std::_Select1st<std::Pair<const long unsigned int, Player*> >, std::equal_to<long unsigned int>, std::tr1::hash<long unsigned int>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, false>> = {
       _M_extract = {<std::unary_function<std::Pair<const long unsigned int, Player*>, const long unsigned int>> = {<No data fields>}, <No data fields>}, 
       _M_eq = {<std::binary_function<long unsigned int, long unsigned int, bool>> = {<No data fields>}, <No data fields>}, 
       _M_h1 = {<std::unary_function<long unsigned int, long unsigned int>> = {<No data fields>}, <No data fields>}, 
       _M_h2 = {<No data fields>}}, <std::tr1::__detail::_Map_base<long unsigned int, std::Pair<const long unsigned int, Player*>, std::_Select1st<std::Pair<const long unsigned int, Player*> >, true, std::tr1::_Hashtable<long unsigned int, std::Pair<const long unsigned int, Player*>, std::allocator<std::Pair<const long unsigned int, Player*> >, std::_Select1st<std::Pair<const long unsigned int, Player*> >, std::equal_to<long unsigned int>, std::tr1::hash<long unsigned int>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true> >> = {<No data fields>}, 
     _M_node_allocator = {<__gnu_cxx::new_allocator<std::tr1::__detail::_Hash_node<std::Pair<const long unsigned int, Player*>, false> >> = {<No data fields>}, <No data fields>}, _M_buckets = 0x1e852d70, _M_bucket_count = 1741, _M_element_count = 928, _M_rehash_policy = {_M_max_load_factor = 1, _M_growth_factor = 2, 
       _M_next_resize = 1741}}, <No data fields>}, <No data fields>}
#15 0x000000000081792b in MapManager::Update (this=0x7fa5dc487920, diff=697) at ../../../src/game/MapManager.cpp:248
No locals.
#16 0x00000000009b863c in World::Update (this=0x2907ec0, diff=697) at ../../../src/game/World.cpp:1566
   autobroadcaston = 0
#17 0x0000000000713ba8 in WorldRunnable::run (this=0x2d5ef10) at ../../../src/mangosd/WorldRunnable.cpp:65
   diff = 697
   realCurrTime = 2333567136
   realPrevTime = 2333566439
   prevSleepTime = 0
#18 0x00007fa5f290c300 in ZThread::ThreadImpl::Dispatch (parent=0x28e41d0, impl=0x2cc1380, task=
       {<ZThread::CountedPtr<ZThread::Runnable, ZThread::AtomicCount>> = {_count = 0x43a070c0, _instance = 0x2cc1380}, <No data fields>})
   at ../../../../dep/src/zthread/ThreadImpl.cxx:407
No locals.
#19 0x00007fa5f290c733 in run (this=0x7ffffc480520) at ../../../../dep/src/zthread/ThreadImpl.cxx:49
No locals.
#20 0x00007fa5f2913606 in _dispatch (arg=0x7ffffc480520) at ../../../../dep/src/zthread/posix/ThreadOps.cxx:137
   task = (class ZThread::Runnable *) 0x7ffffc480520
   __PRETTY_FUNCTION__ = "void* ZThread::_dispatch(void*)"
#21 0x00007fa5f26b53ea in start_thread () from /lib/libpthread.so.0
No symbol table info available.
#22 0x00007fa5f1c78cbd in clone () from /lib/libc.so.6
No symbol table info available.
#23 0x0000000000000000 in ?? ()
No symbol table info available.