Wowka321

It's not LoL already . When this crash early was 1-3 per day - it's normal, but now crash 3-15 times per hours =((

Something strange in ByteBuffer.... =\\

.Rev 9465. Clean core x64 + SD2 1606

Crash 5-30 min

http://paste2.org/p/692511

http://paste2.org/p/692506

any ideas how to resolve this?

Rev. 9450 Some custom (i thing not related) patches.

Every 1-20 min like:

http://paste2.org/p/688247

http://paste2.org/p/688252

http://paste2.org/p/688255

http://paste2.org/p/688373

http://paste2.org/p/688382

Anybody get crashes like that?

current use of SpellDamageBonus for calculating tick damage is still wrong, applies damage mods twice

More correct way, i think

I thing it's bag in description. cuz effect has 400.

This is with assert, one more SD2 crash.

http://paste2.org/p/667742

May be wrong forum for discuss about SD2 crashs, but CreatureAI::DoCastSpellIfCan directly related

Also with pools crash

http://paste2.org/p/667768

.rev 9357 and older after switch to use DoCastSpellIfCan

http://paste2.org/p/666458

But now i can't find any related scripts =(

Some times it happened even generic_creature =(

http://filekeeper.org/download/shared/spell_work_310.exe

Take friend.

rev. 9316

#0  Object::GetFloatValue (this=0x0, index=65) at ../../../src/game/Object.h:189
189                ASSERT( index < m_valuesCount || PrintIndexError( index , false ) );
#0  Object::GetFloatValue (this=0x0, index=65) at ../../../src/game/Object.h:189
   __FUNCTION__ = "GetFloatValue"
   __PRETTY_FUNCTION__ = "const float& Object::GetFloatValue(uint16) const"
#1  0x0000000000786569 in Unit::GetCombatDistance (this=0x7f4a2b6fbe90, target=0x0) at ../../../src/game/Unit.cpp:9088
No locals.
#2  0x000000000051993c in CreatureAI::CanCastSpell (this=0x7f4a2b6a07b0, pTarget=0x0, pSpell=<value optimized out>, isTriggered=false)
   at ../../../src/game/CreatureAI.cpp:58
   fDistance = 0
   fMinRange = <value optimized out>
   pSpellRange = (const SpellRangeEntry *) 0x7f4a6455b250
#3  0x0000000000519b6c in CreatureAI::DoCastSpellIfCan (this=0x7f4a2b6a07b0, pTarget=0x0, uiSpell=<value optimized out>, uiCastFlags=1, 
   uiOriginalCasterGUID=0) at ../../../src/game/CreatureAI.cpp:97
   castResult = <value optimized out>
   pSpell = <value optimized out>
   pCaster = (class Unit *) 0x7f4a2b6fbe90
#4  0x00007f4a6c82f6e2 in ScriptedAI::AttackStart (this=0x7f4a2b6a07b0, pWho=0x1082c5c0) at ../../../../src/bindings/ScriptDev2/include/sc_creature.cpp:63
No locals.
#5  0x0000000000824f9f in MaNGOS::PlayerRelocationNotifier::Visit (this=0x4240dab0, m=<value optimized out>) at ../../../src/game/GridNotifiers.cpp:90
   c = (class Creature *) 0x7f4a2b6fbe90
   relocated_for_ai = true
#6  0x0000000000603071 in Map::Visit<MaNGOS::PlayerRelocationNotifier, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > > (this=<value optimized out>, cell=@0x4240db50, visitor=<value optimized out>)
   at ../../../src/game/../framework/GameSystem/TypeContainerVisitor.h:47
   x = 1111546712
   y = 1111546656
   cell_x = 3
   cell_y = 1

Compile error

10>..\\..\\src\\game\\Group.cpp(917) : error C2065: guid: необъявленный идентификатор

10>..\\..\\src\\game\\Group.cpp(919) : error C2065: guid: необъявленный идентификатор

10>..\\..\\src\\game\\Group.cpp(922) : error C2065: guid: необъявленный идентификатор

10>..\\..\\src\\game\\Group.cpp(928) : error C2065: guid: необъявленный идентификатор

On clean core?, or you have any custom patches? I had this crashes very often too, but after revert Remove CellLock class and all cell-level thread locking and related, never saw this crash anymore.

Some trainers spells have 2 or more effects "learn spell'. Like Flight Form. And if you already have Expert Riding or higher rank, you can't learn spell with this effect. This is a bug for now.

Very interesting. And what CPU on server?

I saw this. But even you learn it, you can't speak and andestand. But i remember in 2.4.3 it worked.

Yes. Very intersting what is it now languages. Skill, spell, or may be need some flags also?? =\\

Ты бы лучше вместо того чтобы понтоваться, подготовил бы все в виде патча и выложил бы на обсуждение и доводку до идеала. Или ты пришел сюда только понты гонять и кричать всем какой ты умный и все реализовал?

Tested 2 days. Not found any negative influence.

I moved this in more correct place (as i think)

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index c0c5bbe..bbffdf8 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -1291,7 +1291,15 @@ bool Spell::IsAliveUnitPresentInTargetList()

            // either unit is alive and normal spell, or unit dead and deathonly-spell
            if (unit && (unit->isAlive() != IsDeathOnlySpell(m_spellInfo)))
+            {  
                needAliveTargetMask &= ~ihit->effectMask;   // remove from need alive mask effect that have alive target
+                // check if spell aura on target does not exist anymore (for channeled spells)
+                if (IsChanneledSpell(m_spellInfo) && m_spellInfo->AuraInterruptFlags != 0)
+                {
+                    if ( !unit->HasAura(m_spellInfo->Id) )
+                       return false;
+                }
+            }
        }
    }

[patch] SPELL_AURA_MOD_BLOCK_CRIT_CHANCE

What bug does the patch fix? What features does the patch add?

Implement SPELL_AURA_MOD_BLOCK_CRIT_CHANCE.

This fix talent [Critical Block]

For which repository revision was the patch created?

master

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Did not find any

Who has been writing this patch? Please include either forum user names or email addresses.

Me

http://paste2.org/p/636479

Yep, ufter undo this commit stability come back. =)

I made some test. All fine, while. )) Thx, reeshack.

Confirm. Think related http://github.com/mangos/mangos/commit/e8929f3c939dfad55518e316711ed260cdbddca8

I'll try to revert...

New crashes in Groups

http://paste2.org/p/632825

http://paste2.org/p/632826

May be related this commit?

http://github.com/mangos/mangos/commit/e8929f3c939dfad55518e316711ed260cdbddca8#diff-4

I saw this.

Try do first make. And after compile - make install.

revision top - it's not revison. update sources. I thing this crash related arena-points according last changes... it was fixed.

Nice patch. All working good exept one... If your eye atacking by mobs and in this time you logout, after eye die - server crash. Eye must unsummon if owner not in world.