Wowka321

Just change part of code orginal like:

http://paste2.org/p/885131

Tested and looking fine. Finely zones and areas detected properly - Ironforge is Ironforge, Dalaran with subzones...fishing...indoor dismount... Sweet

Will try to do stress-test on weekends.

Use anticheat / Ban characters =)

Look at auras on player, if no mounts auras - fly hack. If mount aura persist, but mount not exist - you don't have creature_template with proper data for this mount spell.

przemratajczak, yes. From time to time i get crashes like this.

Updated )

Now it's checked where possible)), BTW check in lvl i think not need, exploit not possible in real game here.

Players will lose HP and mana on each skillup.

yea, you are right. =\\ So any ideas how to check and reapply bonuses if need?

BTW, this bug not related to patch. It exist on clear core too.

It just copy-paste from existing code

First we check for group existing, second, that this looter in same group ( i hope ).

DJNefast, you are lost delete result2; in every QueryResult *result2

Update. Fix possible exploit.

What bug does the patch fix? What features does the patch add?

Add possibility to use ACHIEVEMENT_CRITERIA_REQUIRE_HOLIDAY for any criteria.

In this case, like example, add ACHIEVEMENT_CRITERIA_REQUIRE_HOLIDAY for ACHIEVEMENT_CRITERIA_TYPE_USE_ITEM for achievement.

For which repository revision was the patch created?

9933

Who has been writing this patch? Please include either forum user names or email addresses.

me

patch

example

INSERT INTO achievement_criteria_requirement (criteria_id,TYPE,value1) VALUES
(10391,16,201),
(6651,16,201),
(6652,16,201),
(6653,16,201),
(6654,16,201),
(6655,16,201),
(6656,16,201),
(6657,16,201),
(6659,16,201),
(6641,16,201),
(6642,16,201),
(6643,16,201),
(6644,16,201);

Hi everyone.

After 9896, attack power not included in calculation of Unit::SpellDamageBonusDone for not mana-based classes, cuz GetBaseSpellPowerBonus for those classes in current code is 0 and DoneAdvertisedBenefit 0, so don't pass if (DoneAdvertisedBenefit)......

If you look into Unit::SpellDamageBonusDone - you'll see it.

So, maybe we should to divide GetBaseSpellPowerBonus - for mana-based classes (like priest, warlock, shaman), AP-based (rogue, DK, war), and mixed like druid in forms and get right bonus for form... hm, but don't know about hunter with mana, and scaling stats from AP...

Maybe i mistake, but we need discuss this issue, cuz AP-based classes is sucks, like you do damage without your gear.

hm, but don't know about hunter with mana, and scaling stats from AP

Something, like this

../configure  CFLAGS="-O3 -pipe -msse4.2 -DFD_SETSIZE=4096 -march=core2 -fomit-frame-pointer -ffast-math -fno-strength-reduce -fno-strict-aliasing -frename-registers" CHOST="x86_64-pc-linux-gnu" CXXFLAGS="-O3 -pipe -msse4.2 -DFD_SETSIZE=4096 -march=core2 -fomit-frame-pointer -ffast-math -fno-strength-reduce -fno-strict-aliasing -frename-registers" --prefix=/home/serv --sysconfdir=/home/serv/etc --datadir=/home/serv --with-debug-info --disable-builtin-ace

Ы

sorry, but is it usefull

Man, you already ask this question as i remeber ))

Why i don't have this issue??))

No one )

More or less hackly anyway.

This is offtop anyway ))

It's for SD2, where you wanna, better place is npc_special.cpp )

Yes, with patch now working fine ))

o_O, Just tested on 9890 - working fine, as should.

I modified and simplify script, and now work fine for me.

http://paste2.org/p/826610

its hacky, never will be accepted

a more correct way would be doing the effect in Player::UpdateAttackPowerAndDamage, since its only a dummy aura now.

Lol, and i don't post this under review topic.

If you ask blizz: give me full version DBC please!!! than no one hacks not needed in core.

BTW, what are you think about some spells like: 56815 (need Caster Aura State 56817), 48020 (need Caster Aura State 62388) and more-more with newest releases of client.

Or you think send fake packets to client better? o_O

And IMHO, hardcode bonuses more-more hackly in this case...

Just don't use this mega-hack for self.

Sorry about offtopic =\\

http://paste2.org/p/816983 This is from alternate project. Don't know who is original author, but ported by eugen.rivniy, Trazom62, and for mangos by me ))

May be it helpfull.

ASSERT for catch source of crash, btw u can comment it, or teleport player, or kick him .. ban him.. what u wanna

With patch work perfect. ^^