Wowka321

Remove only

if(GetModifier()->m_miscvalue == FORM_CAT)

we should give 10% bonus instead 20% in all forms ^^

SQL-DBC patch by QAston modified by me

http://paste2.org/p/793708

and SQL part to fix this tallent

http://paste2.org/p/793712

By this patch possible to fix many spells. I found at least 10 spells which not existing in DBC now. =\\

GUID in SQL-query not right:

2010-04-25 00:52:13 [0 ms] SQL: UPDATE characters SET deleteInfos_Name=name, deleteInfos_Account=account, deleteDate=1272145933, name='', account=0 WHERE guid=0

guid always = 0;

Proc Lightning Shield in code checking only by SpellFamilyFlags. But some other spells have same flag, like Spore Cloud which can't proc, because of it..

This patch fix it.

http://paste2.org/p/789077

Crash-fix http://paste2.org/p/789074

found a problem you cannot join random battleground with a single player only if you are in group and the leader press join as group...

From patch note

The Random Battleground option will only allow a group size of 5 players to queue together.

Ok, this is implementation SQl-DBC from QAston http://paste2.org/p/786697

And sql part for fixing overkill http://paste2.org/p/786706

After swith to 3.3.3 not work correct, cuz spell 58428 now not exist in DBC. BTW i found many major spells which now not existing in DBC, but realy need, like 62388 (for Demonic Circle), 56817( for Rune Strike), 61988(Divine Shield Exclude Aura), or many triggered spells (mostly whitch should change durations of some auras) like 58428 with durations 20000 for overkill. What we should do now? Hardcode (very hackly) durations, send fake auras, etc... or maybe time to implement SQL-storage for overwriting spell-DBC for not existing spells or existing, but with wrong values? This is the major question for now! Nobody know what to happen in the future with DBC :\\

Just tried patch. Core sturtup fine, but realmd-demon can't start

./mangos-realmd: error while loading shared libraries: libtbb.so.2: cannot open shared object file: No such file or directory

How related tbb to realmd?

P.S. Ubuntu 8.10 amd64

Looking very strange... If you properly configure and compile mangos-sources, than looking like some bug in libs . Try reinstall/update (libs, GCC, something else ). But with this coredump we never can't find source of crash =\\

No info about PC, system. Crash like this start even from network activity to libs \\ kernel bugs. =\\

Revert commit disabling this

o_O

Man, first mangos-sources not in SVN, second how related maps for arcemu and maps for mangos? Use extractor which provided with sources.

Old bug. Apear after implementation of multi-build support. Just re-log again

Look into server.log maybe here something bla-bla-bla guid overflow......can't continue... server shutdown. In fact it can be not lasts strings in log.

may be in log something guid overflow ??

Sorry, Vladimir. My mistake again =\\

Rebuilt both solutions solve problem.

I have checked up it not once =\\ Values for setup is right.

i use SetEquipmentSlots ( i know - it's not related core in clearly way)

but definitions from core like

UNIT_VIRTUAL_ITEM_SLOT_ID

and UNIT_VIRTUAL_ITEM_SLOT_ID in core == 56, rigth, but if you set UNIT_VIRTUAL_ITEM_SLOT_ID (size 3) it looking like you set values for UNIT_VIRTUAL_ITEM_SLOT_ID - 1.

SetEquipmentSlots(false, 49303, 47146, 47267);

in result i'll get faction 49303 (not exist) for scripted creature, but not MAIN_HAND. =\\

Rev. 9728.

Maybe something changed in EUnitFields after switch to 3.3.3 ?

Eg: if you try set (by script) UNIT_VIRTUAL_ITEM_SLOT_ID, really you set UNIT_FIELD_FACTIONTEMPLATE instead UNIT_VIRTUAL_ITEM_SLOT_ID.

Graz

Welcome!

Rev. 9670 + SD2. Crash in Player::ActivateSpec very often.

http://paste2.org/p/756468

Really get loot? I can't reproduce this. It's only visual. btw same bag with creature.

This sql restore titles.

UPDATE characters, data_backup

SET characters.knownTitles = SUBSTRING(data_backup.data,

length(SUBSTRING_INDEX(data_backup.data, ' ', 626))+2,

length(SUBSTRING_INDEX(data_backup.data, ' ', 631+1))- length(SUBSTRING_INDEX(data_backup.data, ' ', 626)) - 1) WHERE characters.guid=data_backup.guid;

Like in zulaman script part

//increase or decrease chance of mojo?

if (!urand(0, 49))

DoCastSpellIfCan(caster, SPELL_PUSH_MOJO, CAST_TRIGGERED);

urand always return value (Zero is value too), and DoCastSpellIfCan never to be happened here =\\ Tested many-many times.

in operator if we should use operators of comparison or boolen value. groupLootRules - not bool, that why groupLootRules = 0 value too and pass check in if. 0 != NULL. 0 it's Zero - it value true.

Maybe i'm wrong and someone can explain it more clearly?

It not related this topic. But confirm issue ))

Ok, after some research loot condition PlayerNonQuestNonFFAConditionalItems not affected by loot rules, cuz this

b << uint8(0); // allow loot

but those items not free_for_all

My attempt to fix it

http://paste2.org/p/735387

Maybe one bag with master loot, if item drop with condition for group-member, but ML don't have this condition and ML can't view this item.