XTZGZoReX

Yes, I forgot to mention that... So (b) is how it should be done.

o_O I thought m_target can be null for any spell... you don't necessarily have a target when you cast it, right?

Yes, we must either: a) change code in core to use platform-dependent integer sizes. or b) change vmap extractor/assembler to use typedef'd integers.

Looks good. I'll commit this today.

Your patch is malformed - can you fix it please?

Come to think of it, when I tested this, I divided by 0 (not 0.0) -- this might make a difference.

Uhm, last I checked the C++ standard, it stated that division by zero throws an FPE...

Can you paste these linker errors?

This is already things we're working on internally, so if Opterman has some useful code to share, I'd be very willing to see it and review it.

I am planning to update the internal ACE shipped with the MaNGOS sources. However, I have heard that FreeBSD has issues with latest ACE versions, so I need info on what exactly is wrong, and on what ACE versions problems exist. The version I plan to update to is 5.7.4, available here: http://download.dre.vanderbilt.edu/previous_versions/ What I want you (FreeBSD users) to do is: * Compile ACE 5.7.4 * Compile latest MaNGOS with system ACE (5.7.4) instead of built-in ACE * Run server and test if things (threading and networking) work OK Please report back here. Remember to include your FreeBSD OS version. Thanks.

Ofc we will still just enumerate some data values into blob fields even after we do cleanup. Otherwise, we'd get way too many fields.

accmgr renamed to sAccountMgr.

Seems I missed that one. Thanks.

Because it was just made to "work". Nothing else.

Using two threading libs at the same time is always bound to cause some sort of trouble.

No. The ones in SD2 are pure hacks, and thus will not be moved to core. In fact, they should be completely removed and replaced with proper implementations.

And besides, MaNGOS does not "officially" do this.

In revision [8789] almost all singleton names have been changed to a more consistent naming style. Most patches will need updating to reflect this. The changes: Thanks, - Zor.

Oh, nono, that wasn't what I was picking at didn't know you meant uptime. Back when I ran my server with this, I was able to pull uptimes of up to 7 days. I'm curious: Is this necessary? After all this happens within Player::Update which only happens within Map::Update on the single map the player is on .

It's used for keeping things in check. Removing such asserts is bad idea. In what unit? Meters? Approximately 4326243. I actually think this is wrong. Back in the day, there were loads of crashes due to this not having a critical section on it. You could just add some #if to make things work .

Yes, this is just advice .

In code . But also, in string literals, you should use \\t.

No... This is an entire alternative to mtmaps.

How did you come to this conclusion?:

Your patch contains tabs - you'll need to fix those before it can get to the repo.