yad02

Yes I forget this : http://bitbucket.org/kane/infinitycore/changeset/bc57f3b09bc3/

I suppose that XTZGZoReX is sure that pointer is successfully created..

Need more test

I Just port XTZGZoReX work for MaNGOS outdoor patch

Tested, it seams work...

http://filebeam.com/bc921eeb4246a45f23ae832dd7f228d7

I suppose it's the good way

however GetGameObject() needs to be called from map class...

Does someone has idea to fix compile since [8653] Implemented per map guids store. ?

Spells hasn't SPELL_AURA_MOD_SPEED_FLIGHT + SPELL_AURA_MOD_SPEED_MOUNTED in same time in their structure. (from spell.dbc)

However is you cast spell causing aura SPELL_AURA_MOD_SPEED_FLIGHT does spell causing aura : SPELL_AURA_MOD_SPEED_MOUNTED is always removed ?

And vice versa ?

I think but I'm not sure...

I think your function is correct

however maybe load display Alliance from DBC (and hardcode Horde if modelid Alliance is different than Horde...)

Some display in DBC (ghoul for example) are different than (actual) hardcoded displayid

Yes, but (I think, not tested for all) you can find displayid_H with search based on SoundId in CreatureDisplayInfo.dbc

I just test some Shapeshift Form, this doesnt work with FORM_FLIGHT, no SoundID and 2 forms.

So, check isn't good...

EDIT :

Maybe load DisplayID_H from creature_template

However querie :

SELECT * FROM `creature_template` WHERE `modelid_A` = 2281 OR `modelid_A2` = 2281;

returns `modelid_H` = 2281;

( On UDB ) for creature entry 4253 and another creature ...

So better issue is hardcode modelid...

What is Vladimir's opinion ?

Yes, but (I think, not tested for all) you can find displayid_H with search based on SoundId in CreatureDisplayInfo.dbc

Entry Point : SpellShapeshiftForm.dbc (sorry for french names...)

5,3,,,"Forme d’ours",,,,,,,,,,,,,,0xFF01FE,728,1,496,2500,2281,0,,,0,0,0,0,0,0,0,0x0,

In : CreatureDisplayInfo.dbc

Alliance Display : 2281 ==>

2281,213,3022,0,1.0,255,"DruidBearSkinRed","","","",1,0,0,0,0x0,0,

All 213 are DruidBear (I suppose Alliance for all - not tested)==>

23950,213,0,0,2.0,255,"DruidBearSkin","","","",1,0,0,0,0x0,0,

29413,213,0,0,1.0,255,"DruidBearSkinPurple","","","",1,0,0,0,0x0,0,

29414,213,0,0,1.0,255,"DruidBearSkinBlack","","","",1,0,0,0,0x0,0,

29415,213,0,0,1.0,255,"DruidBearSkinBlue","","","",1,0,0,0,0x0,0,

29416,213,0,0,1.0,255,"DruidBearSkinWhite","","","",1,0,0,0,0x0,0,

29417,213,0,0,1.0,255,"DruidBearSkinRed","","","",1,0,0,0,0x0,0,

29438,213,0,0,1.0,255,"DruidBearSkinBlack","","","",1,0,0,0,0x0,0,

29440,213,0,0,1.0,255,"DruidBearSkinPurple","","","",1,0,0,0,0x0,0,

count(DruidTaurenBearSkin) == 9

Sound id (DBCStructure.h) another record : 3022 ==>

2289,214,3022,0,1.20000004768,255,"DruidTaurenBearSkinBrown","","","",1,0,0,0,0x0,0,

All 214 are DruidBear (I suppose Horde : "Tauren" for all - not tested)==>

29418,214,0,0,1.20000004768,255,"DruidTaurenBearSkinBlack","","","",1,0,0,0,0x0,0,

29419,214,0,0,1.20000004768,255,"DruidTaurenBearSkinSilver","","","",1,0,0,0,0x0,0,

29420,214,0,0,1.20000004768,255,"DruidTaurenBearSkinYellow","","","",1,0,0,0,0x0,0,

29421,214,0,0,1.20000004768,255,"DruidTaurenBearSkinWhite","","","",1,0,0,0,0x0,0,

count(DruidTaurenBearSkin) == 5

Not tested for all Druid ShapeshiftForm... seams to be exactly the same thing as this for cat form

EDIT1 :

Interesting topic here : http://forums.worldofwarcraft.com/thread.html?topicId=17631614423&sid=1

EDIT2 :

I think thenecromancer issue is the best issue... (just verify displayid in case...)

"hardcode" displayid (Horde & Alliance) is faster than to find displayid from dbc with "my" idea to find both

(use displayid_A to find displayid_H from SpellShapeshiftForm.dbc to CreatureDisplayInfo.dbc)

In any case I don't see how bear and cat skin are defined. No way in DBC... (in my opinion)

Patch updated : http://filebeam.com/10868571171ca6c9291c437ffa5ff50b

More fixes please test it

Any testing progress?

Sorry to steal Apoc's expressions

Do you think it's the good way to fix conflicts with 3.2.2 ?

void Player::UpdateZone(uint32 newZone, uint32 newArea)
{
   AreaTableEntry const* zone = GetAreaEntryByAreaID(newZone);
   if(!zone)
       return;

   uint32 oldZoneId  = m_zoneUpdateId;

   if(m_zoneUpdateId != newZone)
   {
       SendInitWorldStates(newZone, newArea);              // only if really enters to new zone, not just area change, works strange...

       if (sWorld.getConfig(CONFIG_WEATHER))
       {
           if(Weather *wth = sWorld.FindWeather(zone->ID))
               wth->SendWeatherUpdateToPlayer(this);
           else if(!sWorld.AddWeather(zone->ID))
           {
               // send fine weather packet to remove old zone's weather
               Weather::SendFineWeatherUpdateToPlayer(this);
           }
       }
   }

   m_zoneUpdateId    = newZone;
   m_zoneUpdateTimer = ZONE_UPDATE_INTERVAL;

   // zone changed, so area changed as well, update it
   UpdateArea(newArea);

   // inform outdoor pvp
   if(oldZoneId != m_zoneUpdateId)
   {
       sOutdoorPvPMgr.HandlePlayerLeaveZone(this, oldZoneId);
       sOutdoorPvPMgr.HandlePlayerEnterZone(this, m_zoneUpdateId);
   }    

   // in PvP, any not controlled zone (except zone->team == 6, default case)
   // in PvE, only opposition team capital
   switch(zone->team)
   {
[...]

Hello rastikzzz,

can you take some time to up to date your git branch please ?

branch was already in conflict but now, with 3.2.2 switch it's a great conflict

Thank you in advance.

It will never arrive, this code is very hacked

Additionnal informations :

This is a very ugly hack...

if someone have idea to optimize and clean this patch I open to your ideas.

It's a personnal challenge (thank to woweur & TOM_RUS) don't view this post as insult

I think all is supported except druid flying form

Direct link : Flying Everywhere patch

Please test the patch and report any crashes/malfunctions. Thanks.

plz delete this post (thank you in advance)

May be I will write some stupid thing...

If it's Intel Memory Allocator so this patch doesn't work on AMD64, no ?

Thank you !

However I use this batch

@echo off
set git="C:\\Program Files\\Git\\bin\\git"

mkdir MaNGOS-Src > NUL 2>&1
cd MaNGOS-Src

%git% init > NUL 2>&1
%git% remote add origin git://github.com/mangos/mangos.git > NUL 2>&1
%git% fetch origin
%git% merge origin/master
pause

it worked very good

but now I have this error :

remote: error: object directory /data/git/repositories/4/cc/9d/62/mangos/mangos.git/objects does not exists; check .git/objects/info/alternates.

remote: Counting object... next is good...

Maybe It's not the good thread to post it, I hope git isn't partially broken...

About git system,

can I remote from bg2db10 over bg2db ?

is what bg2db be going to like this change ?

Is it possible to update .gitignore in ./win/ folder and add rule to ignore .cache (or .sln.cache) files ?

I use msbuild command line to generate mangos and when mangos is builded, a file : mangosdVC90.sln.cache is created in this folder

file .gitignore

@@ -11,6 +11,7 @@
#

*.ncb
*.suo
*.sdf
+*.cache
ipch

Hello balrok

in http://github.com/balrok/mangos/raw/51faf26a4f78f24b1538c877742595d971c25416/src/game/BattleGroundAB.cpp

You have :

m_TeamScores500disadvantage and

m_TeamScores500Disadvantage

is it normal ?

I have many conflicts between bg2db and bg2db_av branch about AB battleground

okay thank you I just do it

Sorry for french log, it's only new AV patch wich causing these errors, about bg2db base patch it's ok works fine for me (for now)

BattleGroundAV.cpp
..\\..\\src\\game\\BattleGroundAV.cpp(506) : warning C4101: 'index' : variable locale non référencée
..\\..\\src\\game\\BattleGroundAV.cpp(833) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(834) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(838) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(839) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(877) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(887) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(888) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(890) : error C2677: '[' binaire : aucun opérateur global trouvé qui accepte le type 'BG_AV_OTHER_VALUES' (ou il n'existe aucune conversion acceptable)
..\\..\\src\\game\\BattleGroundAV.cpp(891) : error C2677: '[' binaire : aucun opérateur global trouvé qui accepte le type 'BG_AV_OTHER_VALUES' (ou il n'existe aucune conversion acceptable)
..\\..\\src\\game\\BattleGroundAV.cpp(895) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(896) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(897) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(898) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(899) : error C2109: un indice requiert un type tableau ou pointeur
..\\..\\src\\game\\BattleGroundAV.cpp(901) : error C2109: un indice requiert un type tableau ou pointeur

Can you fix conflicts with it http://github.com/mangos/mangos/commit/a54f2aaed43bf84b7146acbc2c01613164a49cef

please.

little answer, I already merge with alterac (3.X.X) patch

can I merge with bg2db then bg2db-av without risks or it's better to reset sources ?