Almost Night

The Rethban Ore (Item ID 2798) is part of the Quest Rethban Ore (Quest ID 347). It should be dropped by enemies within the Rethban Caverns, as well as Veins in the specific region. On Zero, the Rethban Ore can be looted from all kind of Veins, since the loot templates aren't correct. The gameobject templates 2054 and 2055 are the only ones which should have Rethban Ore in their loot template. This counts for Zero, One and Two as well. To fix the issue, use the following query to delete Rethban Ore from all loot templates it doesn't belong to. FOR ZERO, ONE AND TWO: DELETE FROM `gameobject_loot_template` WHERE `item` = 2798 AND `entry` NOT IN (2054, 2055); While the gameobjects within the cavern seem to be fine on One and Two, the gameobjects for Zero are mostly a mess. The ones I found are listed down below. ONLY FOR ZERO: UPDATE `gameobject` -- Tin Vein SET `id` = 2054 WHERE `guid` IN (72064, 72065, 72066, 72082, 72083, 72085, 72086, 72087, 72123, 72124, 72125, 72126, 72127); and UPDATE `gameobject` -- Copper Vein SET `id` = 2055 WHERE `guid` IN (72000, 72001, 72002, 72009, 72010, 72011, 72012, 72051, 72052, 72053, 72062); This way the Rethban Ore should only be mined in the Rethban Caverns.

THIS STARTED IN MANGOS ONE, BUT IS ACTUALLY A CROSS CORE ISSUE - IF YOU CAN, PLEASE MOVE THIS TO THE CROSS CORE SECTION. Someone recently sent me a video about an analysis of different issues on private servers regarding the combat calculations, one of those issues was the Glancing Blow. So I checked back on the information given and the code and saw that there is a problem with the combat calculations regarding the Glancing Blow, which seems to be capped to 40% on TBC and WotLK when it shouldn't. <Insert Rambling about people spending hours on creating YouTube videos, but 0 time sending a bug report> So I found the issue on One and Two: One: https://github.com/mangosone/server/blob/v22.01.62/src/game/Object/Unit.cpp#L2878 Two: https://github.com/mangostwo/server/blob/v22.01.77/src/game/Object/Unit.cpp#L3253 Source: https://wowwiki-archive.fandom.com/wiki/Glancing_blow There were several discussion in the forums already, which lead to no changes regarding that issue, but with the old sources + NuTBC confirming it we should do so accordingly. I couldn't find reliable sources for anything past the 25% chance, so I went on to create Pull Requests for anything up to Four. Since the 40% was just copy and paste from the previous version, I'd rather go with the 25% starting from TBC.