kreegoth

I understand that people would like to see it updated but what is the issue with it that prevents them from using it for 3.3.2? I Have been running a 3.3.2 server for some time using this repo.

When trying to apply this to the core i receive an error relating to int32 bp = int32(m_spellInfo->CalculateSimpleValue(EFFECT_INDEX_1) * m_healthLeech / 100); Specifically the EFFECT_INDEX_1 part.

The only current way to fix this is to use a DBC editor and open item.dbc . If you are doing weapons it helps to sort it by class and look for weapons class (2) then you need to compare the item ids in the DBC to the ones in your Item_Template table. Find entries in the Item.DBC ( FIRST column on the left ) that do not exist in the Item_Template ( First column on the left ) that have (2) as the class ( Not 100% sure but i believe its the 2nd column on the left). Then CHANGE the id of a custom item in the item_template to the Item id in the Item.DBC that did not exist in your database. Ensure that the class and subclass stays the same Ie you have to change a sword for a sword and a mace for a mace. To make the Displayid work correctly you must use the edit listed in this thread earlier else the item will still show the Displayid used for that original item from Item.DBC. An example of changing this would be Update Item_template set Entry = THEUNUSEDIDFROMITEM.DBC where Entry = CUSTOMITEMID; Keep in mind in doing this you will also need to alter the quest rewards if any of the custom items are Quest rewards as well as the Loot drops or Vendor tables. There is a well working Sql in this thread for the characters tables to edit characters already having said items. All in all it took about 4 hours to edit around 400 weapons.

Does anyone have a .sql or anything containing a list of the unused item ids with classes and subclasses? The reason i ask is if I could obtain that it would be much easier to reference which item ids are not currently in use. Once looking at my Db and realizing I would only need to change items that are weapons or shields offhand or such I find there are 451 entries. If someone knows how i could creature this list myself I would appreciate it. Thank you. ******************************************************************************************************* Update I did end up doing this the above mentioned way and over 4 hours found enough unused ids for around 300 items.. Wasnt really that bad. I think though for it to work as intended im going to have to comment out the DBC check for the sheath as it sometimes results in really weird sheath styles ( Swords upside down and such ) also the items do not have the correct icons on actionbars even with the Displayid check removed.

Well Vladimiar I understand what you are saying and have said. Its not a matter of being slow its a matter of stating facts simply.. If a way around this is not found then eventually servers will be unable to include custom content for items. I mean next expansion moves item ids up 5k say and uses a bunch of the Currently unused Ids.. So then every time there is an expansion and such server admins will need to redo the items table. At some point in the SERVER side the client has to ask the server what type of weapon is in the Characters hand. Perhaps when it offers up the Error code for REQUIRED_MELEE_WEAPON ( Was looking at it yesterday cant remember atm exact name though ) at that point the server likely checks what type of weapon is there and sends the Error code. But regardless, My point was to simply attempt to find a way to make this issue work. I mean many times server owners were told "Oh you cannot fix the ? mark displays because they are checked in the client and not server side" But about 10 posts above someone posted a code which does just that.

Well i mean im sure.. With enough people looking at this or perhaps just the correct person looking at it it would be possible.. I mean simply commenting out the section about the Displayids stops the ? marks from Appearing.. There must be a section to comment out a check into the DBC for the items Classes and such...

The reason this concerns me as a operator is this. A lot of work can go into finding unused Id's for all of the items that are custom. But with next expansion and even future patches those Ids could all of a sudden become used and overwritten. Does this not seem likely to anyone else?

Well yes I did read the thread.. What I was asking was cause we use a commnet line or something that would allow the Custom items To be sent from DB as normal so that they would be recognized as (Main hand or Shield or such) Or maybe a line something like If Itementry > 50000 then select * `entry` from `item_template` where `entry` = 'Itemid' Now before anyone complains that they sentence is wrong or wouldnt even work I KNOW that. I wasnt suggesting that line itself be used.. just an example of how I meant it.

Could a patch like that not be used to circumvent the entire issue? I mean some servers I'm sure like mine have many many custom items. It would take an extremely long time for those people to change all of the items involved to unused ones in the DB finding items with the correct fields and such. Could a patch not be made like the one above that simply tells the client to continue retrieving the items info out of the DB entirely, or however it did it in previous versions?

The paladin spell Divine storm is bugged in that the Damage part works fine but the healing part for group members does not.

Sorry to post here but i cant get inside as i cant stay logged in unless i clear my Temp files everytime?.. it says Thank you for logging in so and so and then when it comes back here im still not logged in?

Im sorry for the stupidity of this post in advance! I have followed the instructions at the top of this thread and I can get to the patch part.. it succeeds after the command is typed in but the patch it creates is 0kb and empty? Also where do i get the Sqls to run that creates the tables needed for it and such as i didnt see any of them in the Ahbot folder after checking it out?