amaru

CastPetAuras is called when creating pet by it's owner. CastPetAura is called from last function and on applying related dummy aura to owner. We are interested in in first only, because minipets, guardian pets, protector pets are 'Pet' too. thats the wrong place, maybe we should cancel all spells on mini pet in Spell:CheckTarget-function warlock's pets are SUMMON_PET's, they currently have no HUNTER_PET's so no effecthunter's pets are HUNTER_PET's, they currently have no SUMMON_PET's so no effect dk pets are GUARDIAN_PET and SUMMON_PET, but db table spell_pet_auras is not used currently with dks and there is no appropriate dk talents for this. shaman pets are GUARDIAN_PET and also shaman doesn't have any talents to be suitable for table spell_pet_auras there auras are casted by pets on oneselves, so the only way is check like in my patch or add collumn to spell_pet_auras with desired pet type

updated patch

There are two ways - use TeleportToBGEntryPoint and don't use - just check for IsPlayerInBattleGround. In this case, player bg data will be checked on next LoadFromDb and location will be set to bg entry point. updated patch http://paste2.org/p/1978844

* What bug does the patch fix? What features does the patch add? Entries from pet_spell_auras (hunter ferocious inspiration, kindred spirits, etc) are applied to non-combat pets also. * For which repository revision was the patch created? 11959 * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. don't know * Who has been writing this patch? Please include either forum user names or email addresses. me http://paste2.org/p/1978245 Index: C:/wr-core_temp/test-zone/code/src/game/Pet.cpp =================================================================== --- C:/wr-core_temp/test-zone/code/src/game/Pet.cpp (revision 6371) +++ C:/wr-core_temp/test-zone/code/src/game/Pet.cpp (revision 6372) @@ -2074,6 +2074,9 @@ if(!owner || owner->GetTypeId()!=TYPEID_PLAYER) return; + if (getPetType() != HUNTER_PET && getPetType() != SUMMON_PET) + return; + for(PetAuraSet::const_iterator itr = owner->m_petAuras.begin(); itr != owner->m_petAuras.end() { PetAura const* pa = *itr; @@ -2092,6 +2095,9 @@ if(!auraId) return; + if (getPetType() != HUNTER_PET && getPetType() != SUMMON_PET) + return; + switch(auraId) { case 35696: // Demonic Knowledge

* What bug does the patch fix? What features does the patch add? When a gm, who's ported to a battleground, log out in it, he's added to battleground players. As a result: - When gm logs in, it may appear one of raid groups. - When battleground is arena, and remaining players fight 1x1, gm's logout make random team win arena. If it's 2x1, it _may_ lead to win. * For which repository revision was the patch created? 11959 * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. don't know * Who has been writing this patch? Please include either forum user names or email addresses. me http://paste2.org/p/1978844 Index: C:/wr-core_temp/test-zone/code/src/game/WorldSession.cpp =================================================================== --- C:/wr-core_temp/test-zone/code/src/game/WorldSession.cpp (revision 6365) +++ C:/wr-core_temp/test-zone/code/src/game/WorldSession.cpp (revision 6366) @@ -418,7 +418,10 @@ //drop a flag if player is carrying it if(BattleGround *bg = _player->GetBattleGround()) - bg->EventPlayerLoggedOut(_player); + if (bg->IsPlayerInBattleGround(_player->GetObjectGuid())) + bg->EventPlayerLoggedOut(_player); + else + { + _player->TeleportToBGEntryPoint(); + _player->SetBattleGroundId(0, BATTLEGROUND_TYPE_NONE); + } ///- Teleport to home if the player is in an invalid instance if(!_player->m_InstanceValid && !_player->isGameMaster())

Thanks for the answers

_storage is byte "array" by default. such arrays in memory are located as continuous set of bytes. _storage as value is a pointer to it's first element if uint8 storage[n]; then storage == &storage[0] which means that storage val points to the head of that array when accessing _storage[pos] you access *(_storage + pos), which means byte number 'pos' since address of _storage. by casting *((T const*)&_storage[pos] you say that &_storage[pos] is pointer not to uint8 but to value type T*, and it would 'grab' nearest bytes depending on T size

How can I make a struct uncopyable? I need separate mutex for each instance

Hello! I modifier LooItem struct in LooItem.h and added ACE_RW_Thread_Mutex in it. http://paste2.org/p/1966439 This makes compile fail with error 2>c:\\core_temp\\test-zone\\code\\dep\\ACE_wrappers\\ace/RW_Thread_Mutex.h(63) : error C2248: 'ACE_RW_Mutex::operator =' : cannot access private member declared in class 'ACE_RW_Mutex' 2> c:\\core_temp\\test-zone\\code\\dep\\ACE_wrappers\\ace/RW_Mutex.h(127) : see declaration of 'ACE_RW_Mutex::operator =' 2> c:\\core_temp\\test-zone\\code\\dep\\ACE_wrappers\\ace/RW_Mutex.h(42) : see declaration of 'ACE_RW_Mutex' 2> This diagnostic occurred in the compiler generated function 'ACE_RW_Thread_Mutex &ACE_RW_Thread_Mutex::operator =(const ACE_RW_Thread_Mutex &)' The reason for this is that it tries to initialize instance of ACE_RW_Mutex, but is has private constructor, so it fails. Question - why? There are so many ACE_RW_Thread_Mutex'es in code (HashMapHolder, TerrainMgr, etc) but there are no such errors.

As for transports there is gameobject_addon table that fixes everything, but there are a lot of other custom objects that became rotated

Some time ago (~year) SilverIce introduced a revision where gameobject rotation became handled as quaternions, as a result many objects were found rotated around some axis prior to their previous position. What can be done and is there any general solution to this?

in dep\\ACE_wrappers\\ace\\config-freebsd.h you will need to add lines #define ACE_LACKS_GETHOSTBYADDR #define ACE_LACKS_NETDB_REENTRANT_FUNCTIONS at the top of the file

First of all you should learn what 'Spell' means and consist of in terms of Mangos, then you would be able to compare bloodrage to spells with similar effects and discover what's wrong with it

4>------ Build started: Project: mangosd, Configuration: Release x64 ------ 4>Linking... 4>LINK : fatal error LNK1181: cannot open input file 'Detour.lib' MS VS 9

Also there is an issue in instanced maps, one can leave from group just after killing a boss and loot a chest, thereby is will not be available to raid. But in this case group recipient and recipient guids can be manually set by map script, for example to the guid of party's leader, whose member has done a killing blow. On official servers one can't loot a chest, when it is being looted by another player (if he's viewing it's contents). I guess it is simply because chest in that GO state is not clickable. Maybe there is a rule that not allows looting a chest to third person, when it has group loot in progress?