Schmoozerd

Just to note: c) is not happening, I have sources of multiple dynobjects of same caster/spell in same time I think we would know if a) happens from visual effects (multiple icons), hence my guess would be b) but for this I have no proof

IF you say that the client is wrong, then what is right, and how can you proofe?

If I am not mistaken, tempory summons are like wild summons - they have no owner

guys, provide please spell IDs or it never happened

[ code=diff] work well, yes it seems that the buff is actually applied every 5s, which is a mistake in my origininal work ... however for the question if the group is split or the chance is .5 I trust Ntsc more than other sources. Also I can confirum from my resources rather a split than .5 chance. The idea that the dmg spell also applies the buff aura seems very bad to me, and is also not supported with my resources. (the targets of the dmg spell are only the players that are hit) Also maybe this spell should target only players, but for this I need more research (note: targeting is not affecting)

http://paste2.org/p/1526564 - still existing crash related to AH (bot?) If I am not mistaken the way to reproduce is: - display a few items (ie empty search) - buyout one item (direct buyout) - let sort by some criteria

you must cd into src/bindings/ScriptDev2 to apply the ScriptDev2 patch further questions please to sd2-forums (where there are also most common questions answered in some threads)

a few notes: Extended cost is from DBC - and this often changes with client switches, so it can be possible that you won't find suitable prices for S1 in 335 dbc. For sources about correct prices I had good experiences with Atlas Loot (old versions) Also, if you really want to make this work, I think ppl would appreciate if you would post the vendor tables for the S1 vendors on some public place; maybe we can get qualitiy prices (as far as possible) from different season vendors, so any admin who wants to start a special season only needs to spawn the right vendors (I must have some prices for S5 around, which I would share) However proper place for this would be database forum, ie custom area at UDBs

you can simplify the code quite much: uint32 urand = urand(0,99) if (urand <= 45) creature_id = A; else if (urand <= 90) creature_id = B; else creature_id = C; Summon ( creature_id ..)

the problem with such threads is that they usally turn into flame threads... @topic: assesement can only be done in relation to things that you priorize and this is something very individual

I think this is caused by http://www.scriptdev2.com/project.php?issueid=1144

actually such a command can be done independendly from playerbot - and might be reasonable to provide as mod.. .gmguy report quest <link> "Broken description" and some similar things

indeed - I buyed some item, sorted multiple times, and then got this crash: http://paste2.org/p/1514638 (not perfectly clean mangos, but no changes in any related area)

If you have mangos - you surely will have git, and hence you can use git diff to get the diff If I understood you correctly: diff --git a/src/shared/Util.cpp b/src/shared/Util.cpp index 6bbdfa6..dd6fc95 100644 --- a/src/shared/Util.cpp +++ b/src/shared/Util.cpp @@ -54,16 +54,24 @@ uint32 WorldTimer::getMSTime() uint32 WorldTimer::getMSTime_internal(bool savetime /*= false*/) { - //get current time - const ACE_Time_Value currTime = ACE_OS::gettimeofday(); - //calculate time diff between two world ticks - //special case: curr_time < old_time - we suppose that our time has not ticked at all - //this should be constant value otherwise it is possible that our time can start ticking backwards until next world tick!!! uint64 diff = 0; - (currTime - g_SystemTickTime).msec(diff); + //regular case: curr_time >= old_time + if(currTime > g_SystemTickTime) + diff = (currTime - g_SystemTickTime).msec(); + + //reset last system time value + if(savetime) + g_SystemTickTime = currTime; //lets calculate current world time - uint32 iRes = uint32(diff % UI64LIT(0x00000000FFFFFFFF)); + uint32 iRes = m_iTime; + //normalize world time + const uint32 tmp = uint32(0xFFFFFFFF) - iRes; + if(tmp < diff) + iRes = diff - tmp; + else + iRes += diff; + return iRes; }

Problems are server-side spells.. @topic, see void Spell::EffectSummonObjectWild(SpellEffectIndex eff_idx) also usefull is to look into case 20474: // Lava Bomb in SpellEffects

This is currently by design not implemented (see many discussion topics about this..) If you really really need such a function, I suggest to look into the code for SPELL_EFFECT_SUMMON_GAMEOBJECT_WILD (or something similar), you need the code that is used there.

hmm, very likely that the guide is totally outdated.. MaNGOS switched to cmake long time ago (cmake replaces autoconf on *nix) - so you should try with some cmake uses, but I cannot help you further (I don't use it)

there are tons of ways to automate this - however you should only automate if you know what you are doing, don't care about dataz or use good enough backups: 1) python-scripts (exist here in forums somewhere) 2) bash/ bat scripts (I think I posted the one I use sometimes around) 3) for f in *.sql; do mysql -uUSER -pPASS DATABASE < $f; done 4) cat *.sql > help.sql and import help.sql 5) write a small tool that selects a Database and which you associate with *.sql files

as I told already in https://github.com/mangosR2/mangos/commit/15ecfefc1fc53973006fd15d13f84c13e919f6f0#commitcomment-447144 there is no spell "activate blizzard" related to sapphiron

Can GetAffectiveCaster() be NULL? (in general or in this case)

maybe bad translation, I suggest to use the command table from clean mangos instead ShowHelpForSubCommands had afaik a few changes recently, you can search the change-log, maybe ALTER TABLE db_version CHANGE COLUMN required_11503_01_mangos_spell_proc_event required_11513_09_mangos_mangos_string bit; DELETE FROM mangos_string WHERE entry IN (8); INSERT INTO mangos_string VALUES (8,'Command %s have subcommands:',NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL);

hmm why don't you use uint32 tick = GetAuraTicks()+7 % 8; and target->CastSpell(target, spellForTick[tick], true, NULL, this, casterGUID); // also you can skip the casterGUID here other things: + target->SetOrientation(angle); + target->CastSpell(target, 24820, true, NULL, this, casterGUID); + target->SetOrientation(forward); this will result in no visual orientation change, so I think this might be wrong (isn't it rather the case that he should "slowly" turn around) ? Edit: Also you can get unexpected results when the victim of the boss changes or moves (but this is another patch's problem) No, must work correct this way Other edit: there are two sets for these spells: 1-trigger aura (above) and 8 triggered spells (which are from classic times) 2-trigger auras (one with other timer!) 2-dmg spells (with other dmg- attributes) (likely from TBC-dbc)

Description of the feature? Implement spell 28560 For which repository revision was the patch created? 11662 Is there a thread in the bug report section or at lighthouse? no Who has been writing this patch? me From 33d1ae232db1678e000577fd8abf89f958a45f38 Mon Sep 17 00:00:00 2001 From: Schmoozerd <[email protected]> Date: Sun, 26 Jun 2011 12:43:00 +0200 Subject: [PATCH 2/6] Implement spell 28560 --- src/game/Spell.cpp | 1 + src/game/SpellEffects.cpp | 8 ++++++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp index 7e821ed..c57305c 100644 --- a/src/game/Spell.cpp +++ b/src/game/Spell.cpp @@ -1555,6 +1555,7 @@ void Spell::SetTargetMap(SpellEffectIndex effIndex, uint32 targetMode, UnitList& case 802: // Mutate Bug case 804: // Explode Bug case 23138: // Gate of Shazzrah + case 28560: // Summon Blizzard case 31347: // Doom TODO: exclude top threat target from target selection case 33711: // Murmur's Touch case 38794: // Murmur's Touch (h) diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index c7a56f1..d3edaf8 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -6456,6 +6456,14 @@ void Spell::EffectScriptEffect(SpellEffectIndex eff_idx) return; } + case 28560: // Summon Blizzard + { + if (!unitTarget) + return; + + m_caster->SummonCreature(16474, unitTarget->GetPositionX(), unitTarget->GetPositionY(), unitTarget->GetPositionZ(), 0.0f, TEMPSUMMON_TIMED_DESPAWN, 30000); + return; + } case 29830: // Mirren's Drinking Hat { uint32 item = 0; -- 1.7.3.1.msysgit.0

Description of the feature? Implement spell 24780 (switching target every 10s) For which repository revision was the patch created? 11662 Is there a thread in the bug report section or at lighthouse? no Who has been writing this patch? me Small Note: This spell is used with sapphiron adds (blizzard) - and they do change target every 10s, so I think it is safe to assume that is caused by this spell; according to click this spell is also used with the emerald dragons (which is likely from the naming), and there the adds should also behave this way (switching targets now and then) As the adds also change targets aside from the 10s ticker, we can assume that they also select targets by threat (ie healers) - so I think this can only work proper if the threat is dropped, too. From 2518a1713242b3889631e1fb401262742585857e Mon Sep 17 00:00:00 2001 From: Schmoozerd <[email protected]> Date: Sun, 26 Jun 2011 12:42:44 +0200 Subject: [PATCH 1/6] Implement spell 24780 --- src/game/SpellAuras.cpp | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 4d01f1b..c3555a3 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -1159,8 +1159,27 @@ void Aura::TriggerSpell() // case 24379: break; // // Happy Pet // case 24716: break; -// // Dream Fog -// case 24780: break; + case 24780: // Dream Fog + { + // Note: In 1.12 triggered spell 24781 still exists, need to script dummy effect for this spell then + // Select an unfriendly enemy in 100y range and attack it + if (target->GetTypeId() != TYPEID_UNIT) + return; + + ThreatList const& tList = target->getThreatManager().getThreatList(); + for (ThreatList::const_iterator itr = tList.begin();itr != tList.end(); ++itr) + { + Unit* pUnit = target->GetMap()->GetUnit((*itr)->getUnitGuid()); + + if (pUnit && target->getThreatManager().getThreat(pUnit)) + target->getThreatManager().modifyThreatPercent(pUnit, -100); + } + + if (Unit* pEnemy = target->SelectRandomUnfriendlyTarget(target->getVictim(), 100.0f)) + ((Creature*)target)->AI()->AttackStart(pEnemy); + + return; + } // // Cannon Prep // case 24832: break; case 24834: // Shadow Bolt Whirl -- 1.7.3.1.msysgit.0

this is (i guess) a client side restriction; however, the chat is only not allowed for the normal say or normal yell or normal text emote chat. Try to use commands in other channels, ie /g .revive