antiroot

@Dark_Oppressor, I'm 99% sure that AHBot doesn't alter the database, but the moneyTime field you referred to was added in 11391. I think the part of AHBot that adds the items needs to be fixed to handle the changes from mangos. Unfortunately the harddrive in my server died and i'm waiting for a replacement to arrive.

If someone else comes up with a patch before I can get my server back up and running i'll gladly push it to my repo

Also can I see some logs, db entries, etc so i can see exactly what and where everything seems to be messing up

Edit: also is this still happening when merged with the most current master?

There is 0 reason non-developers need git_id, it's only used when a developer pushes a commit to the git repository.

Edit: Also not sure why you would want it to auto execute? seems like that could cause more headache than benefit

Adding options for things that end-users would use makes more sense, like adding a cmake argument to build extractors from source could be useful (even though the binaries are already included) giving the user the choice of having all their tools the way they want (shared/static/optimized/debug/release/etc) but using a standard way of customizing these things would cut back on the headache of people not knowing exactly how to compile/use the end-user tools

If what I listed is already in there, my apologies, I did not see it when I looked at the source

Lots of really good points on both sides of this argument, only thing i can say that other software will do on error is return a numeric error id

for example

mysql> SELECT * FROM no_such_table

ERROR 1146 (42S02): Table 'test.no_such_table' doesn't exist

I think numeric error codes would be useful, as long as anyone who posted an error included the error code the language wouldn't matter since 1146 in English still means 1146 in French (a wiki page could have the appropriate translations of the error description)

but like DasBlub stated if multiple translations are running around it will be harder to "link" the errors to other forum threads, even if you translate a non-English error to English using google translate it won't be 100% the same as the original in most cases

.unaura 45033

its in your characters.character_aura database, you just have to look up the character guid

oh wow thanks, had no idea it was something that massive. I wanted to do something similar for a private git repo I have. I think i can learn a lot from that, don't need a lot of the fancy stuff like the sql parts

was about to ask how it is used and then read

Usage: git_id [OPTION]

Generates a new rev number and updates revision_nr.h and the commit message.

Should be used just before push.

thanks again lynx3d, this can be closed since it answered everything i asked

I was wondering how the revision number used in mangos commit logs was handled. This is really mangos specific, but mangos is one of the few projects I've seen that do this

Specifically how does src/shared/revision_nr.h get updated when a dev pushes a commit and how does the commit message get the [12345] prefix, is this automated through a hook or do they manually change it each time.

just something I was curious about, since I'm pretty sure git couldn't do that on its own by default

It takes some time for everything to show after it has first rebuilt the list of items to add to auction

Edit: I don't alter my new_ahbot branch other than merge conflicts, but I have removed that option from my other branch new_ahbot_finetune

Ok i've pushed your changes to my repro, and the repro is at mangos rev 11395.. thanks again for the patch, i don't know how soon i would have been able to get to that

thanks Jethrogibbs, i'm testing your suggested patch now. I'll update my repro once all the conflicts are resolved

Sorry to anyone using my repro, had issues at work with the recent storms. suffered electrical and flood damage, but I will try to have my repro updated by the end of the day

as far as how it starts a character, i believe it is just like any other character except the core has some special DK specific code that causes them to not receive their talent points the normal way for their first 55 levels (which are granted as quest rewards)

for the stuff that doesn't work (grand theft palomino) for example depends on vehicles which don't work not because data can't be extracted, but because support for vehicles has been finished in the mangos core yet

can you specify exactly what you think is not working, i think that would help everyone get on the same page and then provide you with a better answer

scriptdev's DB connection info is in scriptdev2.conf, but the access/privileges Cartman87 mentioned must be done from within your mysql server (phpmyadmin or mysql CLI)

The file scriptdev2_create_database.sql should have already done this tho, so i would just make sure you have the correct password in scriptdev2.conf

never had an issue with ad.exe and wotlk, but until vehicles and some spells are fully implemented DKs are very unusable and their starting zone can not be finished without using an admin to force complete many things

@younguns, Oh now your post makes perfect sense I was going through all the more recent patches trying to find one with popups, should have known you were talking about the outdated patch hosted on mediafire

I'll post a patch file from my repro soon if i can find a good host

EDIT: on side note i created a branch called new_ahbot_fixes that has some minor fixes to the original cyberium branch like fixing some default conf values, fixing item skill rank checks

https://github.com/antiroot/mangos/tree/new_ahbot

GIT URL: git://github.com/antiroot/mangos.git

I created a repository with a new_ahbot branch. The branch is pulled from cyberium's repository and merged with current mangos/master with conflict resolved. Other than the merge conflict fixes I do not plan to alter the branch from the way it is at cyberium's repo.

At first I thought multiple repos of the same thing was a bad idea (actually i still think it is) but I wanted to learn to use github (since mangos is meant for learning)

I'll make another branch later that has some of my fine tuning tweaks but it is separate from the current ahbot that is under review so any questions or ideas for tweaks should not clutter this thread and go into their own somewhere else

I agree with lillecarl, I don't see how a computer could accurately determine if 2 users are multiboxing, even with all the above suggestions

for example a hypothetical scenario, a college campus has a massive LAN for students in campus housing. Lets say 20-50 of these students connect to a mangos server through the WAN they would all appear to be the same machine and since they are students from the same college we could assume that they know each other and would more likely form groups/parties/guilds on mangos making a programmable/dynamic detection very difficult

The above scenario is completely hypothetical and not a real life scenario.

I completely agree, my additions that i mentioned i did not intend for those to go into the ahbot repository, only for other users to custom fine tune their own version of ahbot.. I only mentioned it here because it was asked, if people are interested though, somebody could make a separate thread with Core Modifications (patches) for ahbot that way these discussions and code would stay away from the actual ahbot that is under review (maybe a good idea, maybe not.. but just an idea)

Bind on Pickups are disabled by default

so are quest items and lockboxes

I've created additional filters for my local repository that include

Mount.ReqLevel

Mount.ReqSkill

Glyph.ReqLevel

TradeGood.ItemLevel

Container.ItemLevel

If anyone is interested I can post the patch file, need to add some comments for it to be more helpful to others before i post it

I'll work on making a filter that will exclude specific item IDs sometime this weekend, I'll make it to work like the vmap.ignoreSpellIds option in mangos.conf, I think that would be the best way to filter out these specific items

I've mentioned this before but there are some items that contain the text like DND or zzOld in their names and they should be excluded as well, but a more dynamic approach should probably be taken for those

This is a database (UDB) question not mangos.

but to give you a quick answer this is the way it is intended to be, all the maps do have lots of ore, they are just grouped into spawn pools and only a few objects are spawned at a time. spawn pools allow only a few objects to be spawned and then at respawn a randomly selected new object is spawned

There is a much more detailed explanation at udb forums

glad to know you found it,

just remember more important than backing up the executable is to backup the database as MCP,Ambal and I have said, without your database if something doesn't go right then you will have to start over from scratch again and will loose any custom data along with account/player data

sorry rumpilstilskin, I've never installed mangos on windows before so i'm not sure where it would go by default or where any of the current guides would tell you to install it to

I looked at some of your previous posts and it looks like you installed mangos at C:\\Mangos\\

and you compiled mangos to C:\\Mangos\\bin\\Win32_Release

I think if you backup the Win32_Release folder that should be enough.

i'm assuming that folder contains all the dll, exe, and conf files, if not you'll need to find those to have a complete backup

not sure where your vmap/dbc files are but those shouldn't matter since the mangos core does not alter them and they usually only change with a client update

when you say core 393, this is not actually the core, but the database

the core is all the mangos code you downloaded from git and compiled

just for clarification

what i do before updating both my core (the server) and my database (characters/world objects/etc) is make a backup of the folder containing the executables/libraries/configurations/etc, a simple copy will do this

to backup my database i use mysqldump and just export the entire database in a sql format text file

mysqldump -umangos -pYOUR_MANGOS_MYSQL_PASSWORD --databases mangos realmd characters scriptdev2 > database_backup_20110322.sql

for an example of how i use mysqldump

after this i download the new mangos source from git, then compile

download database of your choice, execute the databases sql updates (if it has them)

then execute the mangos provided sql updates to get the database to the required version for the core

i didn't go into detail on most of this because there are guides that do that fairly well and this is intended to be a summary of how i do it

You could also check if your router has an option called NAT Redirection or NAT Reflection (same thing just 2 different names)

basically redirection allows your internal LAN clients to access your port forwarded services via your router's WAN interface (ie: your public IP / domain name) without the need of editing the host files

Most routers i've seen have this feature, and a few will have it but it will be disabled. but there are still some that just completely don't support it and you will have to edit the host file as faramir118 stated

I prefer not to use root to do my mangos stuff, i did the following so only the mangos user was needed and so that mysql configs didn't need to be changed

mysql> GRANT SUPER ON *.* TO 'mangos'@'localhost';

and edited 11217_01_mangos_creature_addon.sql with this

diff --git a/sql/updates/11217_01_mangos_creature_addon.sql b/sql/updates/11217_01_mangos_creature_addon.sql
index cf00588..0256b3e 100644
--- a/sql/updates/11217_01_mangos_creature_addon.sql
+++ b/sql/updates/11217_01_mangos_creature_addon.sql
@@ -8,6 +8,8 @@ DELIMITER %%

CREATE FUNCTION `ConvertAuras`(`auras` varchar(1024))
RETURNS varchar(1024) CHARSET utf8
+DETERMINISTIC
+READS SQL DATA
BEGIN
  DECLARE tmp VARCHAR(1024);
  DECLARE curr VARCHAR(10);

seems to have worked for me since the creature_addon table reflected the correct changes afterward

plus i don't like having to turn things on in off in mysql to make something work with it, only downside is that it gives mangos SUPER globally, which i revoke after updating the db

should be possible, I take snapshots of my database before doing updates / core modifications and i've always be able to revert to them

of course if you copy the database to a server with a newer core you'll want to make sure to apply the sql updates to get it up to date

I've edited both files on my server while running then used the appropriate commands to reload the conf files without any issues. of course depending on what your editing in your conf this could cause a crash i assume, for example if you change the mysql user or the listening port number and then reload something unexpected may happen

all server side player data is stored in the database characters, however it isn't instant meaning a player save call has to be done to store the data from memory to the db, this happens at timed intervals, when the player logs out, or when the .save or .saveall command is used there may be other cases where players are saved, but i'm not sure at the moment