Ambal

Hi, boyz and girlz Today I want to preset another performance optimization patch. I want to thank freghar for his huge help with changes for *nix systems We will use an opensource version of Intel Threading Building Blocks library, version 2.2 :rolleyes: We need custom memory management, especially on Windows systems, since OS specific ones sometimes: 1) have low performance; 2) doesn't scale in multi-threaded environments. For example, why Windows server performance can be sooo bad? Because Windows Server 2003 has ~2.5 mln memory ops/sec and Windows Server 2008 ~9.5 mln ops/sec. This is no match to Intel Memory Allocator with performance about 31(!) mln ops/sec. Each user on MaNGOS each second spawns 2500 memory ops so you can guess the maximum online on Windows Server 2003 Performance gains can differ greately through platforms used: experience from minimum +10% of performance gains on some FreeBSD platforms to +30% on Windows ones. P.S. You should copy into your MaNGOS server binary directories 2 dlls: tbb(_debug).dll and tbbmalloc(_debug).dll under Windoz. Under *nix just copy tbb.so and tbbmalloc.so Repo on github: http://github.com/Ambal/mangos Branch for 3.1.3 server: master Branch for 3.2.2 server: rebase_branch

Well, with some custom patches my friends had 4.5k+ ppl online on their Quad Xeon, 16 GB RAM server w/o VMAPS So yeah, we have a progress in performance tuning, just need time to make patches production-ready

Nice patch, but 2 notes: 1) place ASSERT(m_map) in GetMap() method to check whether you are trying to access NULL pointer - we need strict logic 2) be sure that your m_map is always valid from assigning pointer until BattleGround object destruction - FindMap() was used to protect code from incorrect usage. 3) Maybe it is even better to pass Map object reference to BattleGround constructor and use Map& BattleGround::m_map

In [8559]. Tnx

In [8556]. Thanks alot P.S. Somebody stop this crazy dude!

In repo Just forgot to add commit number once again

In [8545]. Tnx

In [8544]. Thanks

In [8543]. Thanks alot

Thanks, qsa. In [8541]

Please, provide a patch

Applied in [8535]. Tnx

I added error output in [8534] like you wanted, qsa. Have fun

wooohooo, thats incredible movie, thanks alot!

Applied in [8532]. Thanks

Patch suggested by Maxxie applied in [8530]. Wojta, get a cookie for yourself )) Thanks boyz

Applied in [8529]. Thanks

PM me a patch with error output, I'll try to make smtn with it

Applied in [8528]. Thanks

Patch was ported to 0.12. Thanks to leak and crashuncle for their help with 0.12 branch

Patch applied in [8524] <- small lol with git Thanks everyone involved in tests. Don't forget to update your config files Thanks, leak, will take a look into your job since patch will get applied to 0.12 too

Ok, I suggest everyone interested to test patch more intensively. I have to be sure that you don't have any performance/stability issues with this patch on recent revisions before applying it to GIT. Check if MAX_NUMBER_OF_CELLS 16 doesn't degrade stability of your servers. If it really does and hurts very badly then patch will be applied with MAX_NUMBER_OF_CELLS 8 for further investigation. P.S. And thanks to crashuncle patch will get backported to 0.12 after I check changes on correctness

Could you provide through paste2.org those code places +/- 30 LOCs where you have errors? So I can tell how to make proper changes

crashuncle, please post those compile errors you get with 0.12 branch. There shouldn't be anything difficult to solve them.

Updated a patch to latest 8489+ rev. Also a bug with same visibility distance in dungeons/BG/Arenas as on continents got fixed Check differences in constructor' code of classes Map::Map(), InstanceMap::InstanceMap() и BattleGroundMap::BattleGroundMap().