ascent

move up! anyone have new patch?

anyone make patch file?

vmaps are not related to movement

so, get through the wall is not work, or working?

I said to "prevent" crash, just for safe

your care is good, but,

And this will most wrong way from possible.

Remember simple thing: never never add new includes to .h file if you not 100% sure that this correct and will not add unexpected results.

In C/C++ very easy get cyclic header dependences with very unclear error messages.

Alswasy instead if possible use forward class/structure declarations.

rev 10421
sd2

1. Serpent Sting,Scorpid Sting can use many target.

but originally is only 1 target, on spell( two spell not overlap, but this can.)

2. Lock and Load not work.

3. Hunter's Mark bonus damege not work?(i'm not sure)

4. T.N.T. not work.

vmap is problem.

visual is ok.

but, creature is get through the wall.

and fly(no fly creature). gravity ignore.

Are your VMAPS activated?

Is the "indoor/outdoor check" option activated?

Where did you do your check?

oh, my mistake i'm sorry ^^

config is "1" ?

rev 10421
sd2

enter building, auto dismount is not work.

anyone have patch?

This fix

+    if (m_unitTarget && m_unitTargetGUID != caster->GetObjectGuid() &&
+        !m_unitTarget->isVisibleForOrDetect(caster, caster, false))
+            m_unitTarget = NULL;

where is input this code?

I've follow your reflexion ifilgud, and yes it's works

here my patch for 0.12 -> https://gist.github.com/10ccec53138076439c97

thx, ^^ good work.

rev10421
sd2

trap is 2, my knowledge only 1 trap.

but can 2 trap.

ex) spawn frost trap and Immolation Trap. possible 2 spawn trap.

and

Disengage.

Disengage is only combat time.

but no combat can use Disengage.

Unit.h

-               #include "map.h"
-               Unit *GetMisdirectionTarget() { return m_misdirectionTargetGUID ? GetUnit(*this, m_misdirectionTargetGUID) : NULL; }
+              Unit *GetMisdirectionTarget() { return m_misdirectionTargetGUID ? GetMap()->GetUnit(m_misdirectionTargetGUID) : NULL; }

first post add ^^;;

I have merge the patch from Toinan67 and ascent to a useable patch with

I have test and it works great

The patchfile: http://paste2.org/p/968584

Enjoy

In my testing the player have not the 4 or 6 sec buff

hm.. really??? i have 4~6 sec buff.

where is a part for unapply? this is a bug which can produce boss and mobs freeze

use my patch? don't have bug

Edit : I'm blind ^^

work perfect ^^;;

And this will most wrong way from possible.

Remember simple thing: never never add new includes to .h file if you not 100% sure that this correct and will not add unexpected results.

In C/C++ very easy get cyclic header dependences with very unclear error messages.

Alswasy instead if possible use forward class/structure declarations.

copy that ^^;;

thx ur advice

[fix]

unit.h

#include "map.h"

^^ yes, i will try

You should write this

Unit *GetMisdirectionTarget() { return ( m_misdirectionTargetGUID && IsInWorld() ) ? GetMap()->GetUnit(m_misdirectionTargetGUID) : NULL; }

and add a new include

#include "Map.h"

thx, change first post.

sure, but i think this patch have some mistake. anyone help

Unit *GetMisdirectionTarget() { return m_misdirectionTargetGUID ? GetUnit(*this, m_misdirectionTargetGUID) : NULL; }

this bug fix.

this patch make july 21.

so change some code. but i don't know so, help us.

Description of the feature?

none

For which repository revision was the patch created?

10409

Is there a thread in the bug report section or at lighthouse?

Spell.h

         void EffectTitanGrip(SpellEffectIndex eff_idx);
         void EffectEnchantItemPrismatic(SpellEffectIndex eff_idx);
         void EffectPlayMusic(SpellEffectIndex eff_idx); 
+         void EffectRedirectThreat(SpellEffectIndex eff_idx);
         void EffectSpecCount(SpellEffectIndex eff_idx);
         void EffectActivateSpec(SpellEffectIndex eff_idx);

SpellAuras.cpp

                   return;
            }

+             case 34477: //Misdirection    
+             case 57934: //Tricks of Trade    
+             {    
+                 if(Unit * caster = GetCaster())    
+                     caster->SetThreatRedirectionTarget(0, 0);    
+                 return;    
+             }    
            case 58600:                                     // Restricted Flight Area    
            {    
                AreaTableEntry const* area = GetAreaEntryByAreaID(target->GetAreaId());

SpellEffects.cpp

    &Spell::EffectProspecting,                              //127 SPELL_EFFECT_PROSPECTING Prospecting spell    
    &Spell::EffectApplyAreaAura,                            //128 SPELL_EFFECT_APPLY_AREA_AURA_FRIEND
    &Spell::EffectApplyAreaAura,                            //129 SPELL_EFFECT_APPLY_AREA_AURA_ENEMY     
-    &Spell::EffectNULL,                                     //130 SPELL_EFFECT_REDIRECT_THREAT    
+    &Spell::EffectRedirectThreat,                           //130 SPELL_EFFECT_REDIRECT_THREAT    
    &Spell::EffectUnused,                                   //131 SPELL_EFFECT_131                      used in some test spells    
    &Spell::EffectPlayMusic,                                //132 SPELL_EFFECT_PLAY_MUSIC               sound id in misc value (SoundEntries.dbc)    
    &Spell::EffectUnlearnSpecialization,                    //133 SPELL_EFFECT_UNLEARN_SPECIALIZATION   unlearn profession specialization
...    ...    
@@ -8348,6 +8348,17 @@ void Spell::EffectRestoreItemCharges( SpellEffectIndex eff_idx )    
    item->RestoreCharges();    
}    

+void Spell::EffectRedirectThreat(SpellEffectIndex eff_idx)    
+{    
+    if(unitTarget)    
+    {    
+        m_caster->SetThreatRedirectionTarget(unitTarget->GetGUID(), (uint32)damage);    
+    
+        // Tricks of trade hacky buff applying (15% damage increase)    
+        if( m_spellInfo->Id == 57934 )    
+            unitTarget->CastSpell(unitTarget, 57933, true);    
+    }    
+}    
void Spell::EffectTeachTaxiNode( SpellEffectIndex eff_idx )    
{    
    if (unitTarget->GetTypeId() != TYPEID_PLAYER)

SpellMgr.cpp

            if( spellInfo_1->SpellIconID == 2285 && spellInfo_2->SpellIconID == 2285 )    
                return false;    

+            //Tricks of Trade
+            if( spellInfo_1->SpellIconID == 3413 && spellInfo_2->SpellIconID == 3413 )
+                return false;
+    
            // Garrote -> Garrote-Silence (multi-family check)
            if( spellInfo_1->SpellIconID == 498 && spellInfo_2->SpellIconID == 498 && spellInfo_2->SpellVisual[0] == 0 )
                return false;

ThreatManager.cpp

    float threat = ThreatCalcHelper::calcThreat(pVictim, iOwner, pThreat, crit, schoolMask, pThreatSpell);    

+    if( pVictim->GetThreatRedirectionPercent() && threat > 0.0f )    
+    {    
+        float redirectedThreat = threat * pVictim->GetThreatRedirectionPercent() / 100;    
+        threat -= redirectedThreat;    
+        if(Unit *unit = pVictim->GetMisdirectionTarget())    
+            iThreatContainer.addThreat(unit, redirectedThreat);    
+    }    
+    
    HostileReference* ref = iThreatContainer.addThreat(pVictim, threat);    
    // Ref is online    
    if (ref)

Unit.cpp

    m_charmInfo = NULL;    

+    m_ThreatRedirectionPercent = 0;
+    m_misdirectionTargetGUID = 0;
+    
    // remove aurastates allowing special moves
    for(int i=0; i < MAX_REACTIVE; ++i)    
        m_reactiveTimer[i] = 0;

Unit.h

        void AddPetAura(PetAura const* petSpell);    
        void RemovePetAura(PetAura const* petSpell);

+        void SetThreatRedirectionTarget(uint64 guid, uint32 pct)    
+        {
+            m_misdirectionTargetGUID = guid;    
+            m_ThreatRedirectionPercent = pct;    
+        }    
+        uint32 GetThreatRedirectionPercent() { return m_ThreatRedirectionPercent; }
+        Unit *GetMisdirectionTarget() { return m_misdirectionTargetGUID ? GetMap()->GetUnit(m_misdirectionTargetGUID) : NULL; }    
+    
        // Movement info    
        MovementInfo m_movementInfo;    

...    ...    
@@ -1971,6 +1979,8 @@ class MANGOS_DLL_SPEC Unit : public WorldObject    
        ComboPointHolderSet m_ComboPointHolders;

        GuardianPetList m_guardianPets;
+        uint32 m_ThreatRedirectionPercent;    
+        uint64 m_misdirectionTargetGUID;

        uint64 m_TotemSlot[MAX_TOTEM_SLOT];    
};

good luck

REV 10409
SD2

for unit.h

Unit *GetMisdirectionTarget() { return m_misdirectionTargetGUID ? GetMap()->GetUnit(m_misdirectionTargetGUID) : NULL; }

Error

6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Unit.h (1921): error C2027: undefined type 'Map' and (a) was used. 
6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Object.h (73): 'Map' to see the declaration. 
6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Unit.h (1921): error C2227: '-> GetUnit' left the class / struct / union / generic type point must. 
6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Unit.h (1921): error C2027: undefined type 'Map' and (a) was used. 
6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Object.h (73): 'Map' to see the declaration. 
6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Unit.h (1921): error C2227: '-> GetUnit' left the class / struct / union / generic type point must. 
6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Unit.h (1921): error C2027: undefined type 'Map' and (a) was used. 
6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Object.h (73): 'Map' to see the declaration. 
6> c: \\ users \\ administrator \\ desktop \\ server \\ saekoeo \\ mangos \\ src \\ game \\ Unit.h (1921): error C2227: '-> GetUnit' left the class / struct / union / generic type point must.

how can fix? that? so what do i change?

re 10410 still bug,

REV 10408
SD2

skill is broken. how can fix??

I think your screen shot is delete;..

rev 10408
sd2

no combat is ok, but combat start is skill is pack up, don't have hide aura.

combat start - > can't cast Hide skill.

ex) Sap, hide bla~