bobaz

What bug does the patch fix? What features does the patch add? Patch will correct amount of mana energized by Innervate and implement effect of Glyph of Innervate For which repository revision was the patch created? 8587+ Patch was written for 3.1.3 client, but all variables are dbc related, so it should work on 3.2.2a revisions. Who has been writing this patch? Please include either forum user names or email addresses. Me - Dr Bobaz Patch: file:src/game/SpellAuras.cpp @@ -4399,16 +4399,30 @@ void Aura::HandlePeriodicEnergize(bool apply, bool Real) { if (!Real) return; m_isPeriodic = apply; - - // Replenishment (0.25% from max) - // Infinite Replenishment - if (GetId() == 57669 || - GetId() == 61782) - m_modifier.m_amount = m_target->GetMaxPower(POWER_MANA) * 25 / 10000; + switch (m_spellProto->Id) + { + case 57669: // Replenishment (0.25% from max) + case 61782: // Infinite Replenishment + { + m_modifier.m_amount = m_target->GetMaxPower(POWER_MANA) * 25 / 10000; + return; + } + case 29166: //Innervate (value% of base mana) + case 54833: //Glyph of Innervate (+value% of casters base mana for caster) + { + Unit* caster = GetCaster(); + m_modifier.m_amount = (caster->GetCreateMana() * (GetSpellProto()->EffectBasePoints[0]+1) / 100) / (m_maxduration/1000); + if (m_spellProto->Id == 29166 && caster->HasAura(54832) && m_target->HasAura(29166)) + caster->CastSpell(caster,54833,true,0,0,caster->GetGUID()); + return; + } + default: + break; + } } void Aura::HandleAuraPowerBurn(bool apply, bool /*Real*/) { m_isPeriodic = apply;

since in mangos core there is already coding for nourish heal boost, to make it work you need only to add to your spell_learn_spell table a row: insert into `spell_learn_spell` (`entry`, `SpellID`, `Active`) values('50464','60137','0'); And reload table. I'm using mangos build 8587 for 3.1.3 client, so I don't know if this problem was solved in further builds. If the problem still occures, formal patch app: What bug does the patch fix? What features does the patch add? Enables already implemented Nourish Heal Boost. For which repository revision was the patch created? 8587 Patch: insert into `spell_learn_spell` (`entry`, `SpellID`, `Active`) values('50464','60137','0');

Thank you, thenecromancer, for the comment and suggestion. Honestly, I even didn't think about that method you suggested. I somehow imagined that it would be impossible, and just your post made me aware that it is good solution. So, I re-post that patch. What bug does the patch fix? What features does the patch add? Disables druid cat form Dash ability when not in cat form For which repository revision was the patch created? 8480+ Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. The bug is reported on getmangos.eu: here, here, and here. Who has been writing this patch? Please include either forum user names or email addresses. Me - Dr Bobaz Patch: SpellAuras.cpp: @@ -3013,13 +3013,14 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) break; } } // adding/removing linked auras + //update speed to enable/disable dash modifier + m_target->UpdateSpeed(MOVE_RUN, true); // add/remove the shapeshift aura's boosts HandleShapeshiftBoosts(apply); - if(m_target->GetTypeId() == TYPEID_PLAYER) ((Player*)m_target)->InitDataForForm(); } void Aura::HandleAuraTransform(bool apply, bool Real) and Unit.cpp: @@ -9716,10 +9716,27 @@ void Unit::UpdateSpeed(UnitMoveType mtype, bool forced) { int32 main_speed_mod = 0; float stack_bonus = 1.0f; float non_stack_bonus = 1.0f; + //dash check + if(getClass() == CLASS_DRUID && mtype == MOVE_RUN) + { + AuraList const& mSpeed = GetAurasByType(SPELL_AURA_MOD_INCREASE_SPEED); + for(AuraList::const_iterator i = mSpeed.begin(); i != mSpeed.end(); ++i) + { + if ((*i)->GetSpellProto()->SpellFamilyName == SPELLFAMILY_DRUID && (*i)->GetSpellProto()->SpellIconID == 959) + { + if(m_form != FORM_CAT) + (*i)->SetModifier((*i)->GetModifier()->m_auraname, 0, (*i)->GetModifier()->periodictime, (*i)->GetModifier()->m_miscvalue); + else + (*i)->SetModifier((*i)->GetModifier()->m_auraname, ((*i)->GetSpellProto()->EffectBasePoints[0]+1), (*i)->GetModifier()->periodictime, (*i)->GetModifier()->m_miscvalue); + } + } + } + //dash check end + switch(mtype) { case MOVE_WALK: return; case MOVE_RUN: as before, I don't know why in highlight every [ and ] are represented by its symbols. it should be: EffectBasePoints[0]+1

This one won't work, if you have other aura that increases speed. For example, if you use Dash level 3, which increases speed by 70% and feral build with feral swiftness talent (increases speed by 30% while in cat form), after removing dash, your speed will be 170-70=100% instead of 130%. And that whill be every time, when caster has an other aura that increases run speed. So, it is a bug, and not work fine. My patch instead, works fine in that matter. If dash is the highest speed modification aura, it takes the second in line highest speed modification aura, and if dash isn't the highest - it does nothing, as it should be.

I'm waiting for opinions which of the implementations is better or maybe a suggestion of a better one, but patch in my first post is actually working. Just choose one of the Unit.cpp modifications and test it.

What bug does the patch fix? What features does the patch add? It fixes the effect of Glyph of the Penguin. For which repository revision was the patch created? 8480+ Who has been writing this patch? Please include either forum user names or email addresses. Me - Dr Bobaz Patch: @@ -3026,12 +3026,17 @@ void Aura::HandleAuraTransform(bool apply, bool Real) m_target->SetDisplayId(16358); sLog.outError("Auras: unknown creature id = %d (only need its modelid) Form Spell Aura Transform in Spell ID = %d", m_modifier.m_miscvalue, GetId()); } else { - // Will use the default model here - m_target->SetDisplayId(ci->DisplayID_A[0]); + Unit* caster = GetCaster(); + if((caster) && ((caster->HasAura(52648)) && (GetSpellProto()->SpellIconID == 82))) + // Glyph of the Penguin + m_target->SetDisplayId(24698); + else + // Will use the default model here + m_target->SetDisplayId(ci->DisplayID_A[0]); // Dragonmaw Illusion (set mount model also) if(GetId()==42016 && m_target->GetMountID() && !m_target->GetAurasByType(SPELL_AURA_MOD_INCREASE_FLIGHT_SPEED).empty()) m_target->SetUInt32Value(UNIT_FIELD_MOUNTDISPLAYID,16314); } EDIT: I don't understand why highlight changes [0] to symbols, but it in both cases should be "m_target->SetDisplayId(ci->DisplayID_A[0]);" at the line.

It may be a silly question, but I cannot manage it. I'm trying to enable a possibility to use DK/NPC skins for non DK classes either in creation screen or in game by editing current skin. I tried to change or even copy PLAYER_BYTES field, but the effect of DK skin is non-permanent, and after a shapeshift or sth like this is disabled. I know that some time in past there was such a possibility. Can somebody help me with it?

May I ask how advanced is implementation of Raise Dead spell? I try to do it myself, but i'm stuck with a corpse problem (can't figure out how to check if there is any corpse) and - there is a problem with cooldown. Raise Dead spell is only one-time-usable. One time per login. And I can't figure it out either. Mayby somebody could paste here Astellar's findings/patch of it?

Is this patch on mangos master git branch already? 8064 and 8065 as well?

What bug does the patch fix? What features does the patch add? Fixes problem with Summon Water Elemental spell. Now, the spell should be working. I hope, last and final version of it . For which repository revision was the patch created? 8044+ Who has been writing this patch? Please include either forum user names or email addresses. Me - Dr Bobaz, thanks to Ike3(for Summon Water Elemental type), Skirnir (for the method) and laise (for advice) file src/game/ShardedDefines.h @@ -2372,10 +2372,11 @@ enum SummonType SUMMON_TYPE_CRITTER3 = 307, SUMMON_TYPE_UNKNOWN5 = 409, SUMMON_TYPE_UNKNOWN2 = 427, SUMMON_TYPE_POSESSED2 = 428, SUMMON_TYPE_GUARDIAN2 = 1161, + SUMMON_TYPE_ELEMENTAL = 1561, SUMMON_TYPE_FORCE_OF_NATURE = 1562 }; enum ResponseCodes { file src/game/Spell.cpp @@ -4229,10 +4229,11 @@ SpellCastResult Spell::CheckCast(bool strict) switch(m_spellInfo->EffectMiscValueB[i]) { case SUMMON_TYPE_POSESSED: case SUMMON_TYPE_POSESSED2: case SUMMON_TYPE_DEMON: + case SUMMON_TYPE_ELEMENTAL: case SUMMON_TYPE_SUMMON: { if(m_caster->GetPetGUID()) return SPELL_FAILED_ALREADY_HAVE_SUMMON; file src/game/SpellEffects.cpp @@ -3178,10 +3178,11 @@ void Spell::EffectSummonType(uint32 i) break; case SUMMON_TYPE_DEMON: EffectSummonDemon(i); break; case SUMMON_TYPE_SUMMON: + case SUMMON_TYPE_ELEMENTAL: EffectSummon(i); break; case SUMMON_TYPE_CRITTER: case SUMMON_TYPE_CRITTER2: case SUMMON_TYPE_CRITTER3:

yes. You're right. So, here's a bigger patch, well it sounds little like a hack, but if you want player's Summon Water Elemental working, and NPC's spells using "67" it should solve the problem: What bug does the patch fix? What features does the patch add? Fixes problem with Summon Water Elemental spell. Now, the spell should be working. For which repository revision was the patch created? 8044+ Who has been writing this patch? Please include either forum user names or email addresses. Me - Dr Bobaz, thanks to Ike3(for Summon Water Elemental type), Skirnir (for the method) and laise (for advice) file src/game/ShardedDefines.h @@ -2358,11 +2358,12 @@ enum SummonType SUMMON_TYPE_GUARDIAN = 61, SUMMON_TYPE_TOTEM_SLOT1 = 63, SUMMON_TYPE_WILD = 64, SUMMON_TYPE_POSESSED = 65, SUMMON_TYPE_DEMON = 66, SUMMON_TYPE_SUMMON = 67, + SUMMON_TYPE_SUMMON2 = 1561, SUMMON_TYPE_TOTEM_SLOT2 = 81, SUMMON_TYPE_TOTEM_SLOT3 = 82, SUMMON_TYPE_TOTEM_SLOT4 = 83, SUMMON_TYPE_TOTEM = 121, SUMMON_TYPE_UNKNOWN3 = 181, file src/game/spell.cpp @@ -4229,11 +4229,12 @@ SpellCastResult Spell::CheckCast(bool strict) switch(m_spellInfo->EffectMiscValueB[i]) { case SUMMON_TYPE_POSESSED: case SUMMON_TYPE_POSESSED2: case SUMMON_TYPE_DEMON: case SUMMON_TYPE_SUMMON: + case SUMMON_TYPE_SUMMON2: { if(m_caster->GetPetGUID()) return SPELL_FAILED_ALREADY_HAVE_SUMMON; if(m_caster->GetCharmGUID()) file src/game/SpellEffects.cpp @@ -3210,10 +3210,11 @@ void Spell::EffectSummonType(uint32 i) break; case SUMMON_TYPE_DEMON: EffectSummonDemon(i); break; case SUMMON_TYPE_SUMMON: + case SUMMON_TYPE_SUMMON2: EffectSummon(i); break; case SUMMON_TYPE_CRITTER: case SUMMON_TYPE_CRITTER2: case SUMMON_TYPE_CRITTER3: Edit to match laise suggestions

What bug does the patch fix? What features does the patch add? Fixes problem with Summon Water Elemental spell. Now, the spell should be working. For which repository revision was the patch created? 8044+ Who has been writing this patch? Please include either forum user names or email addresses. Me - Dr Bobaz, thanks to Ike3 and Skirnir diff --git a/src/game/SharedDefines.h b/src/game/SharedDefines.h index f07ec80..8392167 100644 --- a/src/game/SharedDefines.h +++ b/src/game/SharedDefines.h @@ -2373,7 +2373,7 @@ enum SummonType SUMMON_TYPE_WILD = 64, SUMMON_TYPE_POSESSED = 65, SUMMON_TYPE_DEMON = 66, - SUMMON_TYPE_SUMMON = 67, + SUMMON_TYPE_SUMMON = 1561, SUMMON_TYPE_TOTEM_SLOT2 = 81, It's accualy Skirnir's diff, I just changed it for Summon Water Elemental spell. Just for notice.

What bug does the patch fix? What features does the patch add? Fixes problem with drinking assosiated mana regeneration spells, added in WotLK - they didn't work after switch to 3.1.3 client. For which repository revision was the patch created? 8028+ Who has been writing this patch? Please include either forum user names or email addresses. Me - Dr Bobaz --------------------------- src/game/SpellAuras.cpp --------------------------- index 3c01c22..4437d09 100644 @@ -6224,6 +6227,8 @@ void Aura::PeriodicDummyTick() case 43706: case 46755: case 49472: // Drink Coffee + case 43182: + case 43183: + case 57073: case 61830: { if (m_target->GetTypeId() != TYPEID_PLAYER)

What bug does the patch fix? What features does the patch add? It adds Lifebloom mana return effect, after final heal of Lifebloom. For which repository revision was the patch created? 8028+ Who has been writing this patch? Please include either forum user names or email addresses. Me - Dr Bobaz, and The Nosfu --------------------------- src/game/SpellAuras.cpp --------------------------- index 3c01c22..4437d09 100644 @@ -2375,6 +2375,9 @@ void Aura::HandleAuraDummy(bool apply, bool Real) { int32 amount = m_modifier.m_amount / m_stackAmount; m_target->CastCustomSpell(m_target, 33778, &amount, NULL, NULL, true, NULL, this, GetCasterGUID()); + + int32 returnmana = (GetSpellProto()->ManaCostPercentage * caster->GetCreateMana() / 100) * m_stackAmount / 2; + caster->CastCustomSpell(caster, 64372, &returnmana, NULL, NULL, true, NULL, this, GetCasterGUID()); } } return;