Ceris

Valgrintor: You probably misunderstand what this spell is supposed to do This spell will do one of two things, depending on targets permanent immunity to stuns. If target is permanently immune to stuns (bosses and some high lvl elite mobs), then this spell should only deal damage to target. If target is not permanently immune to stun, then this spell should only stun the target, instead of dealing any damage. This spell shouldnt stun target and deal damage at the same time to one target.

what is your core and post "how to reproduce" part, because Deep Freeze shouldnt deal any damage in PvP. Deep Freeze should only deal damage to mobs permanently immune to stuns (only some bosses)

mana should be regenerated only when you are not casting, unless you have talents for this. With talents, some small part of mana regeneration should continue even if you are casting

I can confirm this, there is something wrong with raid groups, like you are always shown as you are in raid group 2, even if you are in completelly different raid group.

ghostly strike and hemorrhage is always performed with main hand weapon, so checking weapon used for attack means checking main hand weapon only but what laise means is that what multiplier for damage is used on retail, when rogue has for example sword in main hand and dagger in off hand. If multiplier for daggers will be used even if dagger is not used for this attack but is present in offhand. According to my information from retail, this bonus is applied only if rogue has dagger in hand, with which he performs attack (main hand) and doesnt count weapon in offhand.

but ghostly strike has greater "basic damage" (without daggers) hemorrhage has basic damage of 110% weapon damage without daggers, and 159.5% with daggers but ghostly strike has basic damage of 125% weapon damage without daggers, and 180% with daggers

You must count the basic damage (without daggers) as modifier 1.0, so for example with hemorrhage, modifier 1.45 represents 159.5% weapon damage and small typo in patch, when I was copying this modifiers from my notepad, then I accidentaly switched modifiers for this two attacks, so in first post is version (now with correct coeficients) updated to revision [9754]

ToC and Icecrown citadel has NORMAL RAID and HEROIC RAID mode, other raid instances has only NORMAL RAID mode WotLK and tBC normal (5 man) dungeons has all heroic and normal mode

updated patch version for mangos [9748] diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 4e8df4f..1c4c985 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -939,8 +939,8 @@ bool Aura::IsNeedVisibleSlot(Unit const* caster) const case SPELL_EFFECT_APPLY_AREA_AURA_FRIEND: case SPELL_EFFECT_APPLY_AREA_AURA_PARTY: case SPELL_EFFECT_APPLY_AREA_AURA_RAID: - // passive auras (except totem auras) do not get placed in caster slot - return (m_target != caster || totemAura || !m_isPassive) && m_modifier.m_auraname != SPELL_AURA_NONE; + // passive auras must be placed in caster slot + return (totemAura || m_isPassive) && m_modifier.m_auraname != SPELL_AURA_NONE; default: break; } diff --git a/src/game/SpellHandler.cpp b/src/game/SpellHandler.cpp index 2d8c2e1..9dac3b4 100644 --- a/src/game/SpellHandler.cpp +++ b/src/game/SpellHandler.cpp @@ -402,6 +402,9 @@ void WorldSession::HandleCancelAuraOpcode( WorldPacket& recvPacket) if (spellInfo->Attributes & SPELL_ATTR_CANT_CANCEL) return; + + if (IsPassiveSpell(spellId)) + return; if(!IsPositiveSpell(spellId)) { laise: this patch is only for showing passive auras on owners and restricting cancelling passive auras stacking of buffs with simillar effects has been bugged on mangos from beginning and this patch is not meant to resolve stacking problem of simillar buffs

then we must somewhere in code check, if the cancelled aura is passive, and then not remove her by right clicking, but from my information from retail, ALL passive auras (inclusing heroic presence) is shown as buffs even on owner

tested on abominations might and heroic presence, but should work with all raid-wide pasive auras diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 4e8df4f..1c4c985 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -939,8 +939,8 @@ bool Aura::IsNeedVisibleSlot(Unit const* caster) const case SPELL_EFFECT_APPLY_AREA_AURA_FRIEND: case SPELL_EFFECT_APPLY_AREA_AURA_PARTY: case SPELL_EFFECT_APPLY_AREA_AURA_RAID: - // passive auras (except totem auras) do not get placed in caster slot - return (m_target != caster || totemAura || !m_isPassive) && m_modifier.m_auraname != SPELL_AURA_NONE; + // passive auras must be placed in caster slot + return (totemAura || m_isPassive) && m_modifier.m_auraname != SPELL_AURA_NONE; default: break; }

I think function, in which must be "false" changed to "true" has been modified in revision, where visualisation of draenei racial heroic presence passive aura has been implemented, but I cant found that part in code or in revisions on github

What bug does the patch fix? What features does the patch add? From patch notes of 3.3.3 patch, Hemorrhage and Ghostly Strike must deal more damage, when player has dagger equipped http://www.wowhead.com/spell=48660 and ranks http://www.wowhead.com/spell=14278 I couldnt find spell family flags for Ghostly Strike so I used Id, when Ghostly strike has only one rank For which repository revision was the patch created? [9754] Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. couldnt find any Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index fe203b2..d2772d1 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -4983,6 +4983,20 @@ void Spell::EffectWeaponDmg(SpellEffectIndex eff_idx) if (weapon && weapon->GetProto()->SubClass == ITEM_SUBCLASS_WEAPON_DAGGER) totalDamagePercentMod *= 1.5f; // 150% to daggers } + // Ghostly Strike + else if (m_caster->GetTypeId() == TYPEID_PLAYER && m_spellInfo->Id == 14278) + { + Item* weapon = ((Player*)m_caster)->GetWeaponForAttack(m_attackType,true,true); + if (weapon && weapon->GetProto()->SubClass == ITEM_SUBCLASS_WEAPON_DAGGER) + totalDamagePercentMod *= 1.44f; // 144% to daggers + } + // Hemorrhage + else if (m_caster->GetTypeId() == TYPEID_PLAYER && (m_spellInfo->SpellFamilyFlags & UI64LIT(0x2000000))) + { + Item* weapon = ((Player*)m_caster)->GetWeaponForAttack(m_attackType,true,true); + if (weapon && weapon->GetProto()->SubClass == ITEM_SUBCLASS_WEAPON_DAGGER) + totalDamagePercentMod *= 1.45f; // 145% to daggers + } break; } case SPELLFAMILY_PALADIN:

I think thereis not such a spell. From my informations from retail, damage, that Hysteria deals to player is not shown in combat log and this damage in unafected by death knights blood presence if Hysteria is cast to DK with blood presence, because damage, that Hysteria deals is not considered as damage, but as "lose of health". Maybe there is other function in mangos other than DealDamage, which causes player lose health and not dealing damage to that player. But with DealDamage, the damage is not shown in combat log and DK is not healed by blood presence.

What bug does the patch fix? What features does the patch add? In arena, only caster should benefit from replenishment buff from http://www.wowwiki.com/Replenishment For which repository revision was the patch created? [9728] Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. couldnt find any Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp index b0acd37..5f68fd4 100644 --- a/src/game/Spell.cpp +++ b/src/game/Spell.cpp @@ -1676,7 +1676,13 @@ void Spell::SetTargetMap(SpellEffectIndex effIndex, uint32 targetMode, UnitList& case TARGET_ALL_RAID_AROUND_CASTER: { if(m_spellInfo->Id == 57669) // Replenishment (special target selection) - FillRaidOrPartyManaPriorityTargets(targetUnitMap, m_caster, m_caster, radius, 10, true, false, true); + { + // in arena, target should be only caster + if(m_caster->GetMap()->IsBattleArena()) + targetUnitMap.push_back(m_caster); + else + FillRaidOrPartyManaPriorityTargets(targetUnitMap, m_caster, m_caster, radius, 10, true, false, true); + } else if (m_spellInfo->Id==52759) // Ancestral Awakening (special target selection) FillRaidOrPartyHealthPriorityTargets(targetUnitMap, m_caster, m_caster, radius, 1, true, false, true); else

patch in first post updated to revision [9728]

patch in first post updated to revision [9728]

you can use google, for example

I am working with master branch only, without any additional patches, but I think that if changing spec must reset cooldown, then it must be done somewhere in dual spec patch, not in this patch.

problem is not in taxi - when you use taxi from dalaran, then you normally leave dalaran (even with debuff) but problem is when you tried to leave with your fly mount

What bug does the patch fix? What features does the patch add? This patch implements spell Call Stabled Pet (http://www.wowhead.com/?spell=62757) For which repository revision was the patch created? [9728] Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. couldnt find any Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/Player.cpp b/src/game/Player.cpp index f5941b8..c12ee24 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -2142,6 +2142,10 @@ Creature* Player::GetNPCIfCanInteractWith(ObjectGuid guid, uint32 npcflagmask) if (guid.IsEmpty() || !IsInWorld() || isInFlight()) return NULL; + // needed by Aura 292 + if (GetGUID() == guid.GetRawValue()) + return ((Creature*)this); + // exist (we need look pets also for some interaction (quest/etc) Creature *unit = GetMap()->GetCreatureOrPetOrVehicle(guid); if (!unit) diff --git a/src/game/SpellAuraDefines.h b/src/game/SpellAuraDefines.h index 8184db3..847b160 100644 --- a/src/game/SpellAuraDefines.h +++ b/src/game/SpellAuraDefines.h @@ -334,7 +334,7 @@ enum AuraType SPELL_AURA_289 = 289, SPELL_AURA_MOD_ALL_CRIT_CHANCE = 290, SPELL_AURA_MOD_QUEST_XP_PCT = 291, - SPELL_AURA_292 = 292, + SPELL_AURA_OPEN_STABLE = 292, SPELL_AURA_293 = 293, SPELL_AURA_294 = 294, SPELL_AURA_295 = 295, diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 35362de..660c6b3 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -342,7 +342,7 @@ pAuraHandler AuraHandler[TOTAL_AURAS]= &Aura::HandleUnused, //289 unused (3.2.2a) &Aura::HandleAuraModAllCritChance, //290 SPELL_AURA_MOD_ALL_CRIT_CHANCE &Aura::HandleNoImmediateEffect, //291 SPELL_AURA_MOD_QUEST_XP_PCT implemented in Player::GiveXP - &Aura::HandleNULL, //292 call stabled pet + &Aura::HandleAuraOpenStable, //292 call stabled pet &Aura::HandleNULL, //293 3 spells &Aura::HandleNULL, //294 2 spells, possible prevent mana regen &Aura::HandleUnused, //295 unused (3.2.2a) @@ -8273,3 +8273,17 @@ void Aura::HandleAllowOnlyAbility(bool apply, bool Real) m_target->UpdateDamagePhysical(RANGED_ATTACK); m_target->UpdateDamagePhysical(OFF_ATTACK); } + +void Aura::HandleAuraOpenStable(bool apply, bool Real) +{ + if(!apply || !Real) + return; + + Unit* caster = GetCaster(); + if(!caster || caster->GetTypeId() != TYPEID_PLAYER) + return; + + WorldPacket data; + data << uint64(caster->GetGUID()); + ((Player*)caster)->GetSession()->HandleListStabledPetsOpcode(data); +} diff --git a/src/game/SpellAuras.h b/src/game/SpellAuras.h index fa7d86d..b229cad 100644 --- a/src/game/SpellAuras.h +++ b/src/game/SpellAuras.h @@ -221,6 +221,7 @@ class MANGOS_DLL_SPEC Aura void HandleModTargetArmorPct(bool Apply, bool Real); void HandleAuraModAllCritChance(bool Apply, bool Real); void HandleAllowOnlyAbility(bool Apply, bool Real); + void HandleAuraOpenStable(bool apply, bool Real); virtual ~Aura();

core: [9620] udb: 388 ACID: 3.0.3 How it should work: When you leave Dalaran, you should not get restricted flight area debuff. You should get this debuff only when you enter Dalaran How it works now: When you leave Dalaran, you will get restricted flight area debuff, so leaving Dalaran on fly mounts is impossible How to reproduce: Go on Krasus Landing in dalaran, wait until restricted flight area debuff fades from you, then cast fly mount and try to fly from Dalaran. When you exit Dalaran, you will get restricted flight area debuff, then you will lose your fly mount and will be send on a very long slow fall which will result in your death.

Valhalla vehicle branch is now updated

What bug does the patch fix? What features does the patch add? This patch gets rid of "magic number" (number of ticks) used in damage calculation of Chimera Shot - Serpent Sting effect part. This patch will also correct the damage calculation of Chimera Shot - Serpent Sting effect when player has glyph of serpent sting equipped. For which repository revision was the patch created? [9728] Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. Couldnt find any Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index f7ab77a..72a5a5f 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -5888,7 +5888,7 @@ void Spell::EffectScriptEffect(SpellEffectIndex eff_idx) if ((familyFlag & UI64LIT(0x0000000000004000)) && aura->GetEffIndex() == EFFECT_INDEX_0) { // m_amount already include RAP bonus - basePoint = aura->GetModifier()->m_amount * 5 * 40 / 100; + basePoint = aura->GetModifier()->m_amount * (aura->GetAuraMaxDuration() / aura->GetModifier()->periodictime) * 40 / 100; spellId = 53353; // Chimera Shot - Serpent }

oh, then udb wiki should be updated We are using UDB 0.11.6 too without problems with instance binding or instance unbind delay core: 9549