cyrex

Silverice giving some console errors

error: patch failed: src/game/Spell.cpp:4388
error: src/game/Spell.cpp: patch does not apply
error: patch failed: src/game/SpellEffects.cpp:5747
error: src/game/SpellEffects.cpp: patch does not apply

So am guessing is not compatible anymore.

EDIT: None of the Blink patches is compatible now. Am gonna test if this is needed anymore or not.

Also this spell have a bug now.

The tramps can be affect for player of same realm and the caster.

If you put one tramp and use .cooldown to can put another tramp, tramp is freesing the caster or the las person than step into the tramp (including ppl of the same realm), that happens only if you put two tramps in the same place (you can wait until CD is down) and put another and you get freezer.

hahahaha am sorry but reading this made me laugh a lot just imagining the poor "tramp"

"What happens if you put two tramps in the same place"

For your problem you are using .cooldown anyway so you are removing the cooldown of the trap that just happen to match the time of the frozen target. What the problem might be here is that a hunter even if the cooldown is 1 should only be able to trap frozen one person at a time. So in your case if you use the second freeze trap the first one should wear off.

Freezing Trap Rank 3 -

Place a frost trap that freezes the first enemy that approaches, preventing all action for up to 20 sec.  Any damage caused will break the ice.  Trap will exist for 1 min.  Only one trap can be active at a time.

For SilverIce patch. Found this problem, when inside Stormwind Castle, where you get the BG queue, go on top of the carpet in the middle and do blink, it will teleport you to the same position. You won't move but the effects will be done.

This thread just proves that majority of people who criticise git don't understand it, or DVCS in general. Git is working fine, and it handles much bigger projects (linux kernel, anyone?).

+1..nevermind, +million

Compile fine. Only tested what is said in the first post and it works oki.

How much can this influence in the following scenarios:

1. Cpu performance

2. Memory usage

3. Network usage/performance

4. Maybe some other that i don't see

Am refering to vmap.ignoremapids = "530,571,169,37,369,451,13,30,1,0"

I think this is still a problem. I will test it out.

Tested SilverIce for 2 days. Very good, about 5 or 6 mages say thanks.

Which one to use. We got Raczman with 2 patches, We got SilverIce, Vincex, Tassader2 and caeruleaus. Which of this many:

1. Works corectly (Fall avoidance, Blink on any terrain, remove negative buffs, etc)

2. No memory leaks or crashes

3. Compatible with latest revisions.

Someday..over the rainbow..just kidding. Am waiting to test it out.

Bingo that was the problem. If i download the patch it gives the errors BUT if i copy it it works perfectly. Thanks a bunch guys.:lol:

don't download the patch, just copy the text into a file, else you could run into troubles with the newline encoding (windows CR LF (13 10) vs. linux LF (10))

Am guessing this is it. Let me test it out right now.

Am using git apply

Edit: I go to pastebin, click on dowload raw, download the raw version and use git apply to apply it. Anything wrong here i should know about?

got this problem:

/home/cyrex/warlock.patch:10: trailing whitespace.

newspell.active = IsPetAutoCastableSpell(spell_id) ? ACT_DISABLED : ACT_PASSIVE;

/home/cyrex/warlock.patch:14: trailing whitespace.

{

/home/cyrex/warlock.patch:15: trailing whitespace.

if (((active != ACT_DISABLED) && (active != ACT_ENABLED)) ||

/home/cyrex/warlock.patch:16: trailing whitespace.

IsPetAutoCastableSpell(spell_id))

/home/cyrex/warlock.patch:17: trailing whitespace.

newspell.active = active;

error: patch failed: src/game/Pet.cpp:1339

error: src/game/Pet.cpp: patch does not apply

error: patch failed: src/game/SharedDefines.h:259

error: src/game/SharedDefines.h: patch does not apply

error: patch failed: src/game/SpellMgr.cpp:98

error: src/game/SpellMgr.cpp: patch does not apply

error: patch failed: src/game/SpellMgr.h:148

error: src/game/SpellMgr.h: patch does not apply

error: patch failed: src/game/Unit.cpp:10385

error: src/game/Unit.cpp: patch does not apply

While this may not crash, there will be other complications.

There are numerous quest start items that only drop for one faction, as well as many quests inside instance that are only meant for one faction.

If you start changing players' factions, you're going to mess this up. If you let players change their faction at will (by joining a group of the opposite faction) pretty soon they're going to figure out they can exploit this to access extra quests.

Not to mention strolling through the opposite faction's capital cities unmolested.

WOW! :eek: So the code is not taking the faction back after getting out of the raid/group. that is very bad.

@Frozen - Don´t worry some of the people here are in the mangos thing to learn how to program. So you are with the rest of the people that want to learn. Keep it up.

@Patro - Leave the patch file here, the coding style in mangos has some problems and does not show correct patch format sometimes.

Thx for your patch.

but i have errors

can you help me ?

if i change your patch

by

Same error. for me line 197 is this

+    // Monkey
+    //    if(pOther->GetTeam() !=_player->GetTeam() )
+    //    {
+    //        SendTradeStatus(TRADE_STATUS_WRONG_FACTION);
[b]+    //        return;[/b] <--- Line 197
+    //    }
+    // Monkey

I do not get it. This is a commented line.

Using Mangos latest version up to right now (7821) with vmaps enabled. No problem. I should mention that since i started testing vmaps since 7620 i have yet to see a crash because of it. Uptime is between 7 days and 2 full weeks. Which by that time i actually have to kill the mangos to reset the server for updates and such. Using Ubuntu for it. No 64bit or things like that, a normal 32bit system with 2gb ram. Up to now the testing server has 5 days 2 hours uptime since my last update. So for me, vmaps is working excellent.

I have not tested still (Cause am at work and just noticed this) but just a couple of questions:

1. Did you test out al you are mentioning here. I mean trade, enchant, healing in a group or raid. Well basically everything before the change in 3.0.3.

2. Did you test it out with latest version since there has been MANY changes from your 7464 up to now.

3. Any crashes or mangos system stability issues that we should worry about?

Actually the spell should make the npc or player jump to you. For example you use Death grip on a player or mob and the animation should make the target jump from where he/she is to you. One long jump. It should not teleport the player. This is same for the druid cat form spell where you jump TO the target instead of the target jumping to you.

Holy mother i never thought it would happen :lol::lol:

Oh well.

This should be change to i think

case ACHIEVEMENT_CRITERIA_TYPE_EARN_HONORABLE_KILL:

SetCriteriaProgress(achievementCriteria, GetPlayer()->GetUInt32Value(PLAYER_FIELD_LIFETIME_HONORABLE_KILLS));

break;

This is because after many years of professional swimming techniques, all races are now professional swimmers. This grants them 2 additional minutes of underwater swimming. Please remember to vote in the WOW Olympics for the best swimming team.

Will the russian patch work on 3.0.9 without any problems?