DaC

someone may move this to under review section

/ thanks

Every type of stun should break stealth, not just sap.

patch: https://github.com/Nighoo/mangos-one/commit/ed9bf4d2d2da4fe9f0ae4d74010384a58d6dbc4d

Merry christmas!

for example

your needed commit is at: https://github.com/mangos-one/server/commit/35ec3d478eeb5d284be8dd501fbdbe81dcbd4543

you'll find the patchfile at: https://github.com/mangos-one/server/commit/35ec3d478eeb5d284be8dd501fbdbe81dcbd4543.patch

sorry for being that offtopic

so read the second line of my last post, please!

You've got git with all possibilities to merge repositories / cherry-pick single commits / rebasing your local stuff ...

but just append ".patch" to the commit hash on github to retrieve the patchfile.

greetings.

SOAP is an access protocol to send commands from an soap-client to your server. this can - for example - be used with php/perl/etc. on your webserver to autmate things. (like the RA-Connection)

Changed the uint32 to BattleGroundBracketId as return type of GetBracketId()

https://gist.github.com/1301175

...and it works, clean shutdown.

PS: thats no windows problem

What bug does the patch fix? What features does the patch add?

This will provide a function for SD2 to catch an avoid of a melee hit. This should be at least used for Zul'Aman's last encounter Zul'Jin - Spell Overpower.

He casts this spell when his target dodges one of his melee attacks.

Warrior's Overpower for players is handled in a special way with combopoints, which do not exist for creatures. (and Zul'Jin's spell does not have combopoint flag)

For which repository revision was the patch created?

MaNGOS One - some before latest revision

Who has been writing this patch? Please include either forum user names or email addresses.

me

From 96ec132991775707a0bf1d602c4d774b9d9f2b61 Mon Sep 17 00:00:00 2001
From: DaC <[email protected]>
Date: Thu, 22 Sep 2011 00:08:41 +0200
Subject: [PATCH] Implement CreatureAI function for avoided melee damage

---
src/game/CreatureAI.h |    3 +++
src/game/Unit.cpp     |    5 +++++
2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/src/game/CreatureAI.h b/src/game/CreatureAI.h
index 2a49d50..1056421 100644
--- a/src/game/CreatureAI.h
+++ b/src/game/CreatureAI.h
@@ -109,6 +109,9 @@ class MANGOS_DLL_SPEC CreatureAI
        // Called when owner of m_creature (if m_creature is PROTECTOR_PET) kills a unit
        virtual void OwnerKilledUnit(Unit *) {}

+        // Called when the creatures target avoids a normal meleehit
+        virtual void TargetAvoidedNormalMeleeHit(uint32 /*MeleeHitOutcome*/) {}
+
        // Called when the creature summon successfully other creature
        virtual void JustSummoned(Creature* ) {}

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 50c1ef0..beda809 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -555,6 +555,11 @@ uint32 Unit::DealDamage(Unit *pVictim, uint32 damage, CleanDamage const* cleanDa
            pVictim->SetStandState(UNIT_STAND_STATE_STAND);
    }

+    // call TargetAvoidedNormalMeleeHit for unit
+    if (cleanDamage && (cleanDamage->hitOutCome != MELEE_HIT_NORMAL))
+        if (GetTypeId() == TYPEID_UNIT && ((Creature*)this)->AI())
+            ((Creature*)this)->AI()->TargetAvoidedNormalMeleeHit(cleanDamage->hitOutCome);
+
    if(!damage)
    {
        // Rage from physical damage received .
-- 
1.7.1

greetings, DaC

If the patchfile also contains information to the author and a title, then you may want to use "git am FILE" to include this as commit in your branch.

Just implement a command which applies a special aura to your victim.

discussed a little bit in irc...

the real shadowbolts (aoe) is triggered by the permanent aura on the npc.

Orientation should not be visible, he still hit's his target

and all the spells in that array might not be needed, they are all doing the same.

Thanks for the hint:

                    //cast spell Raptor Capture Credit
-                    m_caster->CastSpell(m_caster, 42337, true, NULL);
+                    if (GetAffectiveCaster())
+                        m_caster->CastSpell(GetAffectiveCaster(), 42337, true, NULL);
                    return;
                }
                case 44997:                                 // Converting Sentry

What bug does the patch fix? What features does the patch add?

Pets summoned by jewelcrafting trinkets should be ooc-pets and not guardians.

For which repository revision was the patch created?

MaNGOS One - latest revision

Who has been writing this patch? Please include either forum user names or email addresses.

me

The small pets spawned by jewelcrafting items like 35700 should be passiv and not act like guardian pets.

From 9857d04bf835b197e3af2711d20c3ec23f7ca980 Mon Sep 17 00:00:00 2001
From: DaC <[email protected]>
Date: Tue, 21 Jun 2011 22:04:04 +0200
Subject: [PATCH] Jewelcrafting trinkes - Pets should be ooc-pets

---
src/game/SpellEffects.cpp |    5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index f490c03..a761372 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -3095,7 +3095,10 @@ void Spell::EffectSummonType(SpellEffectIndex eff_idx)
                    break;
                }
                case UNITNAME_SUMMON_TITLE_PET:
-                    DoSummonGuardian(eff_idx, summon_prop->FactionId);
+                    if (prop_id == 407)
+                        DoSummonCritter(eff_idx, summon_prop->FactionId);
+                    else
+                        DoSummonGuardian(eff_idx, summon_prop->FactionId);
                    break;
                case UNITNAME_SUMMON_TITLE_GUARDIAN:
                {
-- 
1.7.0.2.msysgit.0

regards, DaC

For 2.4.3 use the hostname "status.wow-europe.com"

But this is what vladimir did.

Entering arena: Buff applied -> mana&energy set to 100%

Leaving prep. phase (doors open) -> rage&runic power set to 0%

And moving this to HandleArenaPreparation seams to be better than handling in battleground.cpp!

Maybe he don't know how to use screen?

*big hint: man screen* @ redigaffi

Tested, works nice, thanks

Patch was writter for MaNGOS One

//

but just add "plr->SetPower(POWER_RUNIC_POWER, 0);"

Thanks for the notice. :cool:

From fd55f0853148229352ab9a50423b02e16b0186e5 Mon Sep 17 00:00:00 2001
From: DaC <[email protected]>
Date: Sat, 11 Jun 2011 19:11:34 +0200
Subject: [PATCH 1/5] set rage to zero and energy to 100% on battleground join

---
src/game/BattleGround.cpp |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/game/BattleGround.cpp b/src/game/BattleGround.cpp
index ea07204..78ee872 100644
--- a/src/game/BattleGround.cpp
+++ b/src/game/BattleGround.cpp
@@ -447,7 +447,10 @@ void BattleGround::Update(uint32 diff)

                for(BattleGroundPlayerMap::const_iterator itr = m_Players.begin(); itr != m_Players.end(); ++itr)
                    if (Player *plr = sObjectMgr.GetPlayer(itr->first))
+                    {
                        plr->RemoveAurasDueToSpell(SPELL_ARENA_PREPARATION);
+                        plr->SetPower(POWER_RAGE, 0);
+                    }

                CheckArenaWinConditions();
            }
@@ -1196,6 +1199,7 @@ void BattleGround::AddPlayer(Player *plr)

            plr->SetHealth(plr->GetMaxHealth());
            plr->SetPower(POWER_MANA, plr->GetMaxPower(POWER_MANA));
+            plr->SetPower(POWER_ENERGY, plr->GetMaxPower(POWER_ENERGY));
        }
    }
    else
-- 
1.7.0.2.msysgit.0

Aplly all patches including 11613 so "up to"

you could use command line tools like "cat *mangos*.sql > all_mangos_updates.sql"

Yes, you have to apply all sql updates till '11613_01_mangos_spell_bonus_data.sql' in your case.

Open mangosd.exe in your console (cmd.exe) and/or look at the serverlogs.

SD2 needs new Backport-Patch