divisorxx

I'm already testing with last changes and so far 16 hs uptime 800 users max, not crash related.

Testing with new changes, 700 users online with ACE mtmaps.... same than before, not a single crash related (12 hs uptime and counting) and diff time seems to be a little lower but, again, not too much, sure on more populate servers will be better. Thanks Ambal for your great work!!!!!

Testing with 700 users... not crash at all, diff time seems to be a little lower but not too much, maybe on more populate servers will be better. Thanks Ambal! Edit: Still not crashing (8 hours uptime and counting) and I forgot to say I'm using ACE mtmaps.

A little bump

I think derex say in other threads that he doens't work anymore on this project.

Hi one question, what kind of mutex because are you using? Can you show me? Because a try this http://paste2.org/p/688715 and seems to doesn't work

Sorry for this off post but someone can sendme or post the "visibility patch" from silverice and ambal?

Hi one questions, how much uptime did you have with this patch? Thanks.

Sorry my apologies for that.

No, trinity core ... is a leach of MaNGOS core, from the beginning until now...initial rev in repo from Trinity Core was a MaNGOS rev leeched (with some of custom patches from this forum included) and every important fix from MaNGOS was leeched too by Trinity Core even every version's switch...they aren't better than MaNGOS Dev even Trinity Core exist only due MaNGOS Dev and this great community... Trinity Core has that freatures because they leech every commit from MaNGOS so...with leeching those commits from MaNGOS they have free time to do that kind of freatures...again only possible due MaNGOS leechs. But quest related scripts is job of ScriptDev2 not MaNGOS Core...and just for note Trinity Core leechs ScriptDev2 work too in the same way. So think twice before say such crap.

It will by multithread (multicore).. like mtmaps patch but instead of you set the number of threads and all maps are working between those threads , it will one thread per map and in the end, free of race conditions, crashes, etc..so you can hold a great number of characters or future stuffs.

Like I said early...problem seems to be in multithreaded player updates, so revert this commit http://github.com/mangos/mangos/commit/e24d2938b21e8d6910c5aed1a3f115abf0fbddf1 and problem solved but again almost all load will remain in main thread like time ago. Also you can try openmt maps with Infinity suggestions , if that work you can still have Player:Update in Map:Updates w/o crash. P.S.: By the way... just for curiosity , what kind of mtmaps patch are you using? (Ace mtmaps or OpenMP mtmaps)

In fact there is a crash log of what i'm talking about, using ACE mtmaps. With 7XX characters... it crash like 5 times by day (some days less).. but like a said before once that i move Players:Update from Map:Update...I got like 3day uptimes. http://pastebin.com/m836455e To infinfny, thanks for your suggestions i will try it with your patch.

Sorry if my english is not too good but i don't see any errors in my word. In any case I mean how much uptime do you have... because in my experience I have a lot of crashes due _UpdateSpells in Unit.cpp using mtmaps (I think due race conditions)...due to this I move Players update out of Maps and problem solved...but again main thread have the almost charge(load) compare to the others. Again sorry If my english is not too good. Bye

Hi men, one question, how stable is?

Hi i trying to use this mtmaps patch http://pastebin.com/m7d3df483, posted by balrok.. but when I use this patch all spawned threads are in 6X% of cpu ussage... I think there it's too much... it's normaly ? not? somebody can help me?. I have Xeon cpu , 8 cores...tested with gcc 4.4.0 and 4.3.2 P.S.: Sorry I didn't realize that maybe this isn't the right place to post this

Sorry When I said that I tested this patch i mean Ambal's Patch... i think it was the same... i will tested this one now.

Hi balrok, Thanks for your time, just one question it's this assert the one that you remove ? And it's this safe to remove? Object.h const uint32& GetUInt32Value( uint16 index ) const { ASSERT( index < m_valuesCount || PrintIndexError( index , false) ); return m_uint32Values[ index ]; }

I already have it on my server... tested with Rev 8579 and ~750 characters ON, finaly, not one crash due bgqueue update using derek's mtmaps. Thanks! Only one due this assert, but it's not related at all, and it's and old crash, I posted here not to want something just to show you that it's not related. const uint32& GetUInt32Value( uint16 index ) const { ASSERT( index < m_valuesCount || PrintIndexError( index , false) ); return m_uint32Values[ index ]; } #1 0x00007f057bd39960 in abort () from /lib64/libc.so.6 No symbol table info available. #2 0x00007f057bd3137f in __assert_fail () from /lib64/libc.so.6 No symbol table info available. #3 0x00000000004d5715 in Object::GetUInt32Value (this=<value optimized out>, index=<value optimized out>) at ../../../src/game/Object.h:166 st = {static SYMBUFSIZ = 4096, buf_ = "./mangos-worldd(_ZNK5Guild12CanStoreItemEhhRSt6vectorI17GuildItemPosC static UNSUPPORTED = 0x7f057e3faaa0 "<stack traces unsupported platform>", static UNABLE_TO_GET_TRACE = 0x7f057e3faad0 "<unable to get trace>"} __FUNCTION__ = "GetUInt32Value" __PRETTY_FUNCTION__ = "const uint32& Object::GetUInt32Value(uint16) con #4 0x00000000007694c8 in Guild::_CanStoreItem_InTab (this=0x435efa0, tab=<value optimized out>, dest=@0x451c7ef0, count=<value optimized out>, merge=<value optimized out>, pSrcItem=0x7f05192bfb70, skip_slot=255 'ÿ') at ../../../src/game/Object.h:142 pItem2 = <value optimized out> j = <value optimized out> #5 0x0000000000769a0d in Guild::CanStoreItem (this=0x435efa0, tab=<value optimized out>, slot=255 'ÿ', dest=@0x451c7ef0, count=1, pItem=0x7f05192bfb70, swap=false) at ../../../src/game/Guild.cpp:1954 res = 0 '\\0' res = 0 '\\0' #6 0x00000000007700bd in Guild::MoveFromCharToBank (this=0x435efa0, pl=0x7f05034db9c0, PlayerBag=<value optimized out>, PlayerSlot=<value optimized out>, BankTab=<value optimized out>, BankTabSlot=<value optimized out>, SplitedAmount=0) at ../../../src/game/Guild.cpp:2342 dest = {<std::_Vector_base<GuildItemPosCount, std::allocator<GuildItemP _M_impl = {<std::allocator<GuildItemPosCount>> = {<__gnu_cxx::new_allocator _M_finish = 0x0, _M_end_of_storage = 0x0}}, <No data fields>} msg = <value optimized out> pItemBank = (class Item *) 0x0 pItemChar = (class Item *) 0x7f05192bfb70 #7 0x00000000007745b6 in WorldSession::HandleGuildBankSwapItems ( this=0x2c3474b0, recv_data=@0x7f0556ab9650) at ../../../src/game/GuildHandler.cpp:1143 BankTab = 0 '\\0' BankTabDst = 102 'f' unk2 = 0 '\\0' SplitedAmount = 0 pl = (class Player *) 0x7f05034db9c0 GoGuid = <value optimized out> AutoStore = 0 '\\0' ToChar = 0 '\\0' AutoStoreCount = 0 AutoStoreCount = 0 GuildId = <value optimized out> BankTabSlot = 255 'ÿ' PlayerBag = 20 '\\024' BankTabSlotDst = 240 'ð' ItemEntry = 0 BankToBank = 0 '\\0' PlayerSlot = 5 '\\005' unk1 = 4294967295 pGuild = (Guild *) 0x435efa0 #8 0x0000000000727902 in WorldSession::Update (this=0x2c3474b0) at ../../../src/game/../shared/Log.h:119 packet = (WorldPacket *) 0x7f0556ab9650 currTime = <value optimized out>

Sorry apoc, i cant test it in this weekend due study, but this sure I will do it, everything related to multithreading it's very important . Thanks

Thanks apoc... i'm going to try it this weekend

You can try newest revs, Ambal make changes that bring more performance to mangos (hopefully he bring more this kind of changes in future). Also you can try patches like mtmaps or visibility refresh times (False.Genesis or SilverIce). Sorry for my bad english.

Hi ambal.. it seems you are a dev now, Congratulations and thanks for your work!. I will update with new patch's changes soon.

I read this... in patch from getmangos.ru... If I remember right, Ambal and SilverIce fix it on they patch. Will be great if they post it this forum too.

I want to test it but i don't know if you patch is full patch or it has to be with original patch?