dpedroia15

Typo in title, "Glyph of Rake"^^ What bug does the patch fix? What features does the patch add? The patch adds the effect for Glyph of Rake. For which repository revision was the patch created? 10357 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No Who has been writing this patch? Please include either forum user names or email addresses. Me, dpedroia15 diff --git a/src/game/UnitAuraProcHandler.cpp b/src/game/UnitAuraProcHandler.cpp index 092f7fe..20a3873 100644 --- a/src/game/UnitAuraProcHandler.cpp +++ b/src/game/UnitAuraProcHandler.cpp @@ -1547,6 +1547,10 @@ SpellAuraProcResult Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura triggered_spell_id = 54755; break; } + //Glyph of Rake + case 54821: + triggered_spell_id = 54820; + break; // Item - Druid T10 Restoration 4P Bonus (Rejuvenation) case 70664: {

That's what I was trying to accomplish with the attack times. Since the 50% damage is dealt by the same weapon that gained the 8th/7th mote of anger, you can get that weapon by checking for which weapon was the last weapon to attack, hence getting the attack timers. About the Deathbringer's Will trinket, thank you for finding something on what happens with casters Vladimir, I couldnt find anything when I looked. I don't quite know what you're saying about the duplicate spell cases though, but I will try to rethink that part of the patch and possibly resubmit something

What bug does the patch fix? What features does the patch add? The patch adds the effect for Alchemist's Stone. Before this, the spell did not have any affect on the use of healing/mana potions. For which repository revision was the patch created? 10333 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No Who has been writing this patch? Please include either forum user names or email addresses. Me, dpedroia15 Patch: http://paste2.org/p/944718

By the way it works perfectly fine^^

Does this need any more testing?

What bug does the patch fix? What features does the patch add? The patch adds the dummy effects for the spell from the Healing Priest T9 4P Set Bonus. For which repository revision was the patch created? 10333 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No Who has been writing this patch? Please include either forum user names or email addresses. Me, dpedroia15 diff --git a/src/game/UnitAuraProcHandler.cpp b/src/game/UnitAuraProcHandler.cpp index 8efae7c..5f079b5 100644 --- a/src/game/UnitAuraProcHandler.cpp +++ b/src/game/UnitAuraProcHandler.cpp @@ -1334,7 +1334,12 @@ SpellAuraProcResult Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura // Divine Aegis case 2820: { - basepoints[0] = damage * triggerAmount/100; + //Item - Priest T9 Healing 4P Bonus (Divine Aegis and Empowered Renew) + float spell_trigger_amount = triggerAmount; + SpellAuraHolder *aurHolder = GetSpellAuraHolder(67202); + if(aurHolder) + spell_trigger_amount *= 1.10f; + basepoints[0] = damage * spell_trigger_amount/100; triggered_spell_id = 47753; break; } @@ -1345,13 +1350,18 @@ SpellAuraProcResult Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura return SPELL_AURA_PROC_FAILED; // Renew Aura* healingAura = pVictim->GetAura(SPELL_AURA_PERIODIC_HEAL, SPELLFAMILY_PRIEST, UI64LIT(0x40), 0, GetGUID()); if (!healingAura) return SPELL_AURA_PROC_FAILED; int32 healingfromticks = healingAura->GetModifier()->m_amount * GetSpellAuraMaxTicks(procSpell); - - basepoints[0] = healingfromticks * triggerAmount / 100; + + //Item - Priest T9 Healing 4P Bonus (Divine Aegis and Empowered Renew) + float spell_trigger_amount = triggerAmount; + SpellAuraHolder *aurHolder = GetSpellAuraHolder(67202); + if(aurHolder) + spell_trigger_amount *= 1.10f; + basepoints[0] = healingfromticks * spell_trigger_amount / 100; triggered_spell_id = 63544; break; }

I actually didn't see that thread. I think my handling of the 2P Bonus is the best way to do it, as it IS causing a dummy aura.

What bug does the patch fix? What features does the patch add? The patch adds the dummy effects for the proc from the Balance Druid T10 2P Set Bonus. For which repository revision was the patch created? 10330 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No Who has been writing this patch? Please include either forum user names or email addresses. Me, dpedroia15 diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp diff --git a/src/game/UnitAuraProcHandler.cpp b/src/game/UnitAuraProcHandler.cpp index 8efae7c..98c8c13 100644 --- a/src/game/UnitAuraProcHandler.cpp +++ b/src/game/UnitAuraProcHandler.cpp @@ -1569,6 +1569,15 @@ SpellAuraProcResult Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura pVictim->CastSpell(second, procSpell, true, NULL, triggeredByAura, GetGUID()); return SPELL_AURA_PROC_OK; } + //Item - Druid T10 Balance 2P Bonus + case 70718: + { + if (!procSpell) + return SPELL_AURA_PROC_FAILED; + triggered_spell_id = 70721; + target = this; + break; + } } // Eclipse if (dummySpell->SpellIconID == 2856)

What bug does the patch fix? What features does the patch add? The patch adds the dummy effects for the spell of the trinket "Vanquished Clutches of Yogg Saron". For which repository revision was the patch created? 10330 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No Who has been writing this patch? Please include either forum user names or email addresses. Me, dpedroia15 diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 5bd42e1..342b487 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -1759,6 +1759,18 @@ void Spell::EffectDummy(SpellEffectIndex eff_idx) m_caster->CastSpell(unitTarget,60934,true,NULL); return; } + case 64981: //Vanquished Clutches of Yogg-Saron + { + uint32 spell_id = 0; + switch(irand(1,3)) + { + case 1: spell_id = 64982; break; + case 2: spell_id = 64983; break; + case 3: spell_id = 64984; break; + } + m_caster->CastSpell(m_caster,spell_id,true); + return; + } case 67019: // Flask of the North { if (m_caster->GetTypeId() != TYPEID_PLAYER)

Ive been looking at spells like Ignite, Languish (Balance Druid T10 4P proc), etc, where a dummy spell is procced and the dummy spell does X% of the proccing spell's damage. Most of the code is the same... case <SPELLID>: { basepoints[0] = int32(damage * triggerAmount/100); triggered_spell_id = <TRIGGERED_SPELLID>; break; } The problem I'm getting is that a lot of these spells aren't even proccing, even though I have tem under the correct Handler and correct Spell Family. I've tried debugging but I'm still too new at it to find the exact place where this is going wrong. Could someone point me in the right direction?

Alright, thanks for the advice.

So could I make a proc event for Monster Slayer's Kit when Monster Slayer's Symbol hits the target and Monster Slayer's Symbol Return is cast back?

You're completely right, I dont know how I missed that >.< My bad for wasting everyone's time!

I was checking around to make sure that this fix was correct, seeing as it seemed like a kind of obvious thing to miss. Why would DoT damage be handled per tick? EDIT: Take a look at Deep Wounds proc handling in core. The basepoints are not handled per tick. So one of these spells is wrong

Nevermind

I'm not sure that quite what I'm looking for but thanks for the suggestion. Could I possibly just write a case where whenever a target is hit by spell A, spell B is cast back? Or is that considered a hack-like fix?

Is there a function that can detect when a spell hits a target? For example: spell A has a cast time a flight time. once spell A has been casted and hits the target, the target will cast spell B on the caster of spell A.

That did it. I should have guessed because I had to put my Tiny Abomination in a Jar fix under the paladin spellfamily. Why does blizzard make it tricky on us ?

Yes I had done all that. But when i tested my fix on my server, it would still use the wrong DBC data and proc Blessing of Light.

Have you tested it ingame? I've written the same exact thing essentially, but it kept proccing Blessing of Light instead of the effect.

Perfect, I updated my main post and the patch should now be perfectly blizzlike. Thanks for the find!

That's odd, it compiles fine for me. I'll help you out when I'm back at my house, can't right now.

What bug does the patch fix? What features does the patch add? The patch adds the dummy effects for the two ICC trinkets mentioned above. Currently, the items do not have any effect when used ingame. For which repository revision was the patch created? 10241 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No Who has been writing this patch? Please include either forum user names or email addresses. Me, dpedroia15 Link to patch I didnt think of it before, but if you'd like me to compress the fixes into one case for each, I will do so. Also, the models for the Deathbringer's Will effect are not working. I should say..only the iron dwarf model is in the DBCs. According to Wowhead, the other model ids for the transform spells are over 30k. The max model id as of 3.3.5a is somewhere around 29k (can't be sure of the exact, still away from home). So as of now, all the transforms except for iron dwarf use the default pig model. It seems that an Arcemu based server I used to play on has the models working, so I plan to look through the Arcemu source when I get a chance (no promises though, it might be a hacky fix or a custom patch by the server). EDIT: Fixed thanks to fullburn's find. I have a slightly modified SQL from the Trinitycore DELETE FROM creature_template WHERE entry IN (38292,38271,38273); INSERT INTO creature_template (entry,modelid_A,modelid_H) VALUES (38292,31182,31182), (38271,31182,31182), (38273,31015,31015); DELETE FROM creature_model_info WHERE modelid = 31015; INSERT INTO creature_model_info (modelid) VALUES (31015); DELETE FROM creature_model_info WHERE modelid=31182; INSERT INTO creature_model_info (`modelid`) VALUES (31182); EDIT: Updated code to be cleaner. EDIT: Updated SQL.

What I'm saying is that the healing reduction spells include the shield reduction, so the patch is good.

According to this blue post there was "an additional change via an in-game fix so that the PvP healing debuff in Arenas, Battlegrounds, and Wintergrasp now also lowers the effectiveness of Power Word: Shield and Sacred Shield by 10%." So if the spell works as intended (no reason why it should not), then the 10% absorb shield reduction should be included.