Edder

scriptdev2

need w12x to rewrite if from scratch ^^

fixed

Sadly he doesnt write anymore

Merging most of the working features into the main branch will give more casual contributors much better access and understanding of the code and the mod's developers more time and possibility to work on more important issues than compatibility rewrites.

Full Ack.

I would rather have a 3.3.5 server that works really well than a 4.0.1 that barely functions.

Agreed, the vehicles are basic in WotLK (in Battlegrounds, OpenPVP, Dungeons and Questing) and they arent working right now and Destructible Buildings too.

You may focus on Cata (not to much), but dont forget WotLK...

Sadly nobody hired the sheep for contract work the last weeks, and thus I am severely lacking funds.

And now?

XP_Rates Patch [2]

SQL:

http://paste2.org/p/1051992

Code:

http://paste2.org/p/1052509

Tested with mangos core 10640

Try it...

* added starttime and endtime options

* added query to make an entry for all existing characters in character_xp_rates

I dunno what happen if you modify the core xp rates (from mangosd.conf), I tested with default values (1, 1, 1)!

Well, ok I'll do some research on how to do this...

New patch:

SQL:

http://paste2.org/p/1045237

Code:

http://paste2.org/p/1045234

Should work fine with clean mangos (10625)...

edit: damn URL tags

And I think code is incomplete, it can crash the server by several ways

Hell yeah.

I wonder were my complete patch is.

Anyway, I'll try to rewrite it and implement the three rows (quest xp, explore xp, kill xp)...

I guess it happens in DeleteFromDB...

Just replace "guid" with "lowguid" in this case.

Try this:

Its old and you'll have to implement it manually but I guess it work (didnt tested it with newest core)...

Code:

http://paste2.org/p/1041421

SQL:

http://paste2.org/p/1041423

With it, you may modify the kill, explore and quest XP for each character (guid) ...

Got an error on applying patch:

fatal: git apply: bad git-diff - expected /dev/null on line 31

mangos rev 10417

1) Getting XPBar to redisplay at level 80 and show to 85.

Do you test to change:

#    MaxPlayerLevel
#        Max level that can be reached by player for experience (in range from 1 to 100).
#        Change not recommended
#        Default: 80

Ok, solved. Looks like saving conf using ANSI instead of UTF-8 lets mangosd start.

Saving as ANSI solved the problem for me, thanks.

Mangos Core: 10086 (but bug appears since 10081 - use of ace config lib)

Custom patches: nope

SD2 Version: no sd2

Database Name and Version: UDB 391

How it SHOULD work: load config properly

How it DOES work: mangosd.conf only loads if its not changed, it only works if its directly copied from src/mangos/ and renamed, but if the logs dir for example is changed, in console appears that conf file cant be found.

realmd and his conf file works great with modifications...

can anyone confirm?

Dont be lazy and use searchfunction.

Little hint, it can be found on github.com !

it is working fine, perhaps it is time to submit it in "the under review section" ?

That would be nice.

I want see this soon on master!

Yea, like camera patch please...

I tried it as well and on mangos core 10051 the player keeps the flag whether he relogs or not.

Simpli tested with:

diff --git a/src/game/Player.cpp b/src/game/Player.cpp
index 53706be..eb63ea2 100644
--- a/src/game/Player.cpp
+++ b/src/game/Player.cpp
@@ -2514,6 +2514,9 @@ void Player::GiveXP(uint32 xp, Unit* victim)
    if(!isAlive())
        return;

+    if(HasFlag(PLAYER_FLAGS, PLAYER_FLAGS_XP_USER_DISABLED))
+        return;
+
    uint32 level = getLevel();

    // XP to money conversion processed in Player::RewardQuest
@@ -17627,6 +17630,13 @@ void Player::BuildPlayerChat(WorldPacket *data, uint8 msgtype, const std::string

void Player::Say(const std::string& text, const uint32 language)
{
+    // [only for test]
+    if(text == "xp 0" && !HasFlag(PLAYER_FLAGS, PLAYER_FLAGS_XP_USER_DISABLED))
+        SetFlag(PLAYER_FLAGS, PLAYER_FLAGS_XP_USER_DISABLED);
+    else if (text == "xp 1" && HasFlag(PLAYER_FLAGS, PLAYER_FLAGS_XP_USER_DISABLED))
+        RemoveFlag(PLAYER_FLAGS, PLAYER_FLAGS_XP_USER_DISABLED);
+    // [/only for test]
+
    WorldPacket data(SMSG_MESSAGECHAT, 200);
    BuildPlayerChat(&data, CHAT_MSG_SAY, text, language);
    SendMessageToSetInRange(&data,sWorld.getConfig(CONFIG_FLOAT_LISTEN_RANGE_SAY),true);

Two questions:

Does the player hold the flag when relog?

And if not, where are the flags stored in db? in character_data ?

I actually think, that it would be better to also move the BG's code to SD2 (for style reasons)

Agreed, a Battleground is a simple PvP Instance, Raid Instances scripts are in sd2 too...

Because the Bg's are imported why the spirit healers not ?

Well, every npc is scripted by sd2 (or eventAI of course) and not by mangos core itself, the guards are too and they're important too, arent they?

Also Mount Vendors are scripted by sd2...

Spirithealer's are important, but why scripting them in mangos core, when we got a scripting core (sd2)?

Little question lynx, are you in contact with mangos devs? Or is there silence on both sides, have they said something about your awesome work and when they want probably implement this?

I dont know exactly how mangos handles those projects today, I just remember w12x's Outdoor PvP patch which was totally awesome, but I never fully implemented?!

What is missing now? Stability?

Well, I suppose cooperation is missing...

Has anybody tried this, besides me?

j4r0d's patch or Rage Hunter's ?