Flemzard

confirmed in s0163 too

sorry for double post

Confirmed in 0.12 too

due to this (for 0.12) http://github.com/mangos/mangos/commit/43694467bea190b0e5d7690381fb34b4b14c9bb2

I said to "prevent" crash, just for safe

I've follow your reflexion ifilgud, and yes it's works

here my patch for 0.12 -> https://gist.github.com/10ccec53138076439c97

500 players did the test for me. it's on my server since around 3weeks and good return

I already use this but adapted for 0.12 and for now seem to work fine

You should write this

Unit *GetMisdirectionTarget() { return ( m_misdirectionTargetGUID && IsInWorld() ) ? GetMap()->GetUnit(m_misdirectionTargetGUID) : NULL; }

and add a new include

#include "Map.h"

I've rewrite it again.

Now heal calculation work fine and libram too

https://gist.github.com/b7fb164ce567ee47b5d7 (First link updated)

I can confirm in 0.12 too

Vanish really work out of combat only

EDIT: Maybe due to this commit http://github.com/mangos/mangos/commit/e27be3cbf91d74f1806a99460bbf039b8892d6fc ?

OMG Sorry for the mistake I didn't see this <.<

Diff edited

I also think this does not apply to 5 men instances, only raids.

Moreover, you cannot enter if a boss (level 3) is engaged but you can enter freely when the group fights with trash mobs only.

With the trash it's okay because IsEncounterInProgress() is more often use with boss and not trash (or maybe it's a special case)

And yes you're right I've fix this, now it's check is only apply for raid.

https://gist.github.com/68b1d946384fcd1ce152 (First link updated)

I've have also add a forgotten player->isGameMaster()

What bug does the patch fix? What features does the patch add?

The patch fix the item http://www.wowhead.com/item=23006 (Wowhead corrupted it's +83 to Flash of light in game)

For which repository revision was the patch created?

S00108

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No

Who has been writing this patch? Please include either forum user names or email addresses.

Me

https://gist.github.com/b7fb164ce567ee47b5d7

What bug does the patch fix? What features does the patch add?

The patch adds a not implemented optcode yet in 0.12 branch, backported from master

For which repository revision was the patch created?

S00096

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No

Who has been writing this patch? Please include either forum user names or email addresses.

I don't who really, but I've do the backport

https://gist.github.com/4f79d124a54adc5c872b

Yep it's a very hacky solution ^^ thx

But still the problem of http://www.wowhead.com/spell=37116

I confirm my idea it's this the problem

// out of range pet dismissed

if (!pet->IsWithinDistInMap(p_caster, pet->GetMap()->GetVisibilityDistance()))

{

pet->Remove(PET_SAVE_NOT_IN_SLOT, true);

}

else

{

pet->GetMotionMaster()->MoveFollow(caster, PET_FOLLOW_DIST, PET_FOLLOW_ANGLE);

pet->AddSplineFlag(SPLINEFLAG_WALKMODE);

}

I 've remove the Remove() function and now i'm at 3days uptime

I will try this but i'm waiting for a crash so this isn't apply a the moment

// out of range & same map, pet dismissed

if (!pet->IsWithinDistInMap(p_caster, pet->GetMap()->GetVisibilityDistance()) && (pet->GetMap() == caster->GetMap()))

{

pet->Remove(PET_SAVE_NOT_IN_SLOT, true);

}

else

{

pet->GetMotionMaster()->MoveFollow(caster, PET_FOLLOW_DIST, PET_FOLLOW_ANGLE);

pet->AddSplineFlag(SPLINEFLAG_WALKMODE);

}

You're welcome

Bump !

This bug still exist and http://www.wowhead.com/spell=33600 too

This crash was been fix with this

(in map.cpp)

{

Object* obj = *i_objectsToClientUpdate.begin();

i_objectsToClientUpdate.erase(i_objectsToClientUpdate.begin());

- obj->BuildUpdateData(update_players);

+ if (obj && obj->IsInWorld())

+ switch(obj->GetTypeId())

+ {

+ case TYPEID_ITEM:

+ case TYPEID_CONTAINER:

+ ((Item*)obj)->BuildUpdateData(update_players);

+ break;

+ case TYPEID_PLAYER:

+ if(!(obj->GetGUIDLow() != 0 && sObjectMgr.GetPlayer(obj->GetGUIDLow())))

+ break;

+ case TYPEID_UNIT:

+ case TYPEID_GAMEOBJECT:

+ case TYPEID_DYNAMICOBJECT:

+ case TYPEID_CORPSE:

+ ((WorldObject*)obj)->BuildUpdateData(update_players);

+ break;

+ default: break;

+ }

}

I think I found the problem, and for this crash it's come from possess spell (Since s0074) in fact I think we have a problem when the core try to delete a creature in other map that the owner.

For the moment I've comment the condition for remove pet and only do the movefollow and seem to work

Further I think we can add pet->GetMap() == caster->GetMap() in the condition to remove

i've remark that when the server crash, i've got 4/5 chain crash and often i've the same value in "this" var

Map::Remove<Creature> (this=0x33d0000, obj=0x7fb2bad3e080, remove=true) at ../../../src/game/Map.cpp:796

Map::Remove<Creature> (this=0x33d0000, obj=0x7fa844312080, remove=true) at ../../../src/game/Map.cpp:796

Map::Remove<Creature> (this=0x33d0000, obj=0x7fecb4282080, remove=true) at ../../../src/game/Map.cpp:796

Yep i'm agree with you, I don't see the problem it's why I post here x)

I continue to search but i think i will found nothing

No, but in raid time maybe more often, yesterday I've got 12 crashs and 9 betwenn 8:00pm and 0:00

I've retake a look but I found nothing

And the server crash more and more often 3/day approximately

MaNGOS have already do the summon part, now the script poison etc it's SD2 part. Maybe little modification to do with attackpower but it's nothing

Use the script post by Milk13, and it's will work fine