m4cm4n

What bug does the patch fix? What features does the patch add? The IsNoStackAuraDueToAura function currently compares also default spell effect values (ie. all values = 0), so it is always evaluated as "true" if both compared spells have less than 3 effects. This also causes most of guardian and battle elixir to overwrite even if they shouldn't. For which repository revision was the patch created? 10301 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No. Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp index ebb9818..f023122 100644 --- a/src/game/SpellMgr.cpp +++ b/src/game/SpellMgr.cpp @@ -305,7 +305,11 @@ bool IsNoStackAuraDueToAura(uint32 spellId_1, uint32 spellId_2) if (spellInfo_1->Effect[i] == spellInfo_2->Effect[j] && spellInfo_1->EffectApplyAuraName[i] == spellInfo_2->EffectApplyAuraName[j] && spellInfo_1->EffectMiscValue[i] == spellInfo_2->EffectMiscValue[j] - && spellInfo_1->EffectItemType[i] == spellInfo_2->EffectItemType[j]) + && spellInfo_1->EffectItemType[i] == spellInfo_2->EffectItemType[j] + && (spellInfo_1->Effect[i] != 0 + || spellInfo_1->EffectApplyAuraName[i] != 0 + || spellInfo_1->EffectMiscValue[i] != 0 + || spellInfo_1->EffectItemType[i] != 0)) return true; } } Pastebin link: http://pastebin.org/436664

Some additional things that I noticed: The search result's tab "Characters" shows always "(1)" as number of found characters, even when more characters were found. The list of characters displays the results correctly, other tabs are also working fine. Talent calculator for Druids is not working, others are ok. I can't see the list of characters on my account when I log in. Placement of wrists and waist on the character's equipment window is swapped, again Tooltips for items are still not displaying in Safari (4.0.5), I can see tooltips only for empty slots and for stats, but not for items. Error console shows this error message each time I try to load some item tooltip: Error: WRONG_DOCUMENT_ERR: DOM Exception 4 I hope it helps.

seems to be fixed on latest rev. (177), nice I meant those connections in class.search.php (functions SearchArenaTeams, SearchGuilds, SearchCharacters), I thought it would be better to keep all connections in the class.connector.php, but that's not a big deal.

Sorry, but i don't get what you mean. I tested it with poisons applied to my weapons as well as poisons and DoT effects ticking on me and none of them was removed during Vanish. My inspiration for this correction was hunter's Feign Death (Aura::HandleFeignDeath), which seems to work fine. It has similar effect as Vanish, and it is using the InterruptNonMeleeSpells() function, which was missing in the Vanish handling part, so I don't understand why it is wrong to have this function also in Vanish...

I just tested it and poisons are not removed with this. The threat lists (if i get it right) are already emptied in Spell::EffectSanctuary, which is also called when player uses Vanish, but it doesn't help, there is still something that makes creatures, which are close enough, get aggro again, even through stealth...