mns

February 12, 2010

That's sad but is true, i had a 11hr~16hr uptime.
Im using the lasted rev ( clean ) now and i have 1hr uptime.

please share crash log !

February 12, 2010

mns, what intrest in outdated revisoon infO???
Also use hash for 0.12 revision description... 0.12 not have clear revision in master branch way...

[9327] backported in http://github.com/mangos/mangos/commit/01186e1335e28f185d03294cb8026b7847ba3cd7

in new revision possible new crash not related this topic

my test posit [9327] fixed problem

Vladimir, I use alway backported rev and patch form mangos-0.12 for mangos-0.12 , i used master rev number for ease reporting

sorry if my report not useful or i can`t realization intent truly

February 11, 2010

In any case please look at [9327] affect at discussed crashes...

I test it for mangos-0.12

mangos-0.12 [9287] -> crash and crash

mangos-0.12 [9287] + manual patch[9327] -> 1 Day Uptime hitherto

thx vladimir

February 10, 2010

mns, maybe:
*****************
?

I not switched own server to master branch and i not working and test fix path for master .

I still use mangos-0.12 for own server .

in 0.12 not used any argument GetDifficulty() and i not understand truly about GetDifficulty(boolean) argument .

maybe added for specify new raid system in WotLK .

You will compile and test patch and correcting patch for master

February 3, 2010

2>..\\..\\src\\game\\GroupHandler.cpp: error C2660: 'Player::GetDifficulty' : function does not take 0 arguments
2>..\\..\\src\\game\\GroupHandler.cpp: error C2660: 'Player::GetDifficulty' : function does not take 0 arguments

rev 9100

my patch corrected for mangos-0.12

i think you must replace GetDifficulty() with GetDifficulty(true) for correct path for master branch

but i not tested it !

February 3, 2010

I can confirm crash still after [9288] backport in mangos-0.12

00000001400D6ADA  0000000007FA32C0  Group::CountTheRoll+2A  d:\\9287_1563\\src\\game\\group.cpp line 713
00000001400D6AA2  0000000007FA3320  Group::EndRoll+A2  d:\\9287_1563\\src\\game\\group.cpp line 708
00000001400B3B6D  0000000007FAB520  Creature::Update+69D  d:\\9287_1563\\src\\game\\creature.cpp line 397
0000000140109435  0000000007FAB5B0  MaNGOS::ObjectUpdater::Visit+F5  d:\\9287_1563\\src\\game\\gridnotifiersimpl.h line 48
000000014010932D  0000000007FAB620  VisitorHelper<MaNGOS::ObjectUpdater,Creature>+1D  d:\\9287_1563\\src\\framework\\gamesystem\\typecontainervisitor.h line 65
000000014010868D  0000000007FAB650  VisitorHelper<MaNGOS::ObjectUpdater,Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > >+1D  d:\\9287_1563\\src\\framework\\gamesystem\\typecontainervisitor.h line 71
0000000140107FF0  0000000007FAB680  VisitorHelper<MaNGOS::ObjectUpdater,GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > >+30  d:\\9287_1563\\src\\framework\\gamesystem\\typecontainervisitor.h line 72
00000001401077DD  0000000007FAB6B0  VisitorHelper<MaNGOS::ObjectUpdater,TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > >+1D  d:\\9287_1563\\src\\framework\\gamesystem\\typecontainervisitor.h line 95
0000000140103703  0000000007FAF760  Map::Visit<MaNGOS::ObjectUpdater,TypeMapContainer<TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > > >+113  d:\\9287_1563\\src\\game\\map.h line 600
00000001400FBCFD  0000000007FAF7F0  Cell::Visit<MaNGOS::ObjectUpdater,TypeMapContainer<TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > > >+7D  d:\\9287_1563\\src\\game\\cellimpl.h line 47
00000001400E6F93  0000000007FAFB70  Map::Update+583  d:\\9287_1563\\src\\game\\map.cpp line 625
00000001402E851F  0000000007FAFC60  MapManager::Update+19F  d:\\9287_1563\\src\\game\\mapmanager.cpp line 262
0000000140285FD9  0000000007FAFE20  World::Update+729  d:\\9287_1563\\src\\game\\world.cpp line 1583
000000014003C235  0000000007FAFE60  WorldRunnable::run+A5  d:\\9287_1563\\src\\mangosd\\worldrunnable.cpp line 61
00000001402A8A13  0000000007FAFED0  ACE_Based::Thread::ThreadTask+23  d:\\9287_1563\\src\\shared\\threading.cpp line 186
00000000003F170B  0000000007FAFF10  [email="?invoke@ACE_OS_Thread_Adapter@@UEAAKXZ+5B"]?invoke@ACE_OS_Thread_Adapter@@UEAAKXZ+5B[/email]
0000000078622FDF  0000000007FAFF40  _endthreadex+47
0000000078623080  0000000007FAFF70  _endthreadex+E8
0000000077D6B71A  0000000007FAFFA0  BaseThreadStart+3A

February 3, 2010

This patch can solve part2 of this bug for mangos-0.12

diff --git a/src/game/GroupHandler.cpp b/src/game/GroupHandler.cpp
index e17b609..0cce779 100644
--- a/src/game/GroupHandler.cpp
+++ b/src/game/GroupHandler.cpp
@@ -321,6 +321,13 @@ void WorldSession::HandleGroupSetLeaderOpcode( WorldPacket & recv_data )
    /** error handling **/
    if (!player || !group->IsLeader(GetPlayer()->GetGUID()) || player->GetGroup() != group)
        return;
+
+    for (GroupReference *itr = group->GetFirstMember(); itr != NULL; itr = itr->next())
+    {
+        Map *map = itr->getSource()->GetMap();
+        if (map && map->IsDungeon() && player->GetBoundInstance(itr->getSource()->GetMapId(),itr->getSource()->GetDifficulty()) && !itr->getSource()->GetBoundInstance(itr->getSource()->GetMapId(),itr->getSource()->GetDifficulty()) )
+            return;
+    }
    /********************/

    // everything's fine, do it

February 2, 2010

Wouldn't this be fixed after http://github.com/mangos/mangos/commit/feb8f13e457ea72affdbe90bcd1f84485cd8ee31

not related this patch !

Still bug

February 2, 2010

2 - leader promote to leader of Save in instanse (New leader must saved in instance before)

Question : How must occur when leader promote to saved leader (Blizzlike) ?

February 2, 2010

Must fixed in [9283]

February 2, 2010

Must fixed in [9283]

January 31, 2010

I can confirm this crash on mangos-0.12

January 24, 2010

Hi

Question :

SpellHealingBonus must calculate in PeriodicTick healing or not !

in Mangos calculate this .

Example :

Use this talent

http://www.wowhead.com/?spell=33873

and use this Item

http://www.wowhead.com/?item=833

This Item must Restores 10 health every 5 sec

but SpellHealingBonus restore great health !

Example 1000 health every 5 sec !

it`s wrong or not ?!

January 1, 2010

Happy new year

How test bug ?

.goname [player in bg]

Again

.goname [player in bg]

Server Crash when ending BG

How ?!

BG teleport GM to BG

Fix for Mangos-0.12

diff --git a/src/game/Level1.cpp b/src/game/Level1.cpp
index 4b28192..e78f9e1 100644
--- a/src/game/Level1.cpp
+++ b/src/game/Level1.cpp
@@ -504,7 +504,8 @@ bool ChatHandler::HandleGonameCommand(const char* args)
            // when porting out from the bg, it will be reset to 0
            _player->SetBattleGroundId(target->GetBattleGroundId());
            // remember current position as entry point for return at bg end teleportation
-            _player->SetBattleGroundEntryPoint(_player->GetMapId(),_player->GetPositionX(),_player->GetPositionY(),_player->GetPositionZ(),_player->GetOrientation());
+            if (!_player->GetMap()->IsBattleGroundOrArena())
+                _player->SetBattleGroundEntryPoint(_player->GetMapId(),_player->GetPositionX(),_player->GetPositionY(),_player->GetPositionZ(),_player->GetOrientation());
        }
        else if(cMap->IsDungeon())
        {

Fix for Master

diff --git a/src/game/Level1.cpp b/src/game/Level1.cpp
index 2c3faef..e2861eb 100644
--- a/src/game/Level1.cpp
+++ b/src/game/Level1.cpp
@@ -507,7 +507,8 @@ bool ChatHandler::HandleGonameCommand(const char* args)
            // when porting out from the bg, it will be reset to 0
            _player->SetBattleGroundId(target->GetBattleGroundId(), target->GetBattleGroundTypeId());
            // remember current position as entry point for return at bg end teleportation
-            _player->SetBattleGroundEntryPoint();
+            if (!_player->GetMap()->IsBattleGroundOrArena())
+                _player->SetBattleGroundEntryPoint();
        }
        else if(cMap->IsDungeon())
        {

Note:

I test it only for Mangos-0.12

December 24, 2009

ok

balrok Patch can prevent reset instance when groupmembers are inside instance

but players can prevent save with other part of this bug !

1 - raid go to instance

2 - leader promote to leader of Save in instanse (New leader must saved in instance before)

3 - Raid Killing Boss

4 - Raid Relog and raid not saved !

Note :

when Raid killing Boss server send this error :

Cannot bind players, no instance save available for map!

reality server can`t find save for bind group

I test this only in mangos-0.12

November 23, 2009

Need backporting to 0.12

November 22, 2009

 
diff --git a/src/mangosd/mangosd.conf.dist.in b/src/mangosd/mangosd.conf.dist.in
index fe2c631..70d9f77 100644
--- a/src/mangosd/mangosd.conf.dist.in
+++ b/src/mangosd/mangosd.conf.dist.in
@@ -301,6 +301,7 @@ LogFilter_TransportMoves = 1
LogFilter_CreatureMoves = 1
LogFilter_VisibilityChanges = 1
WorldLogFile = ""
+WorldLogTimestamp = 0
DBErrorLogFile = "DBErrors.log"
CharLogFile = "Char.log"
CharLogTimestamp = 0

October 1, 2009

Thanks for pointing to problem. Patch similar suggested by you has been applied as hotfix ( [8464] ) to master also in time apply related backported patches but not catched as need t backporting . Now [8464] also backported.

Thx for researching

October 1, 2009

I think this is high priority bug and must commit fix faster !

September 28, 2009

Mangos 923e00df031cfbe3b97e40292fe1f7a433f56dcf

Bug : When player update Guild Rank then update rankId+1

I think this Bug Related to 106e4c4b90508e20d3e0a2f07c97ab6fabb650da

diff --git a/src/game/Guild.cpp b/src/game/Guild.cpp
index 4246bb7..7520a5d 100644
--- a/src/game/Guild.cpp
+++ b/src/game/Guild.cpp
@@ -681,7 +681,7 @@ void Guild::SetRankName(uint32 rankId, std::string name_)

    // name now can be used for encoding to DB
    CharacterDatabase.escape_string(name_);
-    CharacterDatabase.PExecute("UPDATE guild_rank SET rname='%s' WHERE rid='%u' AND guildid='%u'", name_.c_str(), (rankId+1), m_Id);
+    CharacterDatabase.PExecute("UPDATE guild_rank SET rname='%s' WHERE rid='%u' AND guildid='%u'", name_.c_str(), rankId, m_Id);
}

void Guild::SetRankRights(uint32 rankId, uint32 rights)
@@ -691,7 +691,7 @@ void Guild::SetRankRights(uint32 rankId, uint32 rights)

    m_Ranks[rankId].Rights = rights;

-    CharacterDatabase.PExecute("UPDATE guild_rank SET rights='%u' WHERE rid='%u' AND guildid='%u'", rights, (rankId+1), m_Id);
+    CharacterDatabase.PExecute("UPDATE guild_rank SET rights='%u' WHERE rid='%u' AND guildid='%u'", rights, rankId, m_Id);
}

int32 Guild::GetRank(uint32 LowGuid)
@@ -1406,7 +1406,7 @@ void Guild::SetBankMoneyPerDay(uint32 rankId, uint32 money)
        if (itr->second.RankId == rankId)
            itr->second.BankResetTimeMoney = 0;

-    CharacterDatabase.PExecute("UPDATE guild_rank SET BankMoneyPerDay='%u' WHERE rid='%u' AND guildid='%u'", money, (rankId+1), m_Id);
+    CharacterDatabase.PExecute("UPDATE guild_rank SET BankMoneyPerDay='%u' WHERE rid='%u' AND guildid='%u'", money, rankId, m_Id);
    CharacterDatabase.PExecute("UPDATE guild_member SET BankResetTimeMoney='0' WHERE guildid='%u' AND rank='%u'", m_Id, rankId);
}

September 11, 2009

How need Add newline at end of file ?

Now endline is sql comment [ -- ]

this cause problem when merging sql files

example :

-- New system uses `LogGuid` from 0 to number defined in config.ALTER TABLE character_db_version CHANGE COLUMN required_066_8402_02_characters_guild_bank_eventlog required_066_8409_01_characters_guild bit;

diff --git a/sql/updates/066_8402_01_characters_guild_eventlog.sql b/sql/updates/066_8402_01_characters_guild_eventlog.sql
index 406a9fb..2eb4705 100644
--- a/sql/updates/066_8402_01_characters_guild_eventlog.sql
+++ b/sql/updates/066_8402_01_characters_guild_eventlog.sql
@@ -17,4 +17,5 @@ CREATE TABLE `guild_eventlog` (

-- The reason i decided for such dramatic change is that old guild_eventlog table didn't have Primary key and 
-- used LogGuids from 0 to infinity
--- New system uses LogGuids from 0 to number defined in config.
\\ No newline at end of file
+-- New system uses LogGuids from 0 to number defined in config.
+
diff --git a/sql/updates/066_8402_02_characters_guild_bank_eventlog.sql b/sql/updates/066_8402_02_characters_guild_bank_eventlog.sql
index 399971b..ec1c6ab 100644
--- a/sql/updates/066_8402_02_characters_guild_bank_eventlog.sql
+++ b/sql/updates/066_8402_02_characters_guild_bank_eventlog.sql
@@ -20,4 +20,5 @@ CREATE TABLE `guild_bank_eventlog` (

-- The reason i decided for such dramatic change is that old guild_bank_eventlog table used `TabId` = 0 for Money events and 
-- used `LogGuid` from 0 to infinity
--- New system uses `LogGuid` from 0 to number defined in config.
\\ No newline at end of file
+-- New system uses `LogGuid` from 0 to number defined in config.
+

August 13, 2009

http://www.scriptdev2.com/backport-sd2-0-t4411.html

July 16, 2009

How developers not Commited this patch yet ?!

Players can procure intolerable Gold with this bug !

July 15, 2009

Mangos [8187]

diff --git a/src/game/Player.cpp b/src/game/Player.cpp
index f6af1cc..97bfa30 100644
--- a/src/game/Player.cpp
+++ b/src/game/Player.cpp
@@ -14854,7 +14854,7 @@ void Player::SaveInventoryAndGoldToDB()

void Player::SaveGoldToDB()
{
-    CharacterDatabase.PExecute("UPDATE money = '%u' WHERE guid = '%u'", GetMoney(), GetGUIDLow());
+    CharacterDatabase.PExecute("UPDATE characters SET money = '%u' WHERE guid = '%u'", GetMoney(), GetGUIDLow());
}

void Player::_SaveActions()

July 11, 2009

Vladimir we not needing apply rollback query before use [before_upgrade_to_0.13\\052_8072_01_characters_characters.sql] ?!

Example :

[HIGHLIGHT=SQL]

UPDATE `characters` SET `data`=CONCAT(CAST(SUBSTRING_INDEX(`data`, ' ', 1461) AS CHAR), ' ', `money`, ' ', CAST(SUBSTRING_INDEX(`data`, ' ', -131)AS CHAR));

[/HIGHLIGHT]

Sign In

Profiles

Bug Tracker

Wiki

Release Notes

Forums

Downloads

Blogs

Events

Posts posted by mns

Contact Us

Repositories

Important Information