mobel

cool, that's one less thing to think about *

According to comments on well-known db site, the talent Nature's Grace (id 16880) is supposed to proc spell 16886 from healing crits, as well as from damage crits. I don't have a druid on retail of sufficient lvl to find out for myself, can anyone confirm this though? BTW, if it indeed is supposed to proc on healing crits, I've found that the following SQL statement allows it to work that way on mangos too (tested on rev 6767): update spell_proc_event set procflags = (268435456 + 65536) where entry = 16880;

I took a look at the commit message, and what got committed was both the swapping of the offhand frills and the triggering of the combat swap spell. Arrai also fixed it up so that the spell id exists as a #define so that it can be changed easily. AFAIK combat swap GCD still exists in 2.4.3 (and even 3.0.2 when I checked a few weeks ago), and since MaNGOS is still on 2.4.3 (in the stable branch at least) the triggering seems appropriate, imho (not that it really matters at this point since the spell itself isn't implemented) I'm currently trying to find a way to implement the spells, but like thenecromancer i have no idea how to atm

What bug does the patch fix? What features does the patch add? Implements combat swapping for off-hand frills like on retail. Also Implements triggering of spells 6119 and 6123 (combat swap GCD) when weapons are switched during combat. For which SubVersion revision was the patch created? SVN rev 6767 Who has been writing this patch? Please include either forum user names or email addresses. Me (mobel). Forum display name used to be simak before the forums were moved here. ------------ Sorry for submitting this patch in SVN format, I'm still uncomfortable with the use of git. Learning slowly though. Note that spells 6119 and 6123 do nothing atm, my patch only allows them to be cast upon weapon switch during combat (.cast 6119 in-game does nothing). But when their dummy auras are implemented (not sure how to go about that yet, maybe for a future patch) Combat Swap GCD should work..I think. Index: src/game/ItemPrototype.h =================================================================== --- src/game/ItemPrototype.h (revision 6767) +++ src/game/ItemPrototype.h (working copy) @@ -552,6 +552,7 @@ { case INVTYPE_RELIC: case INVTYPE_SHIELD: + case INVTYPE_HOLDABLE: return true; } Index: src/game/Player.cpp =================================================================== --- src/game/Player.cpp (revision 6767) +++ src/game/Player.cpp (working copy) @@ -9921,6 +9921,7 @@ Item* Player::EquipItem( uint16 pos, Item *pItem, bool update ) { + uint32 GcdCombatSwitchSpell = 0; if( pItem ) { AddEnchantmentDurations(pItem); @@ -9948,8 +9949,12 @@ if(pProto && isInCombat()&& pProto->Class == ITEM_CLASS_WEAPON && m_weaponChangeTimer == 0) { m_weaponChangeTimer = DEFAULT_SWITCH_WEAPON; + GcdCombatSwitchSpell = 6119; if (getClass() == CLASS_ROGUE) - m_weaponChangeTimer = ROGUE_SWITCH_WEAPON; + { + m_weaponChangeTimer = ROGUE_SWITCH_WEAPON; + GcdCombatSwitchSpell = 6123; + } } } @@ -9992,7 +9997,7 @@ return pItem2; } } - + if(GcdCombatSwitchSpell) CastSpell(this,GcdCombatSwitchSpell,true); return pItem; }

As I understand it, all spells that deal a debuff that can be resisted fully or not at all, count as binary spells - even if one of the (non-aura) spell effects does damage (i.e. frost nova, frostbolt, mind flay - the slowing debuff of it is binary) I guess if the debuff done by the spell is not a DoT, that'll make it binary.... so apply-aura check, and then an extra check to see if the aura applied is not a DoT should do... Not sure if that can be done in a clean way though... info taken from: http://www.wowwiki.com/Resistance#Binary_s...partial_resists http://www.wowwiki.com/Binary_spell I'm not sure if that's totally accurate, ofc...