nos4r2zod

It works for both WSG and EotS. What's the AB flag? :confused: Edit: I see, I didn't test the EotS/AB base captures with DS yet. Edit2: I'll change it on paste2 later, thanks.

I only created entries for proc spells from items that were added in WoTLK. But in UDB 369, Band of the Eternal Champion has a 60 minute cd, Blackened Naaru Sliver has no entry in spell_proc_event (no internal CD). IMO, you shouldn't be worrying about individual procs when there are faster ways to make entries for groups of them at a time.

What bug does the patch fix? - Right now, Death Knights are receiving the default amounts of +spell power to their abilities that are counted as spells. These are the spells that have some portion of AP added to them. The easiest fix is just to add the spell_bonus_data entries; it prevents the abilities from going to the default case in the SpellDamageBonus and they need AP added to the abilities anyways. For which repository revision was the patch created? - Tested on 7434 DELETE FROM `spell_bonus_data` where entry in (49941, 55078, 50444, 52212, 47632, 47633, 55095, 49184, 45477, 45477, 50842, 47476, 50536, 50401, 56903); INSERT INTO `spell_bonus_data`(`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES (49941, 0, 0, 0.04, "Death Knight - Blood Boil"), (55078, 0, 0, 0.055, "Death Knight - Blood Plague Dummy Proc"), (50444, 0, 0, 0.105, "Death Knight - Corpse Explosion Triggered"), (52212, 0, 0, 0.0475, "Death Knight - Death and Decay Triggered"), (47632, 0, 0, 0.15, "Death Knight - Death Coil Damage"), (47633, 0, 0, 0.15, "Death Knight - Death Coil Heal"), (55095, 0, 0, 0.055, "Death Knight - Frost Fever"), (49184, 0, 0, 0.1, "Death Knight - Howling Blast"), (45477, 0, 0, 0.1, "Death Knight - Icy Touch"), (50842, 0, 0, 0.04, "Death Knight - Pestilence"), (47476, 0, 0, 0.06, "Death Knight - Strangulate"), (50536, 0, 0, 0.013, "Death Knight - Unholy Blight Triggered"), (50401, 0, 0, 0, "Death Knight - Razor Frost"), (56903, 0, 0, 0, "Death Knight - Lichflame"); Didn't add bloodworms or summon gargoyle, but these will need dummy auras anyways. Edit: Source was elitist jerks; just checked and it has the same values as the wiki for the entries that the wiki has. Edit2: Added runeforging procs from Razorice and Lichbane

I commented out lines rather than deleting them because I wasn't sure about them, so I wanted to see what other people could come up with. Also, I wanted to keep the list complete; right now, it contains every proc spell added in WoTLK that comes from items, except for the ones that explicitly say "on every hit," such as the Brunnhildar weapons. Changed the hex/floats to dec ints.

Huh? Seems to work fine for me; the 2 you highlighted refers to "PROC_EX_CRITICAL_HIT = 0x0000002." The proc flag is retrieved from dbc. EDIT: Note there is a mistake in the description of the item though. If you read the comments here, it does proc off of ranged critical hits from a ranged weapon. The flag is correct in the dbc; it's marked as 0x00000154, meaning PROC_FLAG_SUCCESSFUL_RANGED_SPELL_HIT, PROC_FLAG_SUCCESSFUL_RANGED_HIT, PROC_FLAG_SUCCESSFUL_MELEE_SPELL_HIT, PROC_FLAG_SUCCESSFUL_MILEE_HIT. Same problem with Mirror of Truth

DELETE FROM `spell_proc_event` WHERE `entry` IN (51414, 52418, 53355, 53371, 54695, 54707, 54808, 54838, 55747, 57345, 57348, 57351, 57352, 57907, 58442, 58444, 59345, 59776, 59787, 59818, 60061, 60063, 60066, 60221, 60301, 60306, 60313, 60317, 60436, 60442, 60473, 60482, 60485, 60487, 60490, 60510, 60517, 60519, 60529, 61618, 55381, 27521, 38347, 34320, 33297, 38299, 55640, 55768, 55776, 59630, 54738); INSERT INTO `spell_proc_event`(`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES ('51414','0','0','0','0','0','0','0','0','0','45'), -- Venomous Tome -- ('52418','0','0','0','0','0','0','0','0','0','0'), -- Massive Seaforium Charge -- ('53355','0','0','0','0','0','0','0','0','0','0'), -- Secret Strength of the Frenzyheart -- ('53371','0','0','0','0','0','0','0','0','0','0'), -- Energized Polished Crystal ('54695','0','0','0','0','0','0','0','0','0','45'), -- Death Knight's Anguish ('54707','0','0','0','0','0','0','0','0','0','60'), -- Sonic Booster ('54808','0','0','0','0','0','0','0','0','0','60'), -- Noise Machine ('54838','0','0','0','0','0','0','0','0','0','45'), -- Valonforth's Remembrance ('55747','0','0','0','0','0','0','0','0','0','45'), -- Horn of Argent Fury ('57345','0','0','0','0','0','0','0','0','0','45'), -- Darkmoon Card: Greatness -- ('57348','0','0','0','0','0','0','0','0','0','0'), -- The RP-GG -- ('57351','0','0','0','0','0','0','0','0','0','0'), -- Darkmoon Card: Berserker! ('57352','0','0','0','0','0','0','0','0','0','45'), -- Darkmoon Card: Death -- ('57907','0','0','0','0','0','0','0','0','0','0'), -- Idol of Arcane Terror ('58442','0','0','0','0','0','0','0','0','0','15'), -- Airy Pale Ale ('58444','0','0','0','0','0','0','0','0','0','5'), -- Worg Tooth Oatmeal Stout ('59345','0','0','0','0','0','0','0','0','0','45'), -- Crusader's Locket -- ('59776','0','0','0','0','0','0','0','0','0','0'), -- Oracle Secret Solution -- ('59787','0','0','0','0','0','0','0','0','0','0'), -- Oracle Talisman of Ablution -- ('59818','0','0','0','0','0','0','0','0','0','0'), -- Frenzyheart Insignia of Fury ('60061','0','0','0','0','0','0','0','0','0','45'), -- Scarab of the Infinite Cycle ('60063','0','0','0','0','0','0','0','0','0','45'), -- Sundial of the Exiled ('60066','0','0','0','0','0','0','0','0','0','45'), -- Hourglass of the Unraveller ('60221','0','0','0','0','0','0','0','0','0','45'), -- Essence of Gossamer ('60301','0','0','0','0','0','0','0','0','0','45'), -- Meteorite Whetstone ('60306','0','0','0','0','0','0','0','0','0','45'), -- Vestige of Haldor -- ('60313','0','0','0','0','0','0','0','0','0','0'), -- Fury of the Five Flights ('60317','0','0','0','0','0','0','0','0','0','45'), -- Signet of Edward the Odd ('60436','0','0','0','0','0','0','0','0','0','45'), -- Grim Toll ('60442','0','0','0','0','0','0','0','0','0','45'), -- Bandit's Insignia ('60473','0','0','0','0','0','0','0','0','0','45'), -- Forge Ember ('60482','0','0','0','0','0','0','0','0','0','45'), -- Pendulum of Telluric Currents -- ('60485','0','0','0','0','0','0','0','0','0','0'), -- Illustration of the Dragon Soul ('60487','0','0','0','0','0','0','0','0','0','15'), -- Extract of Necromantic Power ('60490','0','0','0','0','0','0','0','0','0','45'), -- Embrace of the Spider -- ('60510','0','0','0','0','0','0','0','0','0','0'), -- Soul Preserver -- ('60517','0','0','0','0','0','0','0','0','0','0'), -- Talisman of Troll Divinity ('60519','0','0','0','0','0','0','0','0','0','45'), -- Spark of Life ('60529','0','0','0','0','0','0','0','0','0','45'), -- Forethought Talisman ('61618','0','0','0','0','0','0','0','0','0','45'), -- Chuchu's Tiny Box of Horrors -- Sephiroth1983 (55381, 0x00, 0, 0, 0, 0, 0, 65536, 0, 0, 15), -- Insightful Earthsiege Diamond (27521, 0x00, 0, 0, 0, 0, 0, 65536, 0, 0, 15), -- Insightful Earthstorm Diamond (38347, 0x00, 0, 0, 0, 0, 0, 2, 0, 0, 45), -- Sextant of Unstable Currents (34320, 0x00, 0, 0, 0, 0, 0, 2, 0, 0, 45), -- Shiffar's Nexus-Horn (33297, 0x00, 0, 0, 0, 0, 0, 0, 0, 0, 45), -- Quagmirran's Eye (38299, 0x00, 0, 0, 0, 0, 0, 0, 0, 0, 15), -- Fel Reaver's Piston ('55640','0','0','0','0','0','0','0','0','0','45'), -- Lightweave ('55768','0','0','0','0','0','0','0','0','0','60'), -- Darkglow ('55776','0','0','0','0','0','0','0','0','0','45'), -- Swordguard ('59630','0','0','0','0','0','0','0','0','0','45'), -- Black Magic ('54738', '0', '0', '0', '0', '0', '0', '2', '0', '0', '45'); -- Serrah's Star -- Cooldowns for spells already in spell_proc_event Delete From spell_proc_event where entry in (50781, 54841, 58901, 60537); INSERT INTO `spell_proc_event`(`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES ('50781','0','0','0','0','0','0','2','0','0','6'), -- Fate Rune of Primal Energy ('54841','0','0','0','0','0','0','2','0','0','3'), -- Thunder Capacitor ('58901','0','0','0','0','0','0','2','0','0','45'), -- Tears of Bitter Anguish ('60537','0','0','0','0','0','0','2','0','0','45'); -- Soul of the Dead -- ('48833','0','7','0','1088','0','0','0','0','0','0'), -- Idol of the Plainstalker -- ('48835','0','10','0','8','0','0','0','0','0','0'), -- Libram of Furious Blows -- ('48837','0','11','2416967680','0','0','0','0','0','0','0'), -- Totem of the Tundra -- ('52020','0','7','32768','1048576','0','0','0','0','0','0'), -- Idol of the Wastes -- ('52423','0','0','0','0','0','0','32','0','0','0'), -- Signet of the Dark Brotherhood -- ('60572','0','11','2416967680','0','0','0','0','0','0','0'), -- Deadly Gladiator's Totem of Survival -- ('60719','0','7','2','0','0','0','0','0','0','0'), -- Deadly Gladiator's Idol of Steadfastness -- ('60770','0','11','1','0','0','0','0','0','0','45'), -- Totem of the Elemental Plane -- ('60818','0','10','0','512','0','0','0','0','0','45'), -- Libram of Reciprocation -- ('60826','0','15','20971520','0','0','0','0','0','0','45'), -- Sigil of Haunted Dreams -- ('61324','0','10','0','131072','0','0','0','0','0','0'), -- Venture Co. Libram of Retribution These are the values from wowhead comments for items with procs in WoTLK that aren't already in spell_proc_event, plus some things I missed that were in Sephiroth's post. I didn't add any procflags or procex flags because I thought mangos already gets those from spells.dbc. I commented out the ones with a cooldown of 0 rather than removing them so others could check my work (some of them, like RP-GG and Massive Seaforium charge sound like they'd need server script implementation anyways). EDIT: Added update statements for proc spells from items that already have entries in spell_proc_event. Wasn't sure about the 3 relic slot items, Totem of the Elemental Plane, Libram of Reciprocation, Sigil of Haunted Dreams. From what I've read, Totem of the Elemental Plane was meant to be a direct upgrade to Skycall Totem, but it had a cooldown whereas Skycall totem did not, so it ended up being worse. Not sure if the cooldown for those relic slot items has been removed already. EDIT2: Changed update to delete/insert

Check the enums in SpellMgr.h: PROC_FLAG_SUCCESSFUL_MILEE_HIT = 0x00000004 ... PROC_EX_CRITICAL_HIT = 0x0000002 I think that's what you're looking for.

I peeked around in the spell.dbc file: 1) Find all spells with "Proc Trigger Spell." (1211 entries found) 2) Use allakhazam's spell history to find the start for range of all WoTLK spells with this spell effect (seems to be http://wow.allakhazam.com/db/spellhistory.html?wspell=46854). (403 entries found) 3) In DB, select items that have these spell effects in either spellid_1 or spellid_2. Take these spellids, these will need to be in `spell_proc_event` (69 entries) 4) Remove entries that are already in MaNGOS UDB 11.0 (378), of which there are 20. (49 entries) The result is the following list, which needs to have entries in spell_proc_event: (51414, 52418, 53355, 53371, 54695, 54707, 54808, 54838, 55735, 55747, 55755, 55755, 55755, 57345, 57345, 57345, 57345, 57348, 57351, 57352, 57907, 58442, 58444, 59345, 59776, 59787, 59818, 60061, 60063, 60066, 60221, 60301, 60306, 60313, 60317, 60436, 60442, 60473, 60482, 60485, 60487, 60490, 60510, 60517, 60519, 60529, 61618). For the curious, these are the names of the items with these spells: Hourglass of the Unraveller, Scarab of the Infinite Cycle, Vestige of Haldor, Soul Preserver, Essence of Gossamer, Pendulum of Telluric Currents, Meteorite Whetstone, Spark of Life, Forge Ember, Talisman of Troll Divinity, Valonforth's Remembrance, Death Knight's Anguish, Idol of Arcane Terror, Venomous Tome, Massive Seaforium Charge, Embrace of the Spider, Secret Strength of the Frenzyheart, Energized Polished Crystal, Horn of Argent Fury, Grim Toll, Forethought Talisman, Bandit's Insignia, Extract of Necromatic Power, Fury of the Five Flights, Illustration of the Dragon Soul, Sundial of the Exiled, Sonic Booster, Noise Machine, Brunnhildar Bow, Brunnhildar Axe, The RP-GG, Darkmoon Card: Greatness, Darkmoon Card: Berserker!, Darkmoon Card: Death, Airy Pale Ale, Worg Tooth Oatmeal Stout, Brunnhildar Harpoon, Brunnhildar Great Axe, Crusader's Locket, Chuchu's Tiny Box of Horrors, Oracle Secret Solution, Frenzyheart Insignia of Fury, Oracle Talisman of Ablution, Darkmoon Card: Greatness, Signet of Edward the Odd, Darkmoon Card: Greatness, Darkmoon Card: Greatness Of course, this only matches the spell procs on items, so enchants have to be handled separately. Here's something I wrote for my server: delete from `spell_proc_event` where `entry` in (55640, 55768, 55776, 59630); insert into `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) values ('55640','0','0','0','0','0','0','0','0','0','45'), -- Lightweave ('55768','0','0','0','0','0','0','0','0','0','60'), -- Darkglow ('55776','0','0','0','0','0','0','0','0','0','45'), -- Swordguard ('59630','0','0','0','0','0','0','0','0','0','45'); -- Black Magic Of course, adding these values by hand would still be a pita. Is there a place in the dbc where these proc cooldowns can be found? And also, did I miss anything in my script?

The core still does regeneration the old way, this only adds the regenerate flag for the clients. Really, for now, this only helps with DK runes not refreshing on their own for some DKs.