Oniryck

I'm adding some new bugs from this new aura system: -Paladins judgements don't seem to refresh -Mage's Winter Chill is applied on the caster (the debuff should only apply to hostiles) if he casts blizzard and if he is in the effect area. Also winter's chill don't stack between different caster : it should have one stack for all casters, in s0976 if another caster apply it, the stack is reset to 1.

Mangos One s0974 mmaps patch Here is the first type of error I got, several times the same per day [New Thread 23338] [New Thread 23311] [New Thread 23339] [New Thread 23340] [New Thread 23310] [New Thread 23342] [New Thread 23341] [New Thread 23312] [New Thread 23308] Core was generated by `./mangosd'. Program terminated with signal 11, Segmentation fault. #0 0x0000000000a6db04 in Unit::SpellDamageBonusTaken (this=0x7fb72c766080, pCaster=0x1204c000, spellProto=0x7fb7785222d0, pdamage=72, damagetype=DOT, stack=1) at /home/mangos/src/game/Unit.cpp:5891 in /home/mangos/src/game/Unit.cpp #0 0x0000000000a6db04 in Unit::SpellDamageBonusTaken (this=0x7fb72c766080, pCaster=0x1204c000, spellProto=0x7fb7785222d0, pdamage=72, damagetype=DOT, stack=1) at /home/mangos/src/game/Unit.cpp:5891 i = {_M_node = 0x7fb74729cdf0} TakenTotalMod = 1 mModDamagePercentTaken = @0x7fb72c7668e8 mDummyAuras = @0x7fb72c7663b8 TakenTotal = 0 TakenAdvertisedBenefit = 32695 tmpDamage = 43750848 #1 0x000000000088f5f0 in Aura::PeriodicTick (this=0x7fb74c26f5b0) at /home/mangos/src/game/SpellAuras.cpp:5894 resist = 0 amount = 72 pdamage = 72 procVictim = 32695 pCaster = 0x1204c000 absorb = 0 cleanDamage = {damage = 0, attackType = BASE_ATTACK, hitOutCome = MELEE_HIT_NORMAL} procAttacker = 11711409 pInfo = {aura = 0x7fb761335560, damage = 9533946, absorb = 0, resist = 1581981624, multiplier = 4.58154533e-41} target = 0x7fb72c766080 spellProto = 0x7fb7785222d0 #2 0x000000000087f39e in Aura::Update (this=0x7fb74c26f5b0, diff=108) at /home/mangos/src/game/SpellAuras.cpp:551 No locals. #3 0x00000000008801c6 in PersistentAreaAura::Update (this=0x7fb74c26f5b0, diff=108) at /home/mangos/src/game/SpellAuras.cpp:767 remove = false #4 0x0000000000895f5e in Aura::UpdateAura (this=0x7fb74c26f5b0, diff=108) at /home/mangos/src/game/SpellAuras.h:419 No locals. #5 0x000000000089419d in SpellAuraHolder::Update (this=0x7fb74c26e570, diff=108) at /home/mangos/src/game/SpellAuras.cpp:7262 aura = 0x7fb74c26f5b0 i = 0 #6 0x0000000000a7b1c5 in SpellAuraHolder::UpdateHolder (this=0x7fb74c26e570, diff=108) at /home/mangos/src/game/SpellAuras.h:105 No locals. #7 0x0000000000a647b6 in Unit::_UpdateSpells (this=0x7fb72c766080, time=108) at /home/mangos/src/game/Unit.cpp:3187 i_holder = 0x7fb74c26e570 #8 0x0000000000a59c21 in Unit::Update (this=0x7fb72c766080, update_diff=108, p_time=108) at /home/mangos/src/game/Unit.cpp:299 No locals. #9 0x0000000000b3a605 in Creature::Update (this=0x7fb72c766080, update_diff=108, diff=108) at /home/mangos/src/game/Creature.cpp:570 No locals. #10 0x00000000008caa23 in WorldObject::UpdateHelper::Update (this=0x7fb761335a20, time_diff=108) at /home/mangos/src/game/Object.h:409 No locals. #11 0x0000000000906899 in MaNGOS::ObjectUpdater::Visit (this=0x7fb761335cc0, m=...) at /home/mangos/src/game/GridNotifiersImpl.h:47 helper = {m_obj = 0x7fb72c766080} iter = {_Ptr = 0x7fb72c7679b8} #12 0x00000000009175ad in void VisitorHelper<MaNGOS::ObjectUpdater, Creature>(MaNGOS::ObjectUpdater&, ContainerMapList<Creature>&) () G3D::_internal::_failureHook = 0xc18d0a <G3D::_internal::_handleErrorCheck_(char const*, std::string const&, char const*, int, bool)> G3D::_internal::_debugHook = 0xc189dd <G3D::_internal::_handleDebugAssert_(char const*, std::string const&, char const*, int, bool)> G3D::_internal::_consolePrintHook = 0 #13 0x0000000000916f52 in VisitorHelper<MaNGOS::ObjectUpdater, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > (v=..., c=...) at /home/mangos/src/framework/GameSystem/TypeContainerVisitor.h:57 No locals. #14 0x00000000009166d2 in VisitorHelper<MaNGOS::ObjectUpdater, GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > (v=..., c=...) at /home/mangos/src/framework/GameSystem/TypeContainerVisitor.h:58 No locals. #15 0x0000000000915634 in VisitorHelper<MaNGOS::ObjectUpdater, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > (v=..., c=...) at /home/mangos/src/framework/GameSystem/TypeContainerVisitor.h:65 No locals. #16 0x0000000000913bec in TypeContainerVisitor<MaNGOS::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >::Visit (this=0x7fb761335c70, c=...) at /home/mangos/src/framework/GameSystem/TypeContainerVisitor.h:80 No locals. #17 0x000000000091101f in Grid<Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<Camera, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >::Visit<MaNGOS::ObjectUpdater> (this=0x19fb0d10, visitor=...) at /home/mangos/src/framework/GameSystem/Grid.h:80 No locals. #18 0x000000000090dcf8 in NGrid<16u, Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<Camera, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >::Visit<MaNGOS::ObjectUpdater, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > (this=0x19fa4000, x=@0x7fb761335b94, y=@0x7fb761335b90, visitor=...) at /home/mangos/src/framework/GameSystem/NGrid.h:156 No locals. #19 0x000000000090954f in Map::Visit<MaNGOS::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > > (this=0x88cc000, cell=..., visitor=...) at /home/mangos/src/game/Map.h:425 x = 39 y = 25 cell_x = 7 cell_y = 5 #20 0x00000000008fbe75 in Map::Update (this=0x88cc000, t_diff=@0x7fb761335d8c) at /home/mangos/src/game/Map.cpp:521 pair = {x_coord = 631, y_coord = 405} cell = {data = {Part = {grid_x = 39, grid_y = 25, cell_x = 7, cell_y = 5, nocreate = 1, reserved = 0}, All = 18118247}} cell_id = 415351 y = 405 x = 631 plr = 0x1204c000 area = {low_bound = {x_coord = 627, y_coord = 401}, high_bound = {x_coord = 634, y_coord = 408}} updater = {i_timeDiff = 108} grid_object_update = {i_visitor = @0x7fb761335cc0} __FUNCTION__ = "Update" __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)" world_object_update = {i_visitor = @0x7fb761335cc0} #21 0x0000000000900a5b in DungeonMap::Update (this=0x88cc000, t_diff=@0x7fb761335d8c) at /home/mangos/src/game/Map.cpp:1492 No locals. #22 0x00000000009a77b7 in MapManager::Update (this=0x7fb761bb4d40, diff=34) at /home/mangos/src/game/MapManager.cpp:262 iter = {_M_node = 0x7fb75e2532b0} iter = {_M_node = 0x4d8f4b1f} #23 0x00000000007b7fae in World::Update (this=0x7fb781a2b900, diff=34) at /home/mangos/src/game/World.cpp:1885 No locals. #24 0x00000000007a7f00 in WorldRunnable::run (this=0x7fb76190c840) at /home/mangos/src/mangosd/WorldRunnable.cpp:60 diff = 34 realCurrTime = 5056192 realPrevTime = 5056158 prevSleepTime = 23 #25 0x0000000000bf9451 in ACE_Based::Thread::ThreadTask (param=0x7fb76190c840) at /home/mangos/src/shared/Threading.cpp:187 _task = 0x7fb76190c840 #26 0x00007fb77f8a6971 in start_thread () from /lib/libpthread.so.0 No symbol table info available. #27 0x00007fb77f60292d in clone () from /lib/libc.so.6 No symbol table info available. #28 0x0000000000000000 in ?? () No symbol table info available. And [New Thread 28629] [New Thread 28630] [New Thread 28616] [New Thread 28619] [New Thread 28632] [New Thread 28618] [New Thread 28633] [New Thread 28631] [New Thread 28620] Core was generated by `./mangosd'. Program terminated with signal 11, Segmentation fault. #0 0x0000000000a705a6 in Unit::MeleeDamageBonusTaken (this=0x7f1893698100, pCaster=0x1083c000, pdamage=186, attType=BASE_ATTACK, spellProto=0x0, damagetype=DIRECT_DAMAGE, stack=1) at /home/mangos/src/game/Unit.cpp:6645 in /home/mangos/src/game/Unit.cpp #0 0x0000000000a705a6 in Unit::MeleeDamageBonusTaken (this=0x7f1893698100, pCaster=0x1083c000, pdamage=186, attType=BASE_ATTACK, spellProto=0x0, damagetype=DIRECT_DAMAGE, stack=1) at /home/mangos/src/game/Unit.cpp:6645 i = {_M_node = 0x7f188e738988} isWeaponDamageBasedSpell = true schoolMask = 1 mechanicMask = 0 TakenPercent = 1 mDummyAuras = @0x7f1893698438 TakenFlat = 0 tmpDamage = 1 #1 0x0000000000a5eb06 in Unit::CalculateMeleeDamage (this=0x1083c000, pVictim=0x7f1893698100, damage=186, damageInfo=0x7f189b13ca30, attackType=BASE_ATTACK) at /home/mangos/src/game/Unit.cpp:1471 No locals. #2 0x0000000000a618f7 in Unit::AttackerStateUpdate (this=0x1083c000, pVictim=0x7f1893698100, attType=BASE_ATTACK, extra=false) at /home/mangos/src/game/Unit.cpp:2275 hitInfo = 2 extraAttacks = 0 damageInfo = {attacker = 0x1083c000, target = 0x7f1893698100, damageSchoolMask = SPELL_SCHOOL_MASK_NORMAL, damage = 0, absorb = 0, resist = 0, blocked_amount = 0, HitInfo = 2, TargetState = 0, attackType = BASE_ATTACK, procAttacker = 4, procVictim = 8, procEx = 0, cleanDamage = 0, hitOutCome = MELEE_HIT_EVADE} #3 0x00000000007d6ad5 in Player::Update (this=0x1083c000, update_diff=101, p_time=101) at /home/mangos/src/game/Player.cpp:1258 owner = 0x8196a5 u = 0x7f189b13cb20 pVictim = 0x7f1893698100 now = 1301237400 pet = 0x0 #4 0x00000000008caa23 in WorldObject::UpdateHelper::Update (this=0x7f189b13cc20, time_diff=101) at /home/mangos/src/game/Object.h:409 No locals. #5 0x00000000008fbbf2 in Map::Update (this=0x8174000, t_diff=@0x7f189b13cd8c) at /home/mangos/src/game/Map.cpp:483 helper = {m_obj = 0x1083c000} plr = 0x1083c000 updater = {i_timeDiff = 101} grid_object_update = {i_visitor = @0x7f189b13ccc0} __FUNCTION__ = "Update" __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)" world_object_update = {i_visitor = @0x7f189b13ccc0} #6 0x0000000000900a5b in DungeonMap::Update (this=0x8174000, t_diff=@0x7f189b13cd8c) at /home/mangos/src/game/Map.cpp:1492 No locals. #7 0x00000000009a77b7 in MapManager::Update (this=0x7f189b9f0d40, diff=33) at /home/mangos/src/game/MapManager.cpp:262 iter = {_M_node = 0x7f1893e97a60} iter = {_M_node = 0x4d8f4e98} #8 0x00000000007b7fae in World::Update (this=0x7f18bb42f900, diff=33) at /home/mangos/src/game/World.cpp:1885 No locals. #9 0x00000000007a7f00 in WorldRunnable::run (this=0x7f189b744840) at /home/mangos/src/mangosd/WorldRunnable.cpp:60 diff = 33 realCurrTime = 842171 realPrevTime = 842138 prevSleepTime = 30 #10 0x0000000000bf9451 in ACE_Based::Thread::ThreadTask (param=0x7f189b744840) at /home/mangos/src/shared/Threading.cpp:187 _task = 0x7f189b744840 #11 0x00007f18b92ad971 in start_thread () from /lib/libpthread.so.0 No symbol table info available. #12 0x00007f18b900992d in clone () from /lib/libc.so.6 No symbol table info available. #13 0x0000000000000000 in ?? () No symbol table info available. Plus I got this new one today : [New Thread 9501] [New Thread 9502] [New Thread 9503] [New Thread 9493] [New Thread 9504] [New Thread 9494] [New Thread 9495] [New Thread 9491] [New Thread 9505] Core was generated by `./mangosd'. Program terminated with signal 11, Segmentation fault. #0 0x0000000000a6ba1c in Unit::HasAuraStateForCaster (this=0xf364000, flag=AURA_STATE_CONFLAGRATE, caster=43698) at /home/mangos/src/game/Unit.cpp:5346 in /home/mangos/src/game/Unit.cpp #0 0x0000000000a6ba1c in Unit::HasAuraStateForCaster (this=0xf364000, flag=AURA_STATE_CONFLAGRATE, caster=43698) at /home/mangos/src/game/Unit.cpp:5346 i = {_M_node = 0x7fa8a0434f88} dotList = @0xf364328 #1 0x0000000000b28b1e in Object::BuildValuesUpdate (this=0xf364000, updatetype=0 '\\000', data=0x7fa8af70b8b0, updateMask=0x7fa8af70b8e0, target=0xf364000) at /home/mangos/src/game/Object.cpp:580 index = 146 IsActivateToQuest = false IsPerCasterAuraState = true __FUNCTION__ = "BuildValuesUpdate" __PRETTY_FUNCTION__ = "void Object::BuildValuesUpdate(uint8, ByteBuffer*, UpdateMask*, Player*) const" #2 0x0000000000b27a6e in Object::BuildValuesUpdateBlockForPlayer (this=0xf364000, data=0x7fa88c4bf828, target=0xf364000) at /home/mangos/src/game/Object.cpp:208 buf = {static DEFAULT_SIZE = 4096, _rpos = 0, _wpos = 237, _storage = {<std::_Vector_base<unsigned char, std::allocator<unsigned char> >> = {_M_impl = {<std::allocator<unsigned char>> = {<__gnu_cxx::new_allocator<unsigned char>> = {<No data fields>}, <No data fields>}, _M_start = 0x7fa87e16ee00 "", _M_finish = 0x7fa87e16eeed "", _M_end_of_storage = 0x7fa87e16eff4 "þå\\bBååååååååÀû\\003ƨ\\177"}}, <No data fields>}} updateMask = {mCount = 1592, mBlocks = 50, mUpdateMask = 0x7fa8ae63a780} #3 0x0000000000b2a510 in Object::BuildUpdateDataForPlayer (this=0xf364000, pl=0xf364000, update_players=...) at /home/mangos/src/game/Object.cpp:963 iter = {<std::tr1::__detail::_Hashtable_iterator_base<std::pair<Player* const, UpdateData>, false>> = {_M_cur_node = 0x7fa88c4bf820, _M_cur_bucket = 0x7fa87df79c88}, <No data fields>} __FUNCTION__ = "BuildUpdateDataForPlayer" __PRETTY_FUNCTION__ = "void Object::BuildUpdateDataForPlayer(Player*, UpdateDataMapType&)" #4 0x0000000000b2f043 in WorldObjectChangeAccumulator::WorldObjectChangeAccumulator (this=0x7fa8af70bab0, obj=..., d=...) at /home/mangos/src/game/Object.cpp:1938 No locals. #5 0x0000000000b2e3a1 in WorldObject::BuildUpdateData (this=0xf364000, update_players=...) at /home/mangos/src/game/Object.cpp:1956 notifier = {i_updateDatas = @0x7fa8af70bb20, i_object = @0xf364000} #6 0x0000000000905923 in Map::SendObjectUpdates (this=0x15398000) at /home/mangos/src/game/Map.cpp:3004 obj = 0xf364000 update_players = {<std::tr1::__unordered_map<Player*, UpdateData, std::tr1::hash<Player*>, std::equal_to<Player*>, std::allocator<std::pair<Player* const, UpdateData> >, false>> = {<std::tr1::_Hashtable<Player*, std::pair<Player* const, UpdateData>, std::allocator<std::pair<Player* const, UpdateData> >, std::_Select1st<std::pair<Player* const, UpdateData> >, std::equal_to<Player*>, std::tr1::hash<Player*>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true>> = {<std::tr1::__detail::_Rehash_base<std::tr1::__detail::_Prime_rehash_policy, std::tr1::_Hashtable<Player*, std::pair<Player* const, UpdateData>, std::allocator<std::pair<Player* const, UpdateData> >, std::_Select1st<std::pair<Player* const, UpdateData> >, std::equal_to<Player*>, std::tr1::hash<Player*>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true> >> = {<No data fields>}, <std::tr1::__detail::_Hash_code_base<Player*, std::pair<Player* const, UpdateData>, std::_Select1st<std::pair<Player* const, UpdateData> >, std::equal_to<Player*>, std::tr1::hash<Player*>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, false>> = {_M_extract = {<std::unary_function<std::pair<Player* const, UpdateData>, Player* const>> = {<No data fields>}, <No data fields>}, _M_eq = {<std::binary_function<Player*, Player*, bool>> = {<No data fields>}, <No data fields>}, _M_h1 = {<std::unary_function<Player*, unsigned long>> = {<No data fields>}, <No data fields>}, _M_h2 = {<No data fields>}}, <std::tr1::__detail::_Map_base<Player*, std::pair<Player* const, UpdateData>, std::_Select1st<std::pair<Player* const, UpdateData> >, true, std::tr1::_Hashtable<Player*, std::pair<Player* const, UpdateData>, std::allocator<std::pair<Player* const, UpdateData> >, std::_Select1st<std::pair<Player* const, UpdateData> >, std::equal_to<Player*>, std::tr1::hash<Player*>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true> >> = {<No data fields>}, _M_node_allocator = {<__gnu_cxx::new_allocator<std::tr1::__detail::_Hash_node<std::pair<Player* const, UpdateData>, false> >> = {<No data fields>}, <No data fields>}, _M_buckets = 0x7fa87df79c60, _M_bucket_count = 11, _M_element_count = 9, _M_rehash_policy = {_M_max_load_factor = 1, _M_growth_factor = 2, _M_next_resize = 11}}, <No data fields>}, <No data fields>} packet = {<ByteBuffer> = {static DEFAULT_SIZE = 4096, _rpos = 140362474634032, _wpos = 140362474634224, _storage = {<std::_Vector_base<unsigned char, std::allocator<unsigned char> >> = {_M_impl = {<std::allocator<unsigned char>> = {<__gnu_cxx::new_allocator<unsigned char>> = {<No data fields>}, <No data fields>}, _M_start = 0x7fa8af70bbb0 "à¼p¯¨\\177", _M_finish = 0x89e1d <Address 0x89e1d out of bounds>, _M_end_of_storage = 0x7fa8af70bb40 ""}}, <No data fields>}}, m_opcode = 61507} #7 0x00000000008fc184 in Map::Update (this=0x15398000, t_diff=@0x7fa8af70bd8c) at /home/mangos/src/game/Map.cpp:568 updater = {i_timeDiff = 147} grid_object_update = {i_visitor = @0x7fa8af70bcc0} __FUNCTION__ = "Update" __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)" world_object_update = {i_visitor = @0x7fa8af70bcc0} #8 0x00000000009012e1 in BattleGroundMap::Update (this=0x15398000, diff=@0x7fa8af70bd8c) at /home/mangos/src/game/Map.cpp:1628 No locals. #9 0x00000000009a77b7 in MapManager::Update (this=0x7fa8affb4c60, diff=48) at /home/mangos/src/game/MapManager.cpp:262 iter = {_M_node = 0x7fa8829fcc70} iter = {_M_node = 0x4d8f3707} #10 0x00000000007b7fae in World::Update (this=0x7fa8cfcff900, diff=48) at /home/mangos/src/game/World.cpp:1885 No locals. #11 0x00000000007a7f00 in WorldRunnable::run (this=0x7fa8afd04830) at /home/mangos/src/mangosd/WorldRunnable.cpp:60 diff = 48 realCurrTime = 49851291 realPrevTime = 49851243 prevSleepTime = 46 #12 0x0000000000bf9451 in ACE_Based::Thread::ThreadTask (param=0x7fa8afd04830) at /home/mangos/src/shared/Threading.cpp:187 _task = 0x7fa8afd04830 #13 0x00007fa8cdb7c971 in start_thread () from /lib/libpthread.so.0 No symbol table info available. #14 0x00007fa8cd8d892d in clone () from /lib/libc.so.6 No symbol table info available. #15 0x0000000000000000 in ?? () No symbol table info available. line 5891 of Unit.cpp is : switch((*i)->GetSpellProto()->SpellIconID) line 6645 is the same, for melee. line 5346 is: if ((*i)->GetSpellProto()->SpellFamilyName == SPELLFAMILY_WARLOCK && (*i)->GetCasterGUID() == caster && // Immolate ((*i)->GetSpellProto()->SpellFamilyFlags & UI64LIT(0x0000000000000004))) I'm trying to solve this right now, be maybe someone have an idea where that can come from

I got this one too, because of C++ limitation. I solved it by replacing GetMovementGeneratorType() by this->GetMovementGeneratorType() (C++ need precisions here). But maybe it's not the way the author intended to do it, so maybe qsa solution is better !

I'll test it on one as soon as possible (but hard week at work so not before week end I'm afraid ) edit: tested both patches right now, patch 2 give strange movements, but patch 1 works like a charm ! Really great job, thank you very much, I'll try to install that on a realm with player to test it in deep, but once again, great job with this project !

For [s0863] for retreiving the datas from the data_backup table you provide this : UPDATE characters, data_backup SET exploredZones = SUBSTRING(DATA, LENGTH(SUBSTRING_INDEX(DATA, ' ', 1332))+2, LENGTH(SUBSTRING_INDEX(DATA, ' ', 1459+1))- LENGTH(SUBSTRING_INDEX(DATA, ' ', 1332)) - 1) but isn't this : UPDATE characters, data_backup SET exploredZones = SUBSTRING(DATA, LENGTH(SUBSTRING_INDEX(DATA, ' ', 1332))+2, LENGTH(SUBSTRING_INDEX(DATA, ' ', 1459+1))- LENGTH(SUBSTRING_INDEX(DATA, ' ', 1332)) - 1) WHERE characters.guid = data_backup.guid; more like it ?

Tested, it's working too, with [s0868].

diff --git a/src/game/Player.cpp b/src/game/Player.cpp index 60547a2..9206306 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -14294,6 +14294,15 @@ bool Player::LoadFromDB( uint32 guid, SqlQueryHolder *holder ) return false; } + + SetByteValue(UNIT_FIELD_BYTES_2, 1, UNIT_BYTE2_FLAG_AURAS ); + // overwrite possible wrong/corrupted guid SetGuidValue(OBJECT_FIELD_GUID, ObjectGuid(HIGHGUID_PLAYER, guid)); That fix seems to work

Yep sorry if I explained it wrong! English is not my native langage either '

Okay, the incriminated field is UNIT_FIELD_BYTES_2 (UNIT_BYTE2_FLAG_AURAS maybe ?). When loaded from the data field, the buff appear okay but when not loaded, the buff looks like debuffs. I'll try to find a way to fix it.

On my side, every buff causes the problem (if I just click on my portrait to select myself, I see my buff as debuff). I'll tell you as soon as I found something about the field that causes that.

Thanks Vladimir, I'm on the aura problem too, looks like it comes from one of the EUnitFields, not the playerfield, I'm testing them to find which one.

Exactly ! After the update all is reset but then it works correctly when you discover new zones. That's what I thought, so because this bug is data field dependent, I guess it could be something like characters faction or property that causes that, but I didn't find any difference in thoses fields with or without the data field... Still searching.

Worked hard but couldn't find what field causes that I hope someone with more knowledge of this can help me. I tried forcing loading the old data field by adding that back : if(!LoadValues( fields[60].GetString())) { sLog.outError("Player #%d have broken data in `data` field. Can't be loaded.", GUID_LOPART(guid)); delete result; return false; } of course I changed the main query. Then the data field loads and the buff shows correctly, but that doesn't fix the problem, only show that's where it's from.

Hello, Using One branch, I updated today from [s0852] to [s0860] (no particular patch) and all the player's buff are appearing as debuff for players of the same faction or group. Look like it only does this when you are near the other player. From a distance you're seeing the buff like usual. I can't figure out why yet but I was wondering if anyone have the same issue. Maybe due to the data blob disappearance? Or problem from my setup ? If anyone can confirm this, thank you ! Edit: I should add that when applying the sql patch from [s0858], my exploredZone have been reset, the field was filled with numbers but in game all the maps went undiscovered. Edit 2: I confirm that [s0858] is responsible for this, but still don't know why or how to fix yet It seems like one field remains not loaded but I can't figure out which one.

You're using the wrong tool - on the left, select Pathfind Follow or Pathfind Straight. Hmm *cough* thanks I was pretty sure I selected the good tools but it should have deselected it while I was searching for the "build" button ^^ Anyway, here's the result : http://img703.imageshack.us/i/bwla.jpg/ It looks ok I think, so the reason why the mob desappear should be in the server core and not caused by the mmaps generator. Probably because of the remaining differences between master and one, like ambal's modifications like you said. This is maybe still over my head but I'm still available for help I can do any good.

Okay, I extracted the debug mmaps, for BWL, precisely the platform where Razorgore is standing. The strcuture looks okay but the path looks... weird. I don't know how to really interpret the results, maybe you'll have a better opinion. Here's an image of it : http://img826.imageshack.us/i/bwlv.jpg/

Okay, thanks qsa, I'll extract them with --debugOutput

qsa : I tried to open my mmaps file into RecastDome but could manage to do it (such a noob...) I renamed them .map and .mesh in the meshes folder but the app crashes. I took the files from the mmaps folder. Could you give me a hint on how I should open the mmaps in RecastDemo ?

I'm sorry to bring that back, but did anyone else tried to apply this great project to a mangos-one ? I'm still trying to help, but didn't find out yet why the mobs disappear when aggroed. Maybe it's the mmaps extractor that needs more modification than I already did (I just in fact changed the MAGIC ver. and deleted the "holes" part of the extraction. If somebody more competent then me have some leads, I'll try to dig a little more. Thank to all who works and this project anyway

There's no "Thanks" button here but thank you for your reports about all this stfxpi!

Thanks for these precisions faramir118. I tried a simple porting of mmaps, compiled fine, generating mmaps without holes, looks like it worked, but in game, some mobs on normal waypoint moves are juste making mangos to freeze big time, and in everyother way, when mobs are pulled from distance, then just disappear until they reach the player. After looking a bit into the code from master, I see why you were saying that Ambal's project would be a good thing to backport ! Good luck fixing all (cause I don't think I will be able to ^^') that and most of all conciliating it with you real-life work, I'll be available for test or anything, if I can help I will.

Patman128> Yeah I did that and manage to compile the core and everything, but when using the MoveMapGen to build mmaps, the app crashes right after "Loading heightmap...", I can't figure out why yet. Maybe the 2.4.3 maps have less datas and cause some memsets to crash, I don't know, that's kind of out of my knowledge. As far as I know after looking and searching through the code, it's this line in TerrainBuilder.cpp that crashes the app // hole data memset(holes, 0, fheader.holesSize); After looking at the GridMapFileHeader structure in mangos-one, this structure don't have the uint32 holesOffset and uint32 holesSize fields. So I guess that will be a problem. I don't know if the mmaps system can working if we simply ignore the holes...

faramir118, first I hope you had great vacations Then, when you'll have the time, could you point me to the commits of your repo I should cherry-pick in order to test your great mmaps project on mangos-one ? Now than mangos-one have vmap3, I'd really like to give it a try !

Well done ! Thanks a lot!

I tryied the https://github.com/VladimirMangos/mangos version of vmap3 and didn't noticed any change : all the bugs are still there (for example being sheeped near the flag in warsong gulch is 100% undermap), the mobs still half falls underground when climbing an inclined floor and the lava in and near molten core still doesn't do any damage. Is that normal or is there something wrong at my side? Or maybe all of this isn't vmap related, i'm not sure.