Oniryck

Hi, I don't know if the bug is general, but I got it after the [Work vs Auras] commit. When a rogue got the Feary Fire debuff applyied, he can no longuer stealth even after the bebuff is gone (the stealth icon stays grey). The only solution was to clear the client cache and relog. So here is my fix for this probelm. I guess there may be a better solution, but it's working. diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 2a3d2de..792793d 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -1104,6 +1104,11 @@ bool Aura::_RemoveAura() m_target->ModifyAuraState(AURA_STATE_DEADLY_POISON,false); } + + // Faerie Fire (druid versions) + if (m_spellProto->SpellFamilyName == SPELLFAMILY_DRUID && m_spellProto->SpellFamilyFlags & UI64LIT(0x0000000000000400)) + m_target->ModifyAuraState(AURA_STATE_FAERIE_FIRE, false); + // reset cooldown state for spells if(caster && caster->GetTypeId() == TYPEID_PLAYER) { Maybe this can be useful if anyone has the same bug. EDIT : It should be fixed in http://github.com/mangos/mangos/commit/2177a4d340567ee1211a8fcc6305d7f9c82870ad so nevermind

Confirmed too. Aura::SetStackAmount() seems to send the correct stackAmount integer, so the problems looks just visual, but stil didn't find out where exactly the client miscount from 1 to 5 (and instead goes 1-3-4-5-6 or 1-4-4-5-6, etc..)

Congratulation and thanks for this huge work ! Any chance this will be applied to the 0.12 branch in the future, now that this have been accepted?

Hi, in the last 0.12 rev. I saw that while in a raid group, with a quest flagged as RAID, you where unable to loot the required quest item. It's just a small typo from converting the old direct call the the flag to the function isAllowedInRaid() Here is the fix : diff --git a/src/game/Player.cpp b/src/game/Player.cpp index 1746624..6b11490 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -13621,7 +13621,7 @@ bool Player::HasQuestForItem( uint32 itemid ) const continue; // hide quest if player is in raid-group and quest is no raid quest - if (GetGroup() && GetGroup()->isRaidGroup() && qinfo->IsAllowedInRaid() && !InBattleGround()) + if (GetGroup() && GetGroup()->isRaidGroup() && !qinfo->IsAllowedInRaid() && !InBattleGround()) continue; // There should be no mixed ReqItem/ReqSource drop @@ -18604,7 +18604,7 @@ bool Player::HasQuestForGO(int32 GOId) const if(!qinfo) continue; - if(GetGroup() && GetGroup()->isRaidGroup() && qinfo->IsAllowedInRaid()) + if(GetGroup() && GetGroup()->isRaidGroup() && !qinfo->IsAllowedInRaid()) continue; for (int j = 0; j < QUEST_OBJECTIVES_COUNT; ++j) Hope this can help. Sorry if it's already fixed.

After some tests, concerning the improved blizzard I found that case 989: // Improved Blizzard (Rank 3) { if (!procSpell) || procSpell->SpellVisual!=9487) return false; triggered_spell_id = 12486; break; is a part of the problem. In fact, the SpellVisual is partly wrong from my DBC file. SpellVisual is 9487 for the spell triggered by the main blizzard spell but is 9490 for the spell itself. But maybe that is on purpose? I don't know Anyway when changing the SpellVisual to 9490 in the code I have the Improved Blizzard spell triggered but the slowing debuff is casted on the caster and only once (In fact it should trigger at targets under the blizzard and every tick of it) I'm still trying to find a way to correct this (and the deep wound thing) but I'm not that familiar with spell mechanic... And sorry for the title, I tried to change it but it didn't work Edit: fixed that the hacky way for now, still trying to found a proper way to fix it.

Ok, look that this only happens when the user as a divine shield like aura on him. Else, the blizzard damages seems okay. Guess it makes him immune to his own spell too or something like that... Anyway, another problem is that improved blizzard don't seem to proc, but I guess that have to do with spell proc event or something. Edit: Also when casting blizzard, it seems that it does not affect out of sight unit, even if they are in the radius of the spell. They should be affect anyway if I'm not mistaking. Edit2: Seems like some other proc spell aren't working, like deep wound

Hi, I found a problem with latest rev. of the 0.12 branch : spells (like http://www.wowhead.com/spell=10187 and ranks) that have spelleffect27 and a second spelleffectindex do not apply the second effect. For exemple with the blizzard spell : effect 27 work, the blizzard shows up but the second effect (6) don't work and then the blizzard does zero damage. Same for all the spells like that (like rain of fire, etc..) Currently trying to solve the problem but if you already have a solution or hint, it'd be welcome

Okay, thanks for the update, hope your issues will be solved and you'll be ok. Hoped I could help with this but I don't really master opcodes and stuff yet ^^

Very promising work, well done ! But, I tested it, and it didn't work for me : the interface works very well, but the group maker don't. I put 5 charecters (1 tank, 1 healer, 3 dd) in the queue, but no group has been formed. And the only icon colored in "group composition"is the character's. Hope this can be completed

Hum I see... Thank you for your answer! I thought it was in the map since I could see it with wow map viewer. But I don't see the object in my database (UDB ). I found sources that say I have to create object template with the right modelid but that seems strange... Edit: Found my infos - sorry for asking DB related stuff here

Same issue here All the rest of the instance appears to be OK, but the frozen throne is invisible, despite we can see it in the minimap I also regenerated the maps twice

got the same problem. like all "Apply Aura: Add Class Target Trigger", like frostbite for example, it's not working anymore for mangos-0.12 rev 8569

I've got the same problem here. I tried to fix it, but all I found is a rewriting of diminishing mechanics, but that don't seem to be the problem. Hope someone will be able to help...

Wow, I don't see HOW this prevented improved scorch from working

http://github.com/CWN/mangos/commits/speed_cheat_fix-0.12 Je suis français aussi I'm using this repositery on my server, it works very well, but I admit I'd prefer it as a patch to apply it on the lastest releases of the 0.12 branche